Change to use APPEND_FORWARD for terminating gateway

Signed-off-by: Mark Anderson <manderson@hashicorp.com>
pull/12878/head
Mark Anderson 3 years ago
parent 6430af1c0e
commit 863bc16530

@ -1153,9 +1153,8 @@ func (s *ResourceGenerator) makeFilterChainTerminatingGateway(
if meshConfig := cfgSnap.MeshConfig(); meshConfig == nil || meshConfig.HTTP == nil || !meshConfig.HTTP.SanitizeXForwardedClientCert { if meshConfig := cfgSnap.MeshConfig(); meshConfig == nil || meshConfig.HTTP == nil || !meshConfig.HTTP.SanitizeXForwardedClientCert {
opts.forwardClientDetails = true opts.forwardClientDetails = true
// Note: filter Connection may not be mTLS, so then ALWAYS_FORWARD_ONLY. For mTLS connections we might want APPEND_FORWARD. // This assumes that we have a client cert (mTLS) (implied by the context of this function)
// Open question; how do I determine if this is mTLS or not? opts.forwardClientPolicy = envoy_http_v3.HttpConnectionManager_APPEND_FORWARD
opts.forwardClientPolicy = envoy_http_v3.HttpConnectionManager_ALWAYS_FORWARD_ONLY
} }
} }

Loading…
Cancel
Save