Fix subtle loop bug and add test

pull/10903/head
Paul Banks 3 years ago
parent 07f81991df
commit 70bc89b7f4

@ -270,8 +270,11 @@ func findIngressServiceMatchingUpstream(l structs.IngressListener, u structs.Ups
return &s return &s
} }
if s.Name == structs.WildcardSpecifier && if s.Name == structs.WildcardSpecifier &&
s.NamespaceOrDefault() == wantSID.NamespaceOrDefault() { s.NamespaceOrDefault() == wantSID.NamespaceOrDefault() &&
foundSameNSWildcard = &s s.PartitionOrDefault() == wantSID.PartitionOrDefault() {
// Make a copy so we don't take a reference to the loop variable
found := s
foundSameNSWildcard = &found
} }
} }
// Didn't find an exact match. Return the wildcard from same service if we // Didn't find an exact match. Return the wildcard from same service if we

Loading…
Cancel
Save