@ -6,17 +6,20 @@ package workloadhealth
import (
"context"
"fmt"
"github.com/hashicorp/consul/internal/resource"
"google.golang.org/protobuf/testing/protocmp"
"testing"
"time"
"github.com/stretchr/testify/require"
"github.com/stretchr/testify/suite"
"github.com/hashicorp/consul/internal/resource"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/status"
"google.golang.org/protobuf/testing/protocmp"
"github.com/stretchr/testify/require"
"github.com/stretchr/testify/suite"
svc "github.com/hashicorp/consul/agent/grpc-external/services/resource"
svctest "github.com/hashicorp/consul/agent/grpc-external/services/resource/testing"
"github.com/hashicorp/consul/agent/structs"
"github.com/hashicorp/consul/internal/catalog/internal/controllers/nodehealth"
"github.com/hashicorp/consul/internal/catalog/internal/mappers/nodemapper"
"github.com/hashicorp/consul/internal/catalog/internal/types"
@ -45,10 +48,15 @@ var (
}
)
func resourceID ( rtype * pbresource . Type , name string ) * pbresource . ID {
func resourceID ( rtype * pbresource . Type , name string , tenancy * pbresource . Tenancy ) * pbresource . ID {
defaultTenancy := resource . DefaultNamespacedTenancy ( )
if tenancy != nil {
defaultTenancy = tenancy
}
return & pbresource . ID {
Type : rtype ,
Tenancy : resource . DefaultNamespacedTenancy ( ) ,
Tenancy : defaultTenancy ,
Name : name ,
}
}
@ -79,18 +87,31 @@ type controllerSuite struct {
suite . Suite
client pbresource . ResourceServiceClient
runtime controller . Runtime
isEnterprise bool
tenancies [ ] * pbresource . Tenancy
}
func ( suite * controllerSuite ) SetupTest ( ) {
suite . client = svctest . RunResourceService ( suite . T ( ) , types . Register )
suite . tenancies = resourcetest . TestTenancies ( )
mockTenancyBridge := & svc . MockTenancyBridge { }
for _ , tenancy := range suite . tenancies {
mockTenancyBridge . On ( "PartitionExists" , tenancy . Partition ) . Return ( true , nil )
mockTenancyBridge . On ( "IsPartitionMarkedForDeletion" , tenancy . Partition ) . Return ( false , nil )
mockTenancyBridge . On ( "NamespaceExists" , tenancy . Partition , tenancy . Namespace ) . Return ( true , nil )
mockTenancyBridge . On ( "IsNamespaceMarkedForDeletion" , tenancy . Partition , tenancy . Namespace ) . Return ( false , nil )
}
suite . client = svctest . RunResourceServiceWithConfig ( suite . T ( ) , svc . Config { TenancyBridge : mockTenancyBridge } , types . Register )
suite . runtime = controller . Runtime { Client : suite . client , Logger : testutil . Logger ( suite . T ( ) ) }
suite . isEnterprise = ( structs . NodeEnterpriseMetaInDefaultPartition ( ) . PartitionOrEmpty ( ) == "default" )
}
// injectNodeWithStatus is a helper method to write a Node resource and synthesize its status
// in a manner consistent with the node-health controller. This allows us to not actually
// run and test the node-health controller but consume its "api" in the form of how
// it encodes status.
func ( suite * controllerSuite ) injectNodeWithStatus ( name string , health pbcatalog . Health ) * pbresource . Resource {
func ( suite * controllerSuite ) injectNodeWithStatus ( name string , health pbcatalog . Health , tenancy * pbresource . Tenancy ) * pbresource . Resource {
suite . T ( ) . Helper ( )
state := pbresource . Condition_STATE_TRUE
if health >= pbcatalog . Health_HEALTH_WARNING {
@ -99,6 +120,7 @@ func (suite *controllerSuite) injectNodeWithStatus(name string, health pbcatalog
return resourcetest . Resource ( pbcatalog . NodeType , name ) .
WithData ( suite . T ( ) , nodeData ) .
WithTenancy ( tenancy ) .
WithStatus ( nodehealth . StatusKey , & pbresource . Status {
Conditions : [ ] * pbresource . Condition {
{
@ -142,18 +164,20 @@ func (suite *workloadHealthControllerTestSuite) SetupTest() {
//
// * The node to workload association is now being tracked by the node mapper
// * The workloads status was updated and now matches the expected value
func ( suite * workloadHealthControllerTestSuite ) testReconcileWithNode ( nodeHealth , workloadHealth pbcatalog . Health , status * pbresource . Condition ) * pbresource . Resource {
func ( suite * workloadHealthControllerTestSuite ) testReconcileWithNode ( nodeHealth , workloadHealth pbcatalog . Health , tenancy * pbresource . Tenancy , status * pbresource . Condition ) * pbresource . Resource {
suite . T ( ) . Helper ( )
node := suite . injectNodeWithStatus ( "test-node" , nodeHealth )
node := suite . injectNodeWithStatus ( "test-node" , nodeHealth , tenancy )
workload := resourcetest . Resource ( pbcatalog . WorkloadType , "test-workload" ) .
WithData ( suite . T ( ) , workloadData ( node . Id . Name ) ) .
WithTenancy ( tenancy ) .
Write ( suite . T ( ) , suite . client )
resourcetest . Resource ( pbcatalog . HealthStatusType , "test-status" ) .
WithData ( suite . T ( ) , & pbcatalog . HealthStatus { Type : "tcp" , Status : workloadHealth } ) .
WithOwner ( workload . Id ) .
WithTenancy ( tenancy ) .
Write ( suite . T ( ) , suite . client )
err := suite . reconciler . Reconcile ( context . Background ( ) , suite . runtime , controller . Request {
@ -189,14 +213,16 @@ func (suite *workloadHealthControllerTestSuite) testReconcileWithNode(nodeHealth
// This is really just a tirmmed down version of testReconcileWithNode. It seemed
// simpler and easier to read if these were two separate methods instead of combining
// them in one with more branching based off of detecting whether nodes are in use.
func ( suite * workloadHealthControllerTestSuite ) testReconcileWithoutNode ( workloadHealth pbcatalog . Health , status * pbresource . Condition ) * pbresource . Resource {
func ( suite * workloadHealthControllerTestSuite ) testReconcileWithoutNode ( workloadHealth pbcatalog . Health , tenancy * pbresource . Tenancy , status * pbresource . Condition ) * pbresource . Resource {
suite . T ( ) . Helper ( )
workload := resourcetest . Resource ( pbcatalog . WorkloadType , "test-workload" ) .
WithData ( suite . T ( ) , workloadData ( "" ) ) .
WithTenancy ( tenancy ) .
Write ( suite . T ( ) , suite . client )
resourcetest . Resource ( pbcatalog . HealthStatusType , "test-status" ) .
WithData ( suite . T ( ) , & pbcatalog . HealthStatus { Type : "tcp" , Status : workloadHealth } ) .
WithTenancy ( tenancy ) .
WithOwner ( workload . Id ) .
Write ( suite . T ( ) , suite . client )
@ -356,12 +382,14 @@ func (suite *workloadHealthControllerTestSuite) TestReconcile() {
for name , tcase := range cases {
suite . Run ( name , func ( ) {
suite . runTestCaseWithTenancies ( func ( tenancy * pbresource . Tenancy ) {
if tcase . nodeHealth != pbcatalog . Health_HEALTH_ANY {
suite . testReconcileWithNode ( tcase . nodeHealth , tcase . workloadHealth , tcase . expectedStatus )
suite . testReconcileWithNode ( tcase . nodeHealth , tcase . workloadHealth , tenancy , tcase . expectedStatus )
} else {
suite . testReconcileWithoutNode ( tcase . workloadHealth , tcase . expectedStatus )
suite . testReconcileWithoutNode ( tcase . workloadHealth , tenancy , tcase . expectedStatus )
}
} )
} )
}
}
@ -372,27 +400,30 @@ func (suite *workloadHealthControllerTestSuite) TestReconcileReadError() {
// Passing a resource with an unknown type isn't particularly realistic as the controller
// manager running our reconciliation will ensure all resource ids used are valid. However
// its a really easy way right not to force the error.
id := resourceID ( fakeType , "blah" )
suite . runTestCaseWithTenancies ( func ( tenancy * pbresource . Tenancy ) {
id := resourceID ( fakeType , "blah" , tenancy )
err := suite . reconciler . Reconcile ( context . Background ( ) , suite . runtime , controller . Request { ID : id } )
require . Error ( suite . T ( ) , err )
require . Equal ( suite . T ( ) , codes . InvalidArgument , status . Code ( err ) )
} )
}
func ( suite * workloadHealthControllerTestSuite ) TestReconcileNotFound ( ) {
// This test wants to ensure that tracking for a workload is removed when the workload is deleted
// so this test will inject the tracking, issue the Reconcile call which will get a
// not found error and then ensure that the tracking was removed.
suite . runTestCaseWithTenancies ( func ( tenancy * pbresource . Tenancy ) {
workload := resourcetest . Resource ( pbcatalog . WorkloadType , "foo" ) .
WithData ( suite . T ( ) , workloadData ( "test-node" ) ) .
// don't write this because then in the call to reconcile the resource
// would be found and defeat the purpose of the tes
WithTenancy ( resource. Defaul tNamespacedT enancy( ) ) .
WithTenancy ( tenancy) .
Build ( )
node := resourcetest . Resource ( pbcatalog . NodeType , "test-node" ) .
WithData ( suite . T ( ) , nodeData ) .
WithTenancy ( tenancy ) .
// Whether this gets written or not doesn't matter
Build ( )
@ -422,6 +453,7 @@ func (suite *workloadHealthControllerTestSuite) TestReconcileNotFound() {
reqs , err = suite . mapper . MapNodeToWorkloads ( context . Background ( ) , suite . runtime , node )
require . NoError ( suite . T ( ) , err )
require . Empty ( suite . T ( ) , reqs )
} )
}
func ( suite * workloadHealthControllerTestSuite ) TestGetNodeHealthError ( ) {
@ -434,17 +466,21 @@ func (suite *workloadHealthControllerTestSuite) TestGetNodeHealthError() {
// but the exact error isn't very relevant to the core reason this
// test exists.
suite . runTestCaseWithTenancies ( func ( tenancy * pbresource . Tenancy ) {
node := resourcetest . Resource ( pbcatalog . NodeType , "test-node" ) .
WithData ( suite . T ( ) , nodeData ) .
WithTenancy ( tenancy ) .
Write ( suite . T ( ) , suite . client )
workload := resourcetest . Resource ( pbcatalog . WorkloadType , "test-workload" ) .
WithData ( suite . T ( ) , workloadData ( node . Id . Name ) ) .
WithTenancy ( tenancy ) .
Write ( suite . T ( ) , suite . client )
resourcetest . Resource ( pbcatalog . HealthStatusType , "test-status" ) .
WithData ( suite . T ( ) , & pbcatalog . HealthStatus { Type : "tcp" , Status : pbcatalog . Health_HEALTH_CRITICAL } ) .
WithOwner ( workload . Id ) .
WithTenancy ( tenancy ) .
Write ( suite . T ( ) , suite . client )
err := suite . reconciler . Reconcile ( context . Background ( ) , suite . runtime , controller . Request {
@ -453,6 +489,7 @@ func (suite *workloadHealthControllerTestSuite) TestGetNodeHealthError() {
require . Error ( suite . T ( ) , err )
require . Equal ( suite . T ( ) , errNodeUnreconciled , err )
} )
}
func ( suite * workloadHealthControllerTestSuite ) TestReconcile_AvoidReconciliationWrite ( ) {
@ -461,13 +498,14 @@ func (suite *workloadHealthControllerTestSuite) TestReconcile_AvoidReconciliatio
// we check that calling Reconcile twice in a row without any actual health change
// doesn't bump the Version (which would increased for any write of the resource
// or its status)
suite . runTestCaseWithTenancies ( func ( tenancy * pbresource . Tenancy ) {
status := & pbresource . Condition {
Type : StatusConditionHealthy ,
State : pbresource . Condition_STATE_FALSE ,
Reason : "HEALTH_WARNING" ,
Message : WorkloadUnhealthyMessage ,
}
res1 := suite . testReconcileWithoutNode ( pbcatalog . Health_HEALTH_WARNING , status )
res1 := suite . testReconcileWithoutNode ( pbcatalog . Health_HEALTH_WARNING , tenancy , status )
err := suite . reconciler . Reconcile ( context . Background ( ) , suite . runtime , controller . Request { ID : res1 . Id } )
require . NoError ( suite . T ( ) , err )
@ -479,6 +517,7 @@ func (suite *workloadHealthControllerTestSuite) TestReconcile_AvoidReconciliatio
// therefore proves that after a second reconciliation without any change
// in status that the controller is not making extra status writes.
require . Equal ( suite . T ( ) , res1 . Version , res2 . Version )
} )
}
func ( suite * workloadHealthControllerTestSuite ) TestController ( ) {
@ -498,19 +537,20 @@ func (suite *workloadHealthControllerTestSuite) TestController() {
// run the manager
go mgr . Run ( ctx )
// create a node to link things with
node := suite . injectNodeWithStatus ( "test-node" , pbcatalog . Health_HEALTH_PASSING )
suite . controllerSuite . runTestCaseWithTenancies ( func ( tenancy * pbresource . Tenancy ) {
node := suite . injectNodeWithStatus ( "test-node" , pbcatalog . Health_HEALTH_PASSING , tenancy )
// create the workload
workload := resourcetest . Resource ( pbcatalog . WorkloadType , "test-workload" ) .
WithData ( suite . T ( ) , workloadData ( node . Id . Name ) ) .
WithTenancy ( tenancy ) .
Write ( suite . T ( ) , suite . client )
// Wait for reconciliation to occur and mark the workload as passing.
suite . waitForReconciliation ( workload . Id , "HEALTH_PASSING" )
// Simulate a node unhealthy
suite . injectNodeWithStatus ( "test-node" , pbcatalog . Health_HEALTH_WARNING )
suite . injectNodeWithStatus ( "test-node" , pbcatalog . Health_HEALTH_WARNING , tenancy )
// Wait for reconciliation to occur and mark the workload as warning
// due to the node going into the warning state.
@ -522,6 +562,7 @@ func (suite *workloadHealthControllerTestSuite) TestController() {
resourcetest . Resource ( pbcatalog . HealthStatusType , "test-status" ) .
WithData ( suite . T ( ) , & pbcatalog . HealthStatus { Type : "tcp" , Status : pbcatalog . Health_HEALTH_CRITICAL } ) .
WithOwner ( workload . Id ) .
WithTenancy ( tenancy ) .
Write ( suite . T ( ) , suite . client )
// Wait for reconciliation to occur again and mark the workload as unhealthy
@ -531,14 +572,17 @@ func (suite *workloadHealthControllerTestSuite) TestController() {
resourcetest . Resource ( pbcatalog . HealthStatusType , "test-status" ) .
WithData ( suite . T ( ) , & pbcatalog . HealthStatus { Type : "tcp" , Status : pbcatalog . Health_HEALTH_PASSING } ) .
WithOwner ( workload . Id ) .
WithTenancy ( tenancy ) .
Write ( suite . T ( ) , suite . client )
workload = resourcetest . Resource ( pbcatalog . WorkloadType , "test-workload" ) .
WithData ( suite . T ( ) , workloadData ( "" ) ) .
WithTenancy ( tenancy ) .
Write ( suite . T ( ) , suite . client )
// Now that the workload health is passing and its not associated with the node its status should
// eventually become passing
suite . waitForReconciliation ( workload . Id , "HEALTH_PASSING" )
} )
}
// wait for reconciliation is a helper to check if a resource has been reconciled and
@ -569,7 +613,7 @@ type getWorkloadHealthTestSuite struct {
controllerSuite
}
func ( suite * getWorkloadHealthTestSuite ) addHealthStatuses ( workload * pbresource . ID , desiredHealth pbcatalog . Health ) {
func ( suite * getWorkloadHealthTestSuite ) addHealthStatuses ( workload * pbresource . ID , tenancy * pbresource . Tenancy , desiredHealth pbcatalog . Health ) {
// In order to exercise the behavior to ensure that the ordering a health status is
// seen doesn't matter this is strategically naming health status so that they will be
// returned in an order with the most precedent status being in the middle of the list.
@ -590,6 +634,7 @@ func (suite *getWorkloadHealthTestSuite) addHealthStatuses(workload *pbresource.
if desiredHealth >= health {
resourcetest . Resource ( pbcatalog . HealthStatusType , fmt . Sprintf ( "check-%s-%d" , workload . Name , idx ) ) .
WithData ( suite . T ( ) , & pbcatalog . HealthStatus { Type : "tcp" , Status : health } ) .
WithTenancy ( tenancy ) .
WithOwner ( workload ) .
Write ( suite . T ( ) , suite . client )
}
@ -601,23 +646,28 @@ func (suite *getWorkloadHealthTestSuite) TestListError() {
// getWorkloadHealth. When the resource listing fails, we want to
// propagate the error which should eventually result in retrying
// the operation.
health , err := getWorkloadHealth ( context . Background ( ) , suite . runtime , resourceID ( fakeType , "foo" ) )
suite . controllerSuite . runTestCaseWithTenancies ( func ( tenancy * pbresource . Tenancy ) {
health , err := getWorkloadHealth ( context . Background ( ) , suite . runtime , resourceID ( fakeType , "foo" , tenancy ) )
require . Error ( suite . T ( ) , err )
require . Equal ( suite . T ( ) , codes . InvalidArgument , status . Code ( err ) )
require . Equal ( suite . T ( ) , pbcatalog . Health_HEALTH_CRITICAL , health )
} )
}
func ( suite * getWorkloadHealthTestSuite ) TestNoHealthStatuses ( ) {
// This test's goal is to ensure that when no HealthStatuses are owned by the
// workload that the health is assumed to be passing.
suite . controllerSuite . runTestCaseWithTenancies ( func ( tenancy * pbresource . Tenancy ) {
workload := resourcetest . Resource ( pbcatalog . WorkloadType , "foo" ) .
WithData ( suite . T ( ) , workloadData ( "" ) ) .
WithTenancy ( tenancy ) .
Write ( suite . T ( ) , suite . client )
health , err := getWorkloadHealth ( context . Background ( ) , suite . runtime , workload . Id )
require . NoError ( suite . T ( ) , err )
require . Equal ( suite . T ( ) , pbcatalog . Health_HEALTH_PASSING , health )
} )
}
func ( suite * getWorkloadHealthTestSuite ) TestWithStatuses ( ) {
@ -626,6 +676,7 @@ func (suite *getWorkloadHealthTestSuite) TestWithStatuses() {
// helper method is used to inject multiple statuses in a way such that
// the resource service will return them in a predictable order and can
// properly exercise the code.
suite . controllerSuite . runTestCaseWithTenancies ( func ( tenancy * pbresource . Tenancy ) {
for value , status := range pbcatalog . Health_name {
health := pbcatalog . Health ( value )
if health == pbcatalog . Health_HEALTH_ANY {
@ -635,15 +686,17 @@ func (suite *getWorkloadHealthTestSuite) TestWithStatuses() {
suite . Run ( status , func ( ) {
workload := resourcetest . Resource ( pbcatalog . WorkloadType , "foo" ) .
WithData ( suite . T ( ) , workloadData ( "" ) ) .
WithTenancy ( tenancy ) .
Write ( suite . T ( ) , suite . client )
suite . addHealthStatuses ( workload . Id , health )
suite . addHealthStatuses ( workload . Id , tenancy , health )
actualHealth , err := getWorkloadHealth ( context . Background ( ) , suite . runtime , workload . Id )
require . NoError ( suite . T ( ) , err )
require . Equal ( suite . T ( ) , health , actualHealth )
} )
}
} )
}
func TestGetWorkloadHealth ( t * testing . T ) {
@ -659,27 +712,32 @@ func (suite *getNodeHealthTestSuite) TestNotfound() {
// present in the system results in a the critical health but no error. This situation
// could occur when a linked node gets removed without the workloads being modified/removed.
// When that occurs we want to steer traffic away from the linked node as soon as possible.
health , err := getNodeHealth ( context . Background ( ) , suite . runtime , resourceID ( pbcatalog . NodeType , "not-found" ) )
suite . controllerSuite . runTestCaseWithTenancies ( func ( tenancy * pbresource . Tenancy ) {
health , err := getNodeHealth ( context . Background ( ) , suite . runtime , resourceID ( pbcatalog . NodeType , "not-found" , tenancy ) )
require . NoError ( suite . T ( ) , err )
require . Equal ( suite . T ( ) , pbcatalog . Health_HEALTH_CRITICAL , health )
} )
}
func ( suite * getNodeHealthTestSuite ) TestReadError ( ) {
// This test's goal is to ensure the getNodeHealth propagates unexpected errors from
// its resource read call back to the caller.
health , err := getNodeHealth ( context . Background ( ) , suite . runtime , resourceID ( fakeType , "not-found" ) )
suite . controllerSuite . runTestCaseWithTenancies ( func ( tenancy * pbresource . Tenancy ) {
health , err := getNodeHealth ( context . Background ( ) , suite . runtime , resourceID ( fakeType , "not-found" , tenancy ) )
require . Error ( suite . T ( ) , err )
require . Equal ( suite . T ( ) , codes . InvalidArgument , status . Code ( err ) )
require . Equal ( suite . T ( ) , pbcatalog . Health_HEALTH_CRITICAL , health )
} )
}
func ( suite * getNodeHealthTestSuite ) TestUnreconciled ( ) {
// This test's goal is to ensure that nodes with unreconciled health are deemed
// critical. Basically, the workload health controller should defer calculating
// the workload health until the associated nodes health is known.
suite . controllerSuite . runTestCaseWithTenancies ( func ( tenancy * pbresource . Tenancy ) {
node := resourcetest . Resource ( pbcatalog . NodeType , "unreconciled" ) .
WithData ( suite . T ( ) , nodeData ) .
WithTenancy ( tenancy ) .
Write ( suite . T ( ) , suite . client ) .
GetId ( )
@ -687,17 +745,20 @@ func (suite *getNodeHealthTestSuite) TestUnreconciled() {
require . Error ( suite . T ( ) , err )
require . Equal ( suite . T ( ) , errNodeUnreconciled , err )
require . Equal ( suite . T ( ) , pbcatalog . Health_HEALTH_CRITICAL , health )
} )
}
func ( suite * getNodeHealthTestSuite ) TestNoConditions ( ) {
// This test's goal is to ensure that if a node's health status doesn't have
// the expected condition then its deemed d critical. This should never happen
// the expected condition then its deemed critical. This should never happen
// in the integrated system as the node health controller would have to be
// buggy to add an empty status. However it could also indicate some breaking
// change went in. Regardless, the code to handle this state is written
// and it will be tested here.
suite . controllerSuite . runTestCaseWithTenancies ( func ( tenancy * pbresource . Tenancy ) {
node := resourcetest . Resource ( pbcatalog . NodeType , "no-conditions" ) .
WithData ( suite . T ( ) , nodeData ) .
WithTenancy ( tenancy ) .
WithStatus ( nodehealth . StatusKey , & pbresource . Status { } ) .
Write ( suite . T ( ) , suite . client ) .
GetId ( )
@ -706,6 +767,7 @@ func (suite *getNodeHealthTestSuite) TestNoConditions() {
require . Error ( suite . T ( ) , err )
require . Equal ( suite . T ( ) , errNodeHealthConditionNotFound , err )
require . Equal ( suite . T ( ) , pbcatalog . Health_HEALTH_CRITICAL , health )
} )
}
func ( suite * getNodeHealthTestSuite ) TestInvalidReason ( ) {
@ -716,8 +778,10 @@ func (suite *getNodeHealthTestSuite) TestInvalidReason() {
// controller to put it into this state. As users or other controllers could
// potentially force it into this state by writing the status themselves, it
// would be good to ensure the defined behavior works as expected.
suite . controllerSuite . runTestCaseWithTenancies ( func ( tenancy * pbresource . Tenancy ) {
node := resourcetest . Resource ( pbcatalog . NodeType , "invalid-reason" ) .
WithData ( suite . T ( ) , nodeData ) .
WithTenancy ( tenancy ) .
WithStatus ( nodehealth . StatusKey , & pbresource . Status {
Conditions : [ ] * pbresource . Condition {
{
@ -734,11 +798,13 @@ func (suite *getNodeHealthTestSuite) TestInvalidReason() {
require . Error ( suite . T ( ) , err )
require . Equal ( suite . T ( ) , errNodeHealthInvalid , err )
require . Equal ( suite . T ( ) , pbcatalog . Health_HEALTH_CRITICAL , health )
} )
}
func ( suite * getNodeHealthTestSuite ) TestValidHealth ( ) {
// This test aims to ensure that all status that would be reported by the node-health
// controller gets accurately detected and returned by the getNodeHealth function.
suite . controllerSuite . runTestCaseWithTenancies ( func ( tenancy * pbresource . Tenancy ) {
for value , healthStr := range pbcatalog . Health_name {
health := pbcatalog . Health ( value )
@ -749,15 +815,28 @@ func (suite *getNodeHealthTestSuite) TestValidHealth() {
}
suite . T ( ) . Run ( healthStr , func ( t * testing . T ) {
node := suite . injectNodeWithStatus ( "test-node" , health )
node := suite . injectNodeWithStatus ( "test-node" , health , tenancy )
actualHealth , err := getNodeHealth ( context . Background ( ) , suite . runtime , node . Id )
require . NoError ( t , err )
require . Equal ( t , health , actualHealth )
} )
}
} )
}
func TestGetNodeHealth ( t * testing . T ) {
suite . Run ( t , new ( getNodeHealthTestSuite ) )
}
func ( suite * controllerSuite ) runTestCaseWithTenancies ( testFunc func ( * pbresource . Tenancy ) ) {
for _ , tenancy := range suite . tenancies {
suite . Run ( suite . appendTenancyInfo ( tenancy ) , func ( ) {
testFunc ( tenancy )
} )
}
}
func ( suite * controllerSuite ) appendTenancyInfo ( tenancy * pbresource . Tenancy ) string {
return fmt . Sprintf ( "%s_Namespace_%s_Partition" , tenancy . Namespace , tenancy . Partition )
}