github
/
apprise
mirror of https://github.com/caronc/apprise
1
0
Fork 0
Code Issues Releases Wiki Activity

more test coverage

pull/1354/head
Chris Caron 2025-06-29 21:15:47 -04:00
parent c9abd69299
commit 357621c2c8
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
apprise/plugins/smpp.py
View File

@ -140,6 +140,12 @@ class NotifySMPP(NotifyBase):
super().__init__(**kwargs) super().__init__(**kwargs)
self.source = None self.source = None
if not (self.user and self.password):
msg = 'No SMPP user/pass combination was provided'
self.logger.warning(msg)
raise TypeError(msg)
result = is_phone_no(source) result = is_phone_no(source)
if not result: if not result:
msg = 'The Account (From) Phone # specified ' \ msg = 'The Account (From) Phone # specified ' \
@ -147,11 +153,6 @@ class NotifySMPP(NotifyBase):
self.logger.warning(msg) self.logger.warning(msg)
raise TypeError(msg) raise TypeError(msg)
if not (self.user and self.password):
msg = 'No SMPP user/pass combination was provided'
self.logger.warning(msg)
raise TypeError(msg)
# Tidy source # Tidy source
self.source = result['full'] self.source = result['full']