From 357621c2c896c399597d3423b3acba9c88ccb3cb Mon Sep 17 00:00:00 2001 From: Chris Caron Date: Sun, 29 Jun 2025 21:15:47 -0400 Subject: [PATCH] more test coverage --- apprise/plugins/smpp.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/apprise/plugins/smpp.py b/apprise/plugins/smpp.py index 13db2600..19ff6ff1 100644 --- a/apprise/plugins/smpp.py +++ b/apprise/plugins/smpp.py @@ -140,6 +140,12 @@ class NotifySMPP(NotifyBase): super().__init__(**kwargs) self.source = None + + if not (self.user and self.password): + msg = 'No SMPP user/pass combination was provided' + self.logger.warning(msg) + raise TypeError(msg) + result = is_phone_no(source) if not result: msg = 'The Account (From) Phone # specified ' \ @@ -147,11 +153,6 @@ class NotifySMPP(NotifyBase): self.logger.warning(msg) raise TypeError(msg) - if not (self.user and self.password): - msg = 'No SMPP user/pass combination was provided' - self.logger.warning(msg) - raise TypeError(msg) - # Tidy source self.source = result['full']