mirrors/winsw
1
0
Fork 0
mirror of https://github.com/winsw/winsw.git synced 2025-12-10 18:37:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix service crashes

Browse Source
This commit is contained in:
NextTurn
2020-08-10 00:00:00 +08:00
committed by Next Turn
parent e97bc5bc72
commit 1f188cf20b
4 changed files with 43 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/WinSW.Core/Util/ProcessExtensions.cs
View File

@@ -193,20 +193,28 @@ namespace WinSW.Util
if (!AttachConsole(process.Id))
{
int error = Marshal.GetLastWin32Error();
Log.Debug("Failed to attach to console. " + error switch
switch (error)
{
Errors.ERROR_ACCESS_DENIED => "WinSW is already attached to a console.", // TODO: test mode
Errors.ERROR_INVALID_HANDLE => "The process does not have a console.",
Errors.ERROR_INVALID_PARAMETER => "The process has exited.",
_ => new Win32Exception(error).Message // unreachable
});
// The process does not have a console.
case Errors.ERROR_INVALID_HANDLE:
return false;
return error == Errors.ERROR_INVALID_PARAMETER ? (bool?)null : false;
// The process has exited.
case Errors.ERROR_INVALID_PARAMETER:
return null;
// The calling process is already attached to a console.
case Errors.ERROR_ACCESS_DENIED:
default:
Log.Warn("Failed to attach to console. " + new Win32Exception(error).Message);
return false;
}
}
_ = SetConsoleCtrlHandler(null, true);
// Don't call GenerateConsoleCtrlEvent immediately after SetConsoleCtrlHandler.
// A delay was observed as of Windows 10, version 2004 and Windows Server 2019.
_ = GenerateConsoleCtrlEvent(CtrlEvents.CTRL_C_EVENT, 0);
_ = SetConsoleCtrlHandler(null, false);
bool succeeded = FreeConsole();
Debug.Assert(succeeded);