mirrors/portainer
1
0
Fork 0
mirror of https://github.com/portainer/portainer.git synced 2025-11-26 14:06:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore(linters): enable testifylint BE-12183 (#1091)

Browse Source
This commit is contained in:
andres-portainer
2025-08-22 15:31:10 -03:00
committed by GitHub
parent 121e9f03a4
commit ec0e98a64b
97 changed files with 987 additions and 891 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
api/stacks/deployments/deploy_test.go
View File

@@ -156,7 +156,7 @@ func Test_redeployWhenChanged_FailsWhenCannotFindStack(t *testing.T) {
_, store := datastore.MustNewTestStore(t, true, true)
err := RedeployWhenChanged(1, nil, store, nil)
assert.Error(t, err)
require.Error(t, err)
assert.Truef(t, strings.HasPrefix(err.Error(), "failed to get the stack"), "it isn't an error we expected: %v", err.Error())
}
@@ -165,13 +165,13 @@ func Test_redeployWhenChanged_DoesNothingWhenNotAGitBasedStack(t *testing.T) {
admin := &portainer.User{ID: 1, Username: "admin"}
err := store.User().Create(admin)
assert.NoError(t, err, "error creating an admin")
require.NoError(t, err, "error creating an admin")
err = store.Stack().Create(&portainer.Stack{ID: 1, CreatedBy: "admin"})
assert.NoError(t, err, "failed to create a test stack")
require.NoError(t, err, "failed to create a test stack")
err = RedeployWhenChanged(1, nil, store, testhelpers.NewGitService(nil, ""))
assert.NoError(t, err)
require.NoError(t, err)
}
func Test_redeployWhenChanged_DoesNothingWhenNoGitChanges(t *testing.T) {
@@ -181,12 +181,12 @@ func Test_redeployWhenChanged_DoesNothingWhenNoGitChanges(t *testing.T) {
admin := &portainer.User{ID: 1, Username: "admin"}
err := store.User().Create(admin)
assert.NoError(t, err, "error creating an admin")
require.NoError(t, err, "error creating an admin")
err = store.Endpoint().Create(&portainer.Endpoint{
ID: 0,
})
assert.NoError(t, err, "error creating environment")
require.NoError(t, err, "error creating environment")
err = store.Stack().Create(&portainer.Stack{
ID: 1,
@@ -197,10 +197,10 @@ func Test_redeployWhenChanged_DoesNothingWhenNoGitChanges(t *testing.T) {
ReferenceName: "ref",
ConfigHash: "oldHash",
}})
assert.NoError(t, err, "failed to create a test stack")
require.NoError(t, err, "failed to create a test stack")
err = RedeployWhenChanged(1, nil, store, testhelpers.NewGitService(nil, "oldHash"))
assert.NoError(t, err)
require.NoError(t, err)
}
func Test_redeployWhenChanged_FailsWhenCannotClone(t *testing.T) {
@@ -211,7 +211,7 @@ func Test_redeployWhenChanged_FailsWhenCannotClone(t *testing.T) {
admin := &portainer.User{ID: 1, Username: "admin"}
err := store.User().Create(admin)
assert.NoError(t, err, "error creating an admin")
require.NoError(t, err, "error creating an admin")
err = store.Endpoint().Create(&portainer.Endpoint{
ID: 0,
@@ -221,7 +221,7 @@ func Test_redeployWhenChanged_FailsWhenCannotClone(t *testing.T) {
TLSSkipVerify: true,
},
})
assert.NoError(t, err, "error creating environment")
require.NoError(t, err, "error creating environment")
err = store.Stack().Create(&portainer.Stack{
ID: 1,
@@ -231,11 +231,11 @@ func Test_redeployWhenChanged_FailsWhenCannotClone(t *testing.T) {
ReferenceName: "ref",
ConfigHash: "oldHash",
}})
assert.NoError(t, err, "failed to create a test stack")
require.NoError(t, err, "failed to create a test stack")
err = RedeployWhenChanged(1, nil, store, testhelpers.NewGitService(cloneErr, "newHash"))
assert.Error(t, err)
assert.ErrorIs(t, err, cloneErr, "should failed to clone but didn't, check test setup")
require.Error(t, err)
require.ErrorIs(t, err, cloneErr, "should failed to clone but didn't, check test setup")
}
func Test_redeployWhenChanged(t *testing.T) {
@@ -244,11 +244,11 @@ func Test_redeployWhenChanged(t *testing.T) {
tmpDir := t.TempDir()
err := store.Endpoint().Create(&portainer.Endpoint{ID: 1})
assert.NoError(t, err, "error creating environment")
require.NoError(t, err, "error creating environment")
username := "user"
err = store.User().Create(&portainer.User{Username: username, Role: portainer.AdministratorRole})
assert.NoError(t, err, "error creating a user")
require.NoError(t, err, "error creating a user")
stack := portainer.Stack{
ID: 1,
@@ -263,14 +263,14 @@ func Test_redeployWhenChanged(t *testing.T) {
}
err = store.Stack().Create(&stack)
assert.NoError(t, err, "failed to create a test stack")
require.NoError(t, err, "failed to create a test stack")
t.Run("can deploy docker compose stack", func(t *testing.T) {
stack.Type = portainer.DockerComposeStack
store.Stack().Update(stack.ID, &stack)
err = RedeployWhenChanged(1, noopDeployer{}, store, testhelpers.NewGitService(nil, "newHash"))
assert.NoError(t, err)
require.NoError(t, err)
})
t.Run("can deploy docker swarm stack", func(t *testing.T) {
@@ -278,7 +278,7 @@ func Test_redeployWhenChanged(t *testing.T) {
store.Stack().Update(stack.ID, &stack)
err = RedeployWhenChanged(1, noopDeployer{}, store, testhelpers.NewGitService(nil, "newHash"))
assert.NoError(t, err)
require.NoError(t, err)
})
t.Run("can deploy kube app", func(t *testing.T) {
@@ -286,7 +286,7 @@ func Test_redeployWhenChanged(t *testing.T) {
store.Stack().Update(stack.ID, &stack)
err = RedeployWhenChanged(1, noopDeployer{}, store, testhelpers.NewGitService(nil, "newHash"))
assert.NoError(t, err)
require.NoError(t, err)
})
}
@@ -297,11 +297,11 @@ func Test_getUserRegistries(t *testing.T) {
admin := &portainer.User{ID: 1, Username: "admin", Role: portainer.AdministratorRole}
err := store.User().Create(admin)
assert.NoError(t, err, "error creating an admin")
require.NoError(t, err, "error creating an admin")
user := &portainer.User{ID: 2, Username: "user", Role: portainer.StandardUserRole}
err = store.User().Create(user)
assert.NoError(t, err, "error creating a user")
require.NoError(t, err, "error creating a user")
team := portainer.Team{ID: 1, Name: "team"}
@@ -324,7 +324,7 @@ func Test_getUserRegistries(t *testing.T) {
},
}
err = store.Registry().Create(&registryReachableByUser)
assert.NoError(t, err, "couldn't create a registry")
require.NoError(t, err, "couldn't create a registry")
registryReachableByTeam := portainer.Registry{
ID: 2,
@@ -338,7 +338,7 @@ func Test_getUserRegistries(t *testing.T) {
},
}
err = store.Registry().Create(&registryReachableByTeam)
assert.NoError(t, err, "couldn't create a registry")
require.NoError(t, err, "couldn't create a registry")
registryRestricted := portainer.Registry{
ID: 3,
@@ -352,17 +352,17 @@ func Test_getUserRegistries(t *testing.T) {
},
}
err = store.Registry().Create(&registryRestricted)
assert.NoError(t, err, "couldn't create a registry")
require.NoError(t, err, "couldn't create a registry")
t.Run("admin should has access to all registries", func(t *testing.T) {
registries, err := getUserRegistries(store, admin, portainer.EndpointID(endpointID))
assert.NoError(t, err)
require.NoError(t, err)
assert.ElementsMatch(t, []portainer.Registry{registryReachableByUser, registryReachableByTeam, registryRestricted}, registries)
})
t.Run("regular user has access to registries allowed to him and/or his team", func(t *testing.T) {
registries, err := getUserRegistries(store, user, portainer.EndpointID(endpointID))
assert.NoError(t, err)
require.NoError(t, err)
assert.ElementsMatch(t, []portainer.Registry{registryReachableByUser, registryReachableByTeam}, registries)
})
}