fix(adminmonitor): fix a data race in a unit test EE-2714 (#6627)

api/adminmonitor/admin_monitor_test.go

@@ -35,9 +35,15 @@ func Test_start_shouldFatalAfterTimeout_ifNotInitialized(t *testing.T) {
 
 	datastore := i.NewDatastore(i.WithUsers([]portainer.User{}))
 
+	ch := make(chan struct{})
 	var fataled bool
 	origLogFatalf := logFatalf
-	logFatalf = func(s string, v ...interface{}) { fataled = true }
+
+	logFatalf = func(s string, v ...interface{}) {
+		fataled = true
+		close(ch)
+	}
+
 	defer func() {
 		logFatalf = origLogFatalf
 	}()
@@ -45,6 +51,7 @@ func Test_start_shouldFatalAfterTimeout_ifNotInitialized(t *testing.T) {
 	monitor := New(timeout, datastore, context.Background())
 	monitor.Start()
 	<-time.After(2 * timeout)
+	<-ch
 
 	assert.True(t, fataled, "monitor should been timeout and fatal")
 }