mirrors/aria2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Accept HTTP 304 reply as success when If-None-Match request-header

Browse Source 
field is specified using --header option.

When --conditional-get is used, --allow-overwrite is now required to
overwrite existing file.
This commit is contained in:
Tatsuhiro Tsujikawa
2011-01-29 23:19:10 +09:00
parent 7a6ec762ef
commit 1b9329c67c
5 changed files with 62 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
test/HttpRequestTest.cc
View File

@@ -37,6 +37,7 @@ class HttpRequestTest : public CppUnit::TestFixture {
CPPUNIT_TEST(testAddHeader);
CPPUNIT_TEST(testAddAcceptType);
CPPUNIT_TEST(testEnableAcceptEncoding);
CPPUNIT_TEST(testConditionalRequest);
CPPUNIT_TEST_SUITE_END();
private:
SharedHandle<Option> option_;
@@ -64,6 +65,7 @@ public:
void testAddHeader();
void testAddAcceptType();
void testEnableAcceptEncoding();
void testConditionalRequest();
};
@@ -843,4 +845,19 @@ void HttpRequestTest::testCreateRequest_ipv6LiteralAddr()
CPPUNIT_ASSERT(proxyRequest.find("CONNECT [::1]:80 ") != std::string::npos);
}
void HttpRequestTest::testConditionalRequest()
{
HttpRequest httpRequest;
CPPUNIT_ASSERT(!httpRequest.conditionalRequest());
httpRequest.setIfModifiedSinceHeader("dummy");
CPPUNIT_ASSERT(httpRequest.conditionalRequest());
httpRequest.setIfModifiedSinceHeader("");
CPPUNIT_ASSERT(!httpRequest.conditionalRequest());
httpRequest.addHeader("If-None-Match: *");
CPPUNIT_ASSERT(httpRequest.conditionalRequest());
httpRequest.clearHeader();
httpRequest.addHeader("If-Modified-Since: dummy");
CPPUNIT_ASSERT(httpRequest.conditionalRequest());
}
} // namespace aria2