Fullpath bulletproofing on XML, JSON, and FORM plugins (#519)

test/test_plugin_custom_json.py

@@ -22,6 +22,8 @@
 # LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 # THE SOFTWARE.
+import json
+import mock
 import requests
 from apprise import plugins
 from helpers import AppriseURLTester
@@ -130,3 +132,63 @@ def test_plugin_custom_json_urls():
 
     # Run our general tests
     AppriseURLTester(tests=apprise_url_tests).run_all()
+
+
+@mock.patch('requests.post')
+@mock.patch('requests.get')
+def test_plugin_custom_json_edge_cases(mock_get, mock_post):
+    """
+    NotifyJSON() Edge Cases
+
+    """
+    # Disable Throttling to speed testing
+    plugins.NotifyBase.request_rate_per_sec = 0
+
+    # Prepare our response
+    response = requests.Request()
+    response.status_code = requests.codes.ok
+
+    # Prepare Mock
+    mock_post.return_value = response
+    mock_get.return_value = response
+
+    results = plugins.NotifyJSON.parse_url(
+        'json://localhost:8080/command?:message=test&method=GET')
+
+    assert isinstance(results, dict)
+    assert results['user'] is None
+    assert results['password'] is None
+    assert results['port'] == 8080
+    assert results['host'] == 'localhost'
+    assert results['fullpath'] == '/command'
+    assert results['path'] == '/'
+    assert results['query'] == 'command'
+    assert results['schema'] == 'json'
+    assert results['url'] == 'json://localhost:8080/command'
+    assert isinstance(results['qsd:'], dict) is True
+    assert results['qsd:']['message'] == 'test'
+
+    instance = plugins.NotifyJSON(**results)
+    assert isinstance(instance, plugins.NotifyJSON)
+
+    response = instance.send(title='title', body='body')
+    assert response is True
+    assert mock_post.call_count == 0
+    assert mock_get.call_count == 1
+
+    details = mock_get.call_args_list[0]
+    assert details[0][0] == 'http://localhost:8080/command'
+    assert 'title' in details[1]['data']
+    dataset = json.loads(details[1]['data'])
+    assert dataset['title'] == 'title'
+    assert 'message' in dataset
+    assert dataset['message'] == 'body'
+
+    assert instance.url(privacy=False).startswith(
+        'json://localhost:8080/command?')
+
+    # Generate a new URL based on our last and verify key values are the same
+    new_results = plugins.NotifyJSON.parse_url(instance.url(safe=False))
+    for k in ('user', 'password', 'port', 'host', 'fullpath', 'path', 'query',
+              'schema', 'url', 'method'):
+        assert new_results[k] == results[k]