mirrors/acme4j
1
0
Fork 0
mirror of https://github.com/shred/acme4j.git synced 2025-12-16 11:24:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

Control gzip compression via system property

Browse Source
This commit is contained in:
Richard Körber
2023-08-11 09:45:38 +02:00
parent b7d17f3fba
commit af9f236f90
3 changed files with 46 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
acme4j-client/src/main/java/org/shredzone/acme4j/connector/NetworkSettings.java
View File

@@ -17,8 +17,10 @@ import java.net.Authenticator;
import java.net.ProxySelector;
import java.net.http.HttpClient;
import java.time.Duration;
import java.util.Optional;
import edu.umd.cs.findbugs.annotations.Nullable;
import org.slf4j.LoggerFactory;
/**
* Contains network settings to be used for network connections.
@@ -27,11 +29,28 @@ import edu.umd.cs.findbugs.annotations.Nullable;
*/
public class NetworkSettings {
/**
* Name of the system property to control GZIP compression. Expects a boolean value.
*/
public static final String GZIP_PROPERTY_NAME = "org.shredzone.acme4j.gzip_compression";
private ProxySelector proxySelector = HttpClient.Builder.NO_PROXY;
private Duration timeout = Duration.ofSeconds(10);
private @Nullable Authenticator authenticator = null;
private boolean compression = true;
public NetworkSettings() {
try {
Optional.ofNullable(System.getProperty(GZIP_PROPERTY_NAME))
.map(Boolean::parseBoolean)
.ifPresent(val -> compression = val);
} catch (Exception ex) {
// Ignore a broken property name or a SecurityException
LoggerFactory.getLogger(NetworkSettings.class)
.warn("Could not read system property: {}", GZIP_PROPERTY_NAME, ex);
}
}
/**
* Gets the {@link ProxySelector} to be used for connections.
*
@@ -104,6 +123,9 @@ public class NetworkSettings {
/**
* Sets if HTTP compression is enabled. It is enabled by default, but can be
* disabled e.g. for debugging purposes.
* <p>
* acme4j gzip compression can also be controlled via the {@value #GZIP_PROPERTY_NAME}
* system property.
*
* @since 3.0.0
*/

23
acme4j-client/src/test/java/org/shredzone/acme4j/connector/NetworkSettingsTest.java
View File

@@ -74,4 +74,27 @@ public class NetworkSettingsTest {
"timeout accepted negative duration");
}
@Test
public void testSystemProperty() {
assertThat(NetworkSettings.GZIP_PROPERTY_NAME)
.startsWith("org.shredzone.acme4j")
.contains("gzip");
System.clearProperty(NetworkSettings.GZIP_PROPERTY_NAME);
var settingsNone = new NetworkSettings();
assertThat(settingsNone.isCompressionEnabled()).isTrue();
System.setProperty(NetworkSettings.GZIP_PROPERTY_NAME, "true");
var settingsTrue = new NetworkSettings();
assertThat(settingsTrue.isCompressionEnabled()).isTrue();
System.setProperty(NetworkSettings.GZIP_PROPERTY_NAME, "false");
var settingsFalse = new NetworkSettings();
assertThat(settingsFalse.isCompressionEnabled()).isFalse();
System.setProperty(NetworkSettings.GZIP_PROPERTY_NAME, "1234");
var settingsNonBoolean = new NetworkSettings();
assertThat(settingsNonBoolean.isCompressionEnabled()).isFalse();
}
}