mirrors/acme4j
1
0
Fork 0
mirror of https://github.com/shred/acme4j.git synced 2025-12-13 11:14:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use assertThrows instead of try/fail constructs

Browse Source
This commit is contained in:
Richard Körber
2022-05-07 11:25:59 +02:00
parent cf0bfc1390
commit 00ee9e4dd5
20 changed files with 256 additions and 544 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
acme4j-smime/src/test/java/org/shredzone/acme4j/smime/csr/SMIMECSRBuilderTest.java
View File

@@ -16,6 +16,7 @@ package org.shredzone.acme4j.smime.csr;
import static java.nio.charset.StandardCharsets.UTF_8;
import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.is;
import static org.junit.Assert.assertThrows;
import java.io.ByteArrayOutputStream;
import java.io.IOException;
@@ -253,26 +254,13 @@ public class SMIMECSRBuilderTest {
public void testNoSign() throws IOException {
SMIMECSRBuilder builder = new SMIMECSRBuilder();
try {
builder.getCSR();
Assert.fail("getCSR(): expected exception was not thrown");
} catch (IllegalStateException ex) {
// expected
}
try {
builder.getEncoded();
Assert.fail("getEncoded(): expected exception was not thrown");
} catch (IllegalStateException ex) {
// expected
}
try (StringWriter w = new StringWriter()) {
builder.write(w);
Assert.fail("write(): expected exception was not thrown");
} catch (IllegalStateException ex) {
// expected
}
assertThrows("getCSR", IllegalStateException.class, builder::getCSR);
assertThrows("getEncoded", IllegalStateException.class, builder::getEncoded);
assertThrows("write", IllegalStateException.class,() -> {
try (StringWriter w = new StringWriter()) {
builder.write(w);
}
});
}
/**