mirror of https://github.com/huashengdun/webssh
Browse Source
The worker ID right now is typically based off the address of an object in memory. This could be guessed. While the worker is tied to a specific IP, there is a chance an off-path attacker could be hosted behind the same IP as the caller. They could possibly guess the worker id of an unclaimed session by observing the sequence of IDs presented to themselves, leading to them gaining access to an already authenticated SSH session. Use the python secrets module to generate a cryptographically secure token to use as the worker ID. This shoud be much harder to guess.pull/305/head
Kyle Larose
2 years ago
1 changed files with 6 additions and 1 deletions
Loading…
Reference in new issue