fix: Uncaught exception in promises, and remove log consoles. (#267)

pull/3759/head
EdwinBetanc0urt 2020-01-27 12:59:33 -04:00 committed by Yamel Senih
parent b9cc5ff276
commit 6e89373f51
18 changed files with 45 additions and 54 deletions

View File

@ -45,7 +45,7 @@
},
"dependencies": {
"@adempiere/grpc-access-client": "^1.1.8",
"@adempiere/grpc-data-client": "^1.9.2",
"@adempiere/grpc-data-client": "^1.9.8",
"@adempiere/grpc-dictionary-client": "^1.3.5",
"@adempiere/grpc-enrollment-client": "^1.0.7",
"autoprefixer": "^9.5.1",

View File

@ -267,7 +267,7 @@ export function runCallOutRequest({ windowUuid, windowNo, tabUuid, tableName, co
}
export function getDefaultValueFromServer(query) {
return Instance.call(this).getDefaultValue(query)
return Instance.call(this).requestGetDefaultValue(query)
}
export function getContextInfoValueFromServer({ uuid, query }) {

View File

@ -57,7 +57,7 @@ export default {
getPendingDocuments() {
const userUuid = this.$store.getters['user/getUserUuid']
const roleUuid = this.$store.getters.getRoleUuid
return new Promise((resolve, reject) => {
return new Promise(resolve => {
getPendingDocumentsFromServer({ userUuid, roleUuid })
.then(response => {
const documentsList = response.pendingDocumentsList.map(documentItem => {

View File

@ -58,7 +58,7 @@ export default {
methods: {
getFavoritesList() {
const userUuid = this.$store.getters['user/getUserUuid']
return new Promise((resolve, reject) => {
return new Promise(resolve => {
getFavoritesFromServer({ userUuid })
.then(response => {
const favorites = response.favoritesList.map(favoriteElement => {

View File

@ -10,7 +10,9 @@
class="custom-collapse-item"
>
<template slot="title">
<span class="custom-title"> {{ dashboard.dashboardName }}</span>
<span class="custom-title">
{{ dashboard.dashboardName }}
</span>
</template>
<component
:is="renderDashboard"

View File

@ -64,7 +64,7 @@ export default {
return this.cachedViews.includes(uuid)
},
getRecentItems({ pageToken, pageSize }) {
return new Promise((resolve, reject) => {
return new Promise(resolve => {
getRecentItemsFromServer({ pageToken, pageSize })
.then(response => {
const recentItems = response.recentItemsList.map(item => {

View File

@ -115,7 +115,6 @@ export default {
},
'metadata.displayColumn'(value) {
if (!this.isEmptyValue(this.value)) {
// console.log('display wacth')
if (!this.isEmptyValue(value)) {
// verify if exists to add
if (!this.findLabel(this.value)) {

View File

@ -273,12 +273,12 @@ export default {
notes: 'Notes',
changeLog: 'Change Log',
workflowLog: 'Workflow Log',
changeDetail: 'Detalle del cambio',
changeDetail: 'Change Detail',
eventType: {
insert: 'Insert',
update: 'Update',
delete: 'Delete',
field: 'The Fiel',
field: 'The Field',
newValue: 'New Value',
oldValue: 'Old Value'
}

View File

@ -23,7 +23,7 @@ const browser = {
containerUuid,
routeToDelete
}) {
return new Promise((resolve, reject) => {
return new Promise(resolve => {
getBrowserMetadata(containerUuid)
.then(browserResponse => {
const panelType = 'browser'
@ -142,8 +142,7 @@ const browser = {
message: language.t('login.unexpectedError'),
type: 'error'
})
console.warn(`Dictionary Browser - Error ${error.code}: ${error.message}`)
reject(error)
console.warn(`Dictionary Browser - Error ${error.code}: ${error.message}.`)
})
})
},

View File

@ -26,9 +26,9 @@ const containerInfo = {
listWorkflowLogs({ commit, state }, params) {
const tableName = params.tableName
const recordId = params.recordId
const page_size = 0
const page_token = 0
return requestListWorkflowsLogs({ tableName, recordId, page_size, page_token })
const pageSize = 0
const pageToken = 0
return requestListWorkflowsLogs({ tableName, recordId, pageSize, pageToken })
.then(response => {
commit('addListWorkflow', response)
})
@ -39,9 +39,9 @@ const containerInfo = {
listRecordLogs({ commit, state }, params) {
const tableName = params.tableName
const recordId = params.recordId
const page_size = 0
const page_token = 0
return requestListRecordsLogs({ tableName, recordId, page_size, page_token })
const pageSize = 0
const pageToken = 0
return requestListRecordsLogs({ tableName, recordId, pageSize, pageToken })
.then(response => {
var listRecord = {
recordCount: response.recordCount,
@ -53,27 +53,25 @@ const containerInfo = {
console.warn(`Error getting List Record Logs: ${error.message}. Code: ${error.code}.`)
})
},
listChatEntries({ commit, state }, params) {
listChatEntries({ commit }, params) {
const tableName = params.tableName
const recordId = params.recordId
const page_size = 0
const page_token = 0
return requestListRecordChats({ tableName, recordId, page_size, page_token })
const pageSize = 0
const pageToken = 0
return requestListRecordChats({ tableName, recordId, pageSize, pageToken })
.then(response => {
console.log('requestListRecordChats response =>', response)
commit('addListChatEntries', response)
})
.catch(error => {
console.warn(`Error getting List Chat: ${error.message}. Code: ${error.code}.`)
})
},
listRecordChat({ commit, state }, params) {
listRecordChat({ commit }, params) {
const uuid = params.uuid
const page_size = 0
const page_token = 0
return requestListChatEntries({ uuid, page_size, page_token })
const pageSize = 0
const pageToken = 0
return requestListChatEntries({ uuid, pageSize, pageToken })
.then(response => {
console.log('requestListChatEntries response =>', response)
commit('addListChatEntries', response)
})
.catch(error => {
@ -88,7 +86,7 @@ const containerInfo = {
getRecordLogs: (state) => {
const recordLogs = state.listRecordLogs.recorLogs
if (isEmptyValue(recordLogs)) {
var listRecord = [{
const listRecord = [{
columnName: 'Compañía',
description: 'Compañía',
displayColumnName: 'Compañía',
@ -127,9 +125,8 @@ const containerInfo = {
userUuid: ''
}]
return listRecord
} else {
return state.listRecordLogs
}
return state.listRecordLogs
},
getChatEntries: (state) => {
return state.listChatEntries

View File

@ -1,6 +1,8 @@
// Default store for handle dashboard refresh and other functionalities
import { requestLisDashboards, getRecentItems } from '@/api/ADempiere/data'
import { convertAction } from '@/utils/ADempiere/dictionaryUtils'
import { isEmptyValue } from '@/utils/ADempiere/valueUtils'
import { getCurrentRole } from '@/utils/auth'
const dashboard = {
state: {
@ -22,8 +24,13 @@ const dashboard = {
refreshDashboard({ commit }, parameters) {
commit('notifyDashboardRefresh', parameters)
},
listDashboard({ commit }, roleUuid) {
return new Promise((resolve, reject) => {
listDashboard({ commit, rootGetters }, roleUuid) {
if (isEmptyValue(roleUuid)) {
roleUuid = rootGetters.getRoleUuid
} else if (isEmptyValue(roleUuid)) {
roleUuid = getCurrentRole()
}
return new Promise(resolve => {
requestLisDashboards({ roleUuid })
.then(dashboardResponse => {
const roleDashboards = {
@ -34,12 +41,12 @@ const dashboard = {
resolve(roleDashboards)
})
.catch(error => {
reject(error)
console.warn(`Error getting List Dashboards: ${error.message}. Code: ${error.code}.`)
})
})
},
getRecentItemsFromServer({ commit }) {
return new Promise((resolve, reject) => {
return new Promise(resolve => {
getRecentItems({ pageToken: undefined, pageSize: undefined })
.then(recentItemsResponse => {
const recentItems = recentItemsResponse.recentItemsList.map(item => {
@ -55,8 +62,7 @@ const dashboard = {
resolve(recentItems)
})
.catch(error => {
console.warn(`Error gettin recent items: ${error.message}. Code: ${error.code}.`)
reject(error)
console.warn(`Error getting recent items: ${error.message}. Code: ${error.code}.`)
})
})
}

View File

@ -29,14 +29,14 @@ const languageControl = {
},
actions: {
getLanguagesFromServer({ commit }) {
return new Promise((resolve, reject) => {
return new Promise(resolve => {
requestLanguages({ pageToke: undefined, pageSize: undefined })
.then(languageResponse => {
commit('setlanguagesList', languageResponse.languagesList)
resolve(languageResponse.languagesList)
})
.catch(error => {
reject(error)
console.warn(`Error getting Languages List: ${error.message}. Code: ${error.code}.`)
})
})
},

View File

@ -33,7 +33,7 @@ const process = {
.then(response => {
printFormatsAvailable = response
})
return new Promise((resolve, reject) => {
return new Promise(resolve => {
getProcessMetadata(containerUuid)
.then(responseProcess => {
responseProcess.printFormatsAvailable = printFormatsAvailable
@ -61,8 +61,7 @@ const process = {
message: language.t('login.unexpectedError'),
type: 'error'
})
console.warn(`Dictionary Process (State) - Error ${error.message}.`)
reject(error)
console.warn(`Dictionary Process - Error ${error.message}.`)
})
})
},

View File

@ -104,7 +104,7 @@ export function parseContext({
const secondIndexTag = inStr.indexOf('@') // next @
// no exists second tag
if (secondIndexTag < 0) {
console.log(`No second tag: ${inStr}`)
console.info(`No second tag: ${inStr}`)
return {
value: undefined,
isError: true,

View File

@ -163,9 +163,6 @@ export default {
.finally(() => {
this.isLoaded = true
})
.catch(error => {
console.warn('Dictionary Browser - Error ' + error.code + ': ' + error.message)
})
}
},
defaultSearch() {

View File

@ -98,8 +98,6 @@ export default {
routeToDelete: this.$route
}).then(() => {
this.processMetadata = this.getterProcess
}).catch(error => {
console.log('Dictionary Process - Error ' + error.code + ': ' + error.message)
}).finally(() => {
this.isLoadedMetadata = true
})

View File

@ -79,9 +79,6 @@ export default {
},
getLanguageData() {
this.$store.dispatch('getLanguagesFromServer')
.catch(error => {
console.warn(`Error getting language list: ${error.message}. Code: ${error.code}.`)
})
}
}
}

View File

@ -123,9 +123,6 @@ export default {
getLanguageData() {
if (this.isEmptyValue(this.getterLanguageList)) {
this.$store.dispatch('getLanguagesFromServer')
.catch(error => {
console.warn(`Error getting languages list: ${error.message}. Code: ${error.code}.`)
})
}
}
}