Stop parent process first by default

doc/extensions/runawayProcessKiller.md

@@ -36,7 +36,7 @@ The extension can be configured via the [XML configuration file](../xmlConfigFil
       -->
       <stopTimeout>5000</stopTimeout>
       <!-- If true, the parent process will be terminated first if the runaway process gets terminated. -->
-      <stopParentFirst>false</stopParentFirst>
+      <stopParentFirst>true</stopParentFirst>
     </extension>
   </extensions>
 </service>

examples/sample-allOptions.xml

@@ -136,9 +136,9 @@ SECTION: Executable management
   <!--
     OPTION: stopparentprocessfirst
     If set, WinSW will terminate the parent process before stopping the children.
-    Default value: false
+    Default value: true
   -->
-  <stopparentprocessfirst>false</stopparentprocessfirst>
+  <stopparentprocessfirst>true</stopparentprocessfirst>
   
   
   <!-- 

src/Core/WinSWCore/Configuration/DefaultSettings.cs

@@ -50,7 +50,7 @@ namespace WinSW.Configuration
 
         public TimeSpan StopTimeout => TimeSpan.FromSeconds(15);
 
-        public bool StopParentProcessFirst => false;
+        public bool StopParentProcessFirst => true;
 
         // Service management
         public StartMode StartMode => StartMode.Automatic;

src/Plugins/RunawayProcessKiller/RunawayProcessKillerExtension.cs

@@ -49,7 +49,7 @@ namespace WinSW.Plugins.RunawayProcessKiller
         }
 
 #pragma warning disable CS8618 // Non-nullable field is uninitialized. Consider declaring as nullable.
-        public RunawayProcessKillerExtension(string pidfile, int stopTimeoutMs = 5000, bool stopParentFirst = false, bool checkWinSWEnvironmentVariable = true)
+        public RunawayProcessKillerExtension(string pidfile, int stopTimeoutMs = 5000, bool stopParentFirst = true, bool checkWinSWEnvironmentVariable = true)
 #pragma warning restore CS8618 // Non-nullable field is uninitialized. Consider declaring as nullable.
         {
             this.Pidfile = pidfile;

src/Plugins/RunawayProcessKiller/sampleConfig.xml

@@ -15,7 +15,7 @@
       <!-- Defines the process termination timeout in milliseconds. This timeout will be applied multiple times for each child process. -->
       <stopTimeout>5000</stopTimeout>
       <!-- If true, the parent process will be terminated first if the runaway process gets terminated. -->
-      <stopParentFirst>false</stopParentFirst>
+      <stopParentFirst>true</stopParentFirst>
     </extension>
   </extensions>
 </service>

src/Test/winswTests/ServiceDescriptorTests.cs

@@ -140,20 +140,20 @@ $@"<service>
         }
 
         [Test]
-        public void StopParentProcessFirstIsFalseByDefault()
+        public void StopParentProcessFirstIsTrueByDefault()
         {
-            Assert.That(this._extendedServiceDescriptor.StopParentProcessFirst, Is.False);
+            Assert.That(this._extendedServiceDescriptor.StopParentProcessFirst, Is.True);
         }
 
         [Test]
         public void CanParseStopParentProcessFirst()
         {
             const string seedXml = "<service>"
-                                   + "<stopparentprocessfirst>true</stopparentprocessfirst>"
+                                   + "<stopparentprocessfirst>false</stopparentprocessfirst>"
                                    + "</service>";
             var serviceDescriptor = ServiceDescriptor.FromXML(seedXml);
 
-            Assert.That(serviceDescriptor.StopParentProcessFirst, Is.True);
+            Assert.That(serviceDescriptor.StopParentProcessFirst, Is.False);
         }
 
         [Test]