github
/
winsw
mirror of https://github.com/winsw/winsw
1
0
Fork 0
Code Issues Releases Wiki Activity

Better diagnosis in install and uninstall commands 

* install - Fail the installation if the service exists
* uninstall - Print warning if the service does not exist

Resolves #55

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
pull/82/head
Oleg Nenashev 2015-02-01 15:10:00 +03:00
parent f4c11569cb
commit 804691e95f
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
Main.cs
View File

@ -545,6 +545,14 @@ namespace winsw
args[0] = args[0].ToLower(); args[0] = args[0].ToLower();
if (args[0] == "install") if (args[0] == "install")
{ {
// Check if the service exists
if (s != null)
{
Console.WriteLine("Service with id '" + d.Id + "' already exists");
Console.WriteLine("To install the service, delete the existing one or change service Id in the configuration file");
throw new Exception("Installation failure: Service with id '" + d.Id + "' already exists");
}
string username=null, password=null; string username=null, password=null;
bool setallowlogonasaserviceright = false; bool setallowlogonasaserviceright = false;
if (args.Count > 1 && args[1] == "/p") if (args.Count > 1 && args[1] == "/p")
@ -616,7 +624,10 @@ namespace winsw
if (args[0] == "uninstall") if (args[0] == "uninstall")
{ {
if (s == null) if (s == null)
{
Console.WriteLine("Warning! The service with id '" + d.Id + "' does not exist. Nothing to uninstall");
return; // there's no such service, so consider it already uninstalled return; // there's no such service, so consider it already uninstalled
}
try try
{ {
s.Delete(); s.Delete();