support stats counter in ray stream

pull/1008/head
Darien Raymond 2018-03-30 23:17:28 +02:00
parent 35e160a1ff
commit f7dd7e6279
No known key found for this signature in database
GPG Key ID: 7251FFA14BB18169
9 changed files with 71 additions and 14 deletions

View File

@ -54,7 +54,7 @@ func (d *DefaultDispatcher) Dispatch(ctx context.Context, destination net.Destin
} }
ctx = proxy.ContextWithTarget(ctx, destination) ctx = proxy.ContextWithTarget(ctx, destination)
outbound := ray.NewRay(ctx) outbound := ray.New(ctx)
snifferList := proxyman.ProtocolSniffersFromContext(ctx) snifferList := proxyman.ProtocolSniffersFromContext(ctx)
if destination.Address.Family().IsDomain() || len(snifferList) == 0 { if destination.Address.Family().IsDomain() || len(snifferList) == 0 {
go d.routedDispatch(ctx, outbound, destination) go d.routedDispatch(ctx, outbound, destination)

View File

@ -87,7 +87,7 @@ var muxCoolPort = net.Port(9527)
func NewClient(p proxy.Outbound, dialer proxy.Dialer, m *ClientManager) (*Client, error) { func NewClient(p proxy.Outbound, dialer proxy.Dialer, m *ClientManager) (*Client, error) {
ctx := proxy.ContextWithTarget(context.Background(), net.TCPDestination(muxCoolAddress, muxCoolPort)) ctx := proxy.ContextWithTarget(context.Background(), net.TCPDestination(muxCoolAddress, muxCoolPort))
ctx, cancel := context.WithCancel(ctx) ctx, cancel := context.WithCancel(ctx)
pipe := ray.NewRay(ctx) pipe := ray.New(ctx)
c := &Client{ c := &Client{
sessionManager: NewSessionManager(), sessionManager: NewSessionManager(),
@ -266,7 +266,7 @@ func (s *Server) Dispatch(ctx context.Context, dest net.Destination) (ray.Inboun
return s.dispatcher.Dispatch(ctx, dest) return s.dispatcher.Dispatch(ctx, dest)
} }
ray := ray.NewRay(ctx) ray := ray.New(ctx)
worker := &ServerWorker{ worker := &ServerWorker{
dispatcher: s.dispatcher, dispatcher: s.dispatcher,
outboundRay: ray, outboundRay: ray,

View File

@ -103,7 +103,7 @@ func (h *Handler) Dial(ctx context.Context, dest net.Destination) (internet.Conn
if handler != nil { if handler != nil {
newError("proxying to ", tag, " for dest ", dest).AtDebug().WithContext(ctx).WriteToLog() newError("proxying to ", tag, " for dest ", dest).AtDebug().WithContext(ctx).WriteToLog()
ctx = proxy.ContextWithTarget(ctx, dest) ctx = proxy.ContextWithTarget(ctx, dest)
stream := ray.NewRay(ctx) stream := ray.New(ctx)
go handler.Dispatch(ctx, stream) go handler.Dispatch(ctx, stream)
return ray.NewConnection(stream.InboundOutput(), stream.InboundInput()), nil return ray.NewConnection(stream.InboundOutput(), stream.InboundInput()), nil
} }

View File

@ -18,7 +18,7 @@ func (c *Counter) Value() int64 {
return atomic.LoadInt64(&c.value) return atomic.LoadInt64(&c.value)
} }
func (c *Counter) Exchange(newValue int64) int64 { func (c *Counter) Set(newValue int64) int64 {
return atomic.SwapInt64(&c.value, newValue) return atomic.SwapInt64(&c.value, newValue)
} }

View File

@ -1,10 +1,12 @@
package stats_test package stats_test
import ( import (
"context"
"testing" "testing"
"v2ray.com/core" "v2ray.com/core"
. "v2ray.com/core/app/stats" . "v2ray.com/core/app/stats"
"v2ray.com/core/common"
. "v2ray.com/ext/assert" . "v2ray.com/ext/assert"
) )
@ -13,3 +15,18 @@ func TestInternface(t *testing.T) {
assert((*Manager)(nil), Implements, (*core.StatManager)(nil)) assert((*Manager)(nil), Implements, (*core.StatManager)(nil))
} }
func TestStatsCounter(t *testing.T) {
assert := With(t)
raw, err := common.CreateObject(context.Background(), &Config{})
assert(err, IsNil)
m := raw.(core.StatManager)
c, err := m.RegisterCounter("test.counter")
assert(err, IsNil)
assert(c.Add(1), Equals, int64(1))
assert(c.Set(0), Equals, int64(1))
assert(c.Value(), Equals, int64(0))
}

View File

@ -6,7 +6,7 @@ import (
type StatCounter interface { type StatCounter interface {
Value() int64 Value() int64
Exchange(int64) int64 Set(int64) int64
Add(int64) int64 Add(int64) int64
} }

View File

@ -33,7 +33,7 @@ func TestSameDestinationDispatching(t *testing.T) {
assert := With(t) assert := With(t)
ctx, cancel := context.WithCancel(context.Background()) ctx, cancel := context.WithCancel(context.Background())
link := ray.NewRay(ctx) link := ray.New(ctx)
go func() { go func() {
for { for {
data, err := link.OutboundInput().ReadMultiBuffer() data, err := link.OutboundInput().ReadMultiBuffer()

View File

@ -12,11 +12,25 @@ import (
"v2ray.com/core/common/signal" "v2ray.com/core/common/signal"
) )
// NewRay creates a new Ray for direct traffic transport. type Option func(*Stream)
func NewRay(ctx context.Context) Ray {
type addInt64 interface {
Add(int64) int64
}
func WithStatCounter(c addInt64) Option {
return func(s *Stream) {
s.onDataSize = append(s.onDataSize, func(delta uint64) {
c.Add(int64(delta))
})
}
}
// New creates a new Ray for direct traffic transport.
func New(ctx context.Context, opts ...Option) Ray {
return &directRay{ return &directRay{
Input: NewStream(ctx), Input: NewStream(ctx, opts...),
Output: NewStream(ctx), Output: NewStream(ctx, opts...),
} }
} }
@ -60,18 +74,23 @@ type Stream struct {
ctx context.Context ctx context.Context
readSignal *signal.Notifier readSignal *signal.Notifier
writeSignal *signal.Notifier writeSignal *signal.Notifier
onDataSize []func(uint64)
close bool close bool
err bool err bool
} }
// NewStream creates a new Stream. // NewStream creates a new Stream.
func NewStream(ctx context.Context) *Stream { func NewStream(ctx context.Context, opts ...Option) *Stream {
return &Stream{ s := &Stream{
ctx: ctx, ctx: ctx,
readSignal: signal.NewNotifier(), readSignal: signal.NewNotifier(),
writeSignal: signal.NewNotifier(), writeSignal: signal.NewNotifier(),
size: 0, size: 0,
} }
for _, opt := range opts {
opt(s)
}
return s
} }
func (s *Stream) getData() (buf.MultiBuffer, error) { func (s *Stream) getData() (buf.MultiBuffer, error) {
@ -201,8 +220,13 @@ func (s *Stream) WriteMultiBuffer(data buf.MultiBuffer) error {
s.data = buf.NewMultiBufferCap(128) s.data = buf.NewMultiBufferCap(128)
} }
dataSize := uint64(data.Len())
for _, f := range s.onDataSize {
f(dataSize)
}
s.data.AppendMulti(data) s.data.AppendMulti(data)
s.size += uint64(data.Len()) s.size += dataSize
s.writeSignal.Signal() s.writeSignal.Signal()
return nil return nil

View File

@ -5,6 +5,7 @@ import (
"io" "io"
"testing" "testing"
"v2ray.com/core/app/stats"
"v2ray.com/core/common/buf" "v2ray.com/core/common/buf"
. "v2ray.com/core/transport/ray" . "v2ray.com/core/transport/ray"
. "v2ray.com/ext/assert" . "v2ray.com/ext/assert"
@ -47,3 +48,18 @@ func TestStreamClose(t *testing.T) {
_, err = stream.ReadMultiBuffer() _, err = stream.ReadMultiBuffer()
assert(err, Equals, io.EOF) assert(err, Equals, io.EOF)
} }
func TestStreamStatCounter(t *testing.T) {
assert := With(t)
c := new(stats.Counter)
stream := NewStream(context.Background(), WithStatCounter(c))
b1 := buf.New()
b1.AppendBytes('a', 'b', 'c', 'd')
assert(stream.WriteMultiBuffer(buf.NewMultiBufferValue(b1)), IsNil)
stream.Close()
assert(c.Value(), Equals, int64(4))
}