From ed1243b32b91dfcf1f652f140f6e97d50cc64af4 Mon Sep 17 00:00:00 2001 From: Darien Raymond Date: Sat, 18 Nov 2017 19:40:53 +0100 Subject: [PATCH] require proxy auth when not set. fix #712 --- proxy/http/server.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/proxy/http/server.go b/proxy/http/server.go index 4bf81e3d..76970517 100644 --- a/proxy/http/server.go +++ b/proxy/http/server.go @@ -103,7 +103,11 @@ Start: if len(s.config.Accounts) > 0 { user, pass, ok := parseBasicAuth(request.Header.Get("Proxy-Authorization")) - if !ok || !s.config.HasAccount(user, pass) { + if !ok { + _, err := conn.Write([]byte("HTTP/1.1 407 Proxy Authentication Required\r\n\r\n")) + return err + } + if !s.config.HasAccount(user, pass) { _, err := conn.Write([]byte("HTTP/1.1 401 UNAUTHORIZED\r\n\r\n")) return err }