fix notifier for backward compatibility

pull/1173/head
Darien Raymond 2018-06-26 15:28:59 +02:00
parent 2fb77d6911
commit e5f6554703
No known key found for this signature in database
GPG Key ID: 7251FFA14BB18169
1 changed files with 16 additions and 3 deletions

View File

@ -5,7 +5,8 @@ import "sync"
// Notifier is a utility for notifying changes. The change producer may notify changes multiple time, and the consumer may get notified asynchronously. // Notifier is a utility for notifying changes. The change producer may notify changes multiple time, and the consumer may get notified asynchronously.
type Notifier struct { type Notifier struct {
sync.Mutex sync.Mutex
waiters []chan struct{} waiters []chan struct{}
notCosumed bool
} }
// NewNotifier creates a new Notifier. // NewNotifier creates a new Notifier.
@ -16,19 +17,31 @@ func NewNotifier() *Notifier {
// Signal signals a change, usually by producer. This method never blocks. // Signal signals a change, usually by producer. This method never blocks.
func (n *Notifier) Signal() { func (n *Notifier) Signal() {
n.Lock() n.Lock()
defer n.Unlock()
if len(n.waiters) == 0 {
n.notCosumed = true
return
}
for _, w := range n.waiters { for _, w := range n.waiters {
close(w) close(w)
} }
n.waiters = make([]chan struct{}, 0, 8) n.waiters = make([]chan struct{}, 0, 8)
n.Unlock()
} }
// Wait returns a channel for waiting for changes. The returned channel never gets closed. // Wait returns a channel for waiting for changes.
func (n *Notifier) Wait() <-chan struct{} { func (n *Notifier) Wait() <-chan struct{} {
n.Lock() n.Lock()
defer n.Unlock() defer n.Unlock()
w := make(chan struct{}) w := make(chan struct{})
if n.notCosumed {
n.notCosumed = false
close(w)
return w
}
n.waiters = append(n.waiters, w) n.waiters = append(n.waiters, w)
return w return w
} }