github
/
v2ray-core
mirror of https://github.com/v2ray/v2ray-core
1
0
Fork 0
Code Issues Releases Wiki Activity

app/router: rewrite if-else chain to switch 

From effective Go: https://golang.org/doc/effective_go.html#switch

> It's therefore possible—and idiomatic—to write an if-else-if-else chain as a switch.
pull/1293/head
Iskander Sharipov 2018-10-01 12:07:19 +03:00
parent 091fa6ad23
commit 4dfe45ec19
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
app/router/config.go
View File

@ -36,14 +36,15 @@ func cidrToCondition(cidr []*CIDR, source bool) (Condition, error) {
} }
} }
if !ipv4Net.IsEmpty() && hasIpv6 { switch {
case !ipv4Net.IsEmpty() && hasIpv6:
cond := NewAnyCondition() cond := NewAnyCondition()
cond.Add(NewIPv4Matcher(ipv4Net, source)) cond.Add(NewIPv4Matcher(ipv4Net, source))
cond.Add(ipv6Cond) cond.Add(ipv6Cond)
return cond, nil return cond, nil
} else if !ipv4Net.IsEmpty() { case !ipv4Net.IsEmpty():
return NewIPv4Matcher(ipv4Net, source), nil return NewIPv4Matcher(ipv4Net, source), nil
} else { default:
return ipv6Cond, nil return ipv6Cond, nil
} }
} }