From 0959755d2104379e7a89bd71cc3ed0284f8dd6e7 Mon Sep 17 00:00:00 2001 From: Darien Raymond Date: Sat, 16 Dec 2017 02:02:48 +0100 Subject: [PATCH] fix a buffer leak in buffered reader --- common/buf/writer.go | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/common/buf/writer.go b/common/buf/writer.go index 56bcd880..85771cff 100644 --- a/common/buf/writer.go +++ b/common/buf/writer.go @@ -93,6 +93,9 @@ func (w *BufferedWriter) WriteMultiBuffer(b MultiBuffer) error { defer b.Release() for !b.IsEmpty() { + if w.buffer == nil { + w.buffer = New() + } if err := w.buffer.AppendSupplier(ReadFrom(&b)); err != nil { return err } @@ -113,11 +116,7 @@ func (w *BufferedWriter) Flush() error { return err } - if w.buffered { - w.buffer = New() - } else { - w.buffer = nil - } + w.buffer = nil } return nil }