From 871cb37f09776b8eae9c9dce04d10b5d7bb5e15a Mon Sep 17 00:00:00 2001
From: Willy <jemand771@gmx.net>
Date: Tue, 31 Jan 2023 21:19:25 +0100
Subject: [PATCH] move no and go versions to data step, bump go to 1.18

---
 .github/workflows/build.yml | 28 ++++++++++++++++------------
 1 file changed, 16 insertions(+), 12 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index b56239e7..b2b822d7 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -19,6 +19,8 @@ jobs:
       is_release: ${{ steps.states.outputs.is_release }}
       is_stable: ${{ steps.states.outputs.is_stable }}
       is_unstable: ${{ steps.states.outputs.is_unstable }}
+      go_version: 1.18.x
+      node_version: 12.18.2
     steps:
       - uses: actions/checkout@v2
       - name: get version
@@ -37,10 +39,10 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-go@v2
         with:
-          go-version: 1.15.x
+          go-version: ${{ needs.data.outputs.go_version }}
       - uses: actions/setup-node@v1
         with:
-          node-version: 12.18.2
+          node-version: ${{ needs.data.outputs.node_version }}
 
       - name: Add go/bin to path
         run: |
@@ -156,7 +158,7 @@ jobs:
           COMMIT: ${{ github.sha }}
         with:
           xgo_version: latest
-          go_version: 1.15.x
+          go_version: ${{ needs.data.outputs.go_version }}
           dest: build
           prefix: statping
           targets: ${{ matrix.platform }}/${{ matrix.arch }}
@@ -210,6 +212,8 @@ jobs:
         run: |
           aws s3 cp build/${{ env.compressed }} s3://assets.statping.com/commit/${{ github.sha }}/
 
+  # TODO refactor (and fix) tests
+
   test:
     needs: [ data, frontend ]
     # temporarily disabled
@@ -239,10 +243,10 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-go@v2
         with:
-          go-version: 1.15.x
+          go-version: ${{ needs.data.outputs.go_version }}
       - uses: actions/setup-node@v1
         with:
-          node-version: 12.18.2
+          node-version: ${{ needs.data.outputs.node_version }}
 
       - name: Install Global Dependencies
         run: npm install -g yarn sass newman cross-env wait-on @sentry/cli
@@ -250,7 +254,7 @@ jobs:
       - name: Setting ENV's
         run: |
           echo "$(go env GOPATH)/bin" >> $GITHUB_PATH
-          echo "/opt/hostedtoolcache/node/12.18.2/x64/bin" >> $GITHUB_PATH
+          echo "/opt/hostedtoolcache/node/${{ needs.data.outputs.node_version }}/x64/bin" >> $GITHUB_PATH
         shell: bash
 
       - name: Download Compiled Frontend (rice-box.go)
@@ -322,12 +326,12 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-go@v2
         with:
-          go-version: 1.15.x
+          go-version: ${{ needs.data.outputs.go_version }}
 
       - name: Setting ENV's
         run: |
           echo "$(go env GOPATH)/bin" >> $GITHUB_PATH
-          echo "/opt/hostedtoolcache/node/12.18.2/x64/bin" >> $GITHUB_PATH
+          echo "/opt/hostedtoolcache/node/${{ needs.data.outputs.node_version }}/x64/bin" >> $GITHUB_PATH
         shell: bash
 
       - name: Download Compiled Frontend (rice-box.go)
@@ -375,12 +379,12 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-go@v2
         with:
-          go-version: 1.15.x
+          go-version: ${{ needs.data.outputs.go_version }}
 
       - name: Setting ENV's
         run: |
           echo "$(go env GOPATH)/bin" >> $GITHUB_PATH
-          echo "/opt/hostedtoolcache/node/12.18.2/x64/bin" >> $GITHUB_PATH
+          echo "/opt/hostedtoolcache/node/${{ needs.data.outputs.node_version }}/x64/bin" >> $GITHUB_PATH
         shell: bash
 
       - name: Download Compiled Frontend (rice-box.go)
@@ -431,12 +435,12 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-go@v2
         with:
-          go-version: 1.15.x
+          go-version: ${{ needs.data.outputs.go_version }}
 
       - name: Setting ENV's
         run: |
           echo "$(go env GOPATH)/bin" >> $GITHUB_PATH
-          echo "/opt/hostedtoolcache/node/12.18.2/x64/bin" >> $GITHUB_PATH
+          echo "/opt/hostedtoolcache/node/${{ needs.data.outputs.node_version }}/x64/bin" >> $GITHUB_PATH
         shell: bash
 
       - name: Download Compiled Frontend (rice-box.go)