From 4fe05e2f7127a03bc7331618d6fa2d78184d100b Mon Sep 17 00:00:00 2001 From: hunterlong Date: Fri, 2 Oct 2020 11:16:10 -0700 Subject: [PATCH] added race condition testing --- .github/workflows/development.yml | 2 +- .github/workflows/master.yml | 2 +- CHANGELOG.md | 1 + notifiers/amazon_sns.go | 2 +- types/services/services_test.go | 2 +- 5 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/development.yml b/.github/workflows/development.yml index cdf00ff4..36140aed 100644 --- a/.github/workflows/development.yml +++ b/.github/workflows/development.yml @@ -250,7 +250,7 @@ jobs: - name: Go Tests run: | go get gotest.tools/gotestsum - gotestsum --no-summary=skipped --format dots -- -covermode=count -coverprofile=coverage.out -p=1 ./... + gotestsum --no-summary=skipped --format testname -- -covermode=count -coverprofile=coverage.out -race -p=1 ./... env: VERSION: ${{ env.VERSION }} COMMIT: ${{ github.sha }} diff --git a/.github/workflows/master.yml b/.github/workflows/master.yml index 002ba915..5cd9bfe0 100644 --- a/.github/workflows/master.yml +++ b/.github/workflows/master.yml @@ -250,7 +250,7 @@ jobs: - name: Go Tests run: | go get gotest.tools/gotestsum - gotestsum --no-summary=skipped --format dots -- -covermode=count -coverprofile=coverage.out -p=1 ./... + gotestsum --no-summary=skipped --format testname -- -covermode=count -coverprofile=coverage.out -race -p=1 ./... env: VERSION: ${{ env.VERSION }} COMMIT: ${{ github.sha }} diff --git a/CHANGELOG.md b/CHANGELOG.md index 8e358bdc..ff2cb083 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,6 @@ # 0.90.70 (10-1-2020) - Merged PR #806 - Enhance GRPC Monitoring +- Merged PR #692 - When login fields are autofilled the sign in button should be enabled - Modified multiple Vue forms to use number models for integer inputs # 0.90.69 (09-18-2020) diff --git a/notifiers/amazon_sns.go b/notifiers/amazon_sns.go index f1405a48..123ccf06 100644 --- a/notifiers/amazon_sns.go +++ b/notifiers/amazon_sns.go @@ -35,7 +35,7 @@ var AmazonSNS = &amazonSNS{¬ifications.Notification{ Description: "Use amazonSNS to receive push notifications. Add your amazonSNS URL and App Token to receive notifications.", Author: "Hunter Long", AuthorUrl: "https://github.com/hunterlong", - Icon: "amazon", + Icon: "fab fa-amazon", Delay: 5 * time.Second, Limits: 60, SuccessData: null.NewNullString(`{{.Service.Name}} is back online and was down for {{.Service.Downtime.Human}}`), diff --git a/types/services/services_test.go b/types/services/services_test.go index 81703b68..637e2088 100644 --- a/types/services/services_test.go +++ b/types/services/services_test.go @@ -469,7 +469,7 @@ func TestServices(t *testing.T) { item, err := Find(1) require.Nil(t, err) amount := item.Downtime().Seconds() - assert.GreaterOrEqual(t, int64(75), int64(amount)) + assert.GreaterOrEqual(t, int64(amount), int64(75)) }) t.Run("Test Failures Since", func(t *testing.T) {