You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Jorge Creixell e9e3d64b7c PromQL engine: Delay deletion of __name__ label to the end of the query evaluation (#14477) ... PromQL engine: Delay deletion of __name__ label to the end of the query evaluation - This change allows optionally preserving the `__name__` label via the `label_replace` and `label_join` functions, and helps prevent the dreaded "vector cannot contain metrics with the same labelset" error. - The implementation extends the `Series` and `Sample` structs with a boolean flag indicating whether the `__name__` label should be deleted at the end of the query evaluation. - The `label_replace` and `label_join` functions can still access the value of the `__name__` label, even if it has been previously marked for deletion. If `__name__` is used as target label, it won't be dropped at the end of the query evaluation. - Fixes https://github.com/prometheus/prometheus/issues/11397 - See https://github.com/jcreixell/prometheus/pull/2 for previous discussion, including the decision to create this PR and benchmark it before considering other alternatives (like refactoring `labels.Labels`). - See https://github.com/jcreixell/prometheus/pull/1 for an alternative implementation using a special label instead of boolean flags. - Note: a feature flag `promql-delayed-name-removal` has been added as it changes the behavior of some "weird" queries (see https://github.com/prometheus/prometheus/issues/11397#issuecomment-1451998792) Example (this always fails, as `__name__` is being dropped by `count_over_time`): ``` count_over_time({__name__!=""}[1m]) => Error executing query: vector cannot contain metrics with the same labelset ``` Before: ``` label_replace(count_over_time({__name__!=""}[1m]), "__name__", "count_$1", "__name__", "(.+)") => Error executing query: vector cannot contain metrics with the same labelset ``` After: ``` label_replace(count_over_time({__name__!=""}[1m]), "__name__", "count_$1", "__name__", "(.+)") => count_go_gc_cycles_automatic_gc_cycles_total{instance="localhost:9090", job="prometheus"} 1 count_go_gc_cycles_forced_gc_cycles_total{instance="localhost:9090", job="prometheus"} 1 ... ``` Signed-off-by: Jorge Creixell <jcreixell@gmail.com> --------- Signed-off-by: Jorge Creixell <jcreixell@gmail.com> Signed-off-by: Björn Rabenstein <github@rabenste.in>		3 months ago
..
command-line	PromQL engine: Delay deletion of __name__ label to the end of the query evaluation (#14477)	3 months ago
configuration	Merge branch 'release-2.54' into merge-2.54.1-into-main	3 months ago
images	…
querying	Merge pull request #14655 from suntala/suntala/sort-by-label-enhancement	3 months ago
feature_flags.md	PromQL engine: Delay deletion of __name__ label to the end of the query evaluation (#14477)	3 months ago
federation.md	docs: Update federation docs for native histograms	2 years ago
getting_started.md	Update getting_started.md	2 years ago
http_sd.md	Added a failure counter to the HTTP service discovery (#10372)	3 years ago
index.md	…
installation.md	docs: clarify default Docker command line parameters (#14194)	6 months ago
management_api.md	/-/{healthy,ready}/ respond to HEAD (#11160)	2 years ago
migration.md	Document command line tools	2 years ago
stability.md	docs: state that remote write is stable	2 years ago
storage.md	Update storage.md to provide right-sizing advice on retention	4 months ago