You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Julius Volz 80b3d3bf34 Speed up disk flushes by removing unnecessary sort. ... The first sort in groupByFingerprint already ensures that all resulting sample lists contain only one fingerprint. We also already assume that all samples passed into AppendSamples (and thus groupByFingerprint) are chronologically sorted within each fingerprint. The extra chronological sort is thus superfluous. Furthermore, this second sort didn't only sort chronologically, but also compared all metric fingerprints again (although we already know that we're only sorting within samples for the same fingerprint). This caused a huge memory and runtime overhead. In a heavily loaded real Prometheus, this brought down disk flush times from ~9 minutes to ~1 minute. OLD: BenchmarkLevelDBAppendRepeatingValues 5 331391808 ns/op 44542953 B/op 597788 allocs/op BenchmarkLevelDBAppendsRepeatingValues 5 329893512 ns/op 46968288 B/op 3104373 allocs/op NEW: BenchmarkLevelDBAppendRepeatingValues 5 299298635 ns/op 43329497 B/op 567616 allocs/op BenchmarkLevelDBAppendsRepeatingValues 20 92204601 ns/op 1779454 B/op 70975 allocs/op Change-Id: Ie2d8db3569b0102a18010f9e106e391fda7f7883		10 years ago
..
compaction_regression_test.go	Separate storage implementation from interfaces.	11 years ago
curator.go	Migrate to new client_golang.	10 years ago
dto.go	Separate storage implementation from interfaces.	11 years ago
end_to_end_test.go	Weed out our homegrown test.Tester.	11 years ago
freelist.go	Separate storage implementation from interfaces.	11 years ago
freelist_test.go	Separate storage implementation from interfaces.	11 years ago
index.go	Separate storage implementation from interfaces.	11 years ago
interface_test.go	Separate storage implementation from interfaces.	11 years ago
leveldb.go	Speed up disk flushes by removing unnecessary sort.	10 years ago
marshal.go	Separate storage implementation from interfaces.	11 years ago
memory.go	Only evict memory series after they are on disk.	10 years ago
memory_test.go	Only evict memory series after they are on disk.	10 years ago
objective.go	Separate storage implementation from interfaces.	11 years ago
operation.go	Separate storage implementation from interfaces.	11 years ago
operation_test.go	Separate storage implementation from interfaces.	11 years ago
processor.go	Separate storage implementation from interfaces.	11 years ago
processor_test.go	Separate storage implementation from interfaces.	11 years ago
regressions_test.go	Weed out our homegrown test.Tester.	11 years ago
rule_integration_test.go	Weed out our homegrown test.Tester.	11 years ago
sample_test.go	Separate storage implementation from interfaces.	11 years ago
samplekey.go	Separate storage implementation from interfaces.	11 years ago
stochastic_test.go	Weed out our homegrown test.Tester.	11 years ago
test_helpers.go	Add console and alert templates with access to all data.	11 years ago
tiered.go	Only evict memory series after they are on disk.	10 years ago
tiered_test.go	Weed out our homegrown test.Tester.	11 years ago
view.go	Separate storage implementation from interfaces.	11 years ago
view_test.go	Weed out our homegrown test.Tester.	11 years ago
watermark.go	Separate storage implementation from interfaces.	11 years ago