prometheus

The Prometheus monitoring system and time series database.

prometheus hacktoberfest metrics alerting graphing monitoring time-series

TJ Hoplock ab97c9e09f fix!: stop unbounded memory usage from query log Resolves: #15433 When I converted prometheus to use slog in #14906, I update both the `QueryLogger` interface, as well as how the log calls to the `QueryLogger` were built up in `promql.Engine.exec()`. The backing logger for the `QueryLogger` in the engine is a `util/logging.JSONFileLogger`, and it's implementation of the `With()` method updates the logger the logger in place with the new keyvals added onto the underlying `slog.Logger`, which means they get inherited onto everything after. All subsequent calls to `With()`, even in later queries, would continue to then append on more and more keyvals for the various params and fields built up in the logger. In turn, this causes unbounded growth of the logger, leading to increased memory usage, and in at least one report was the likely cause of an OOM kill. More information can be found in the issue and the linked slack thread. This commit does a few things: - It was referenced in feedback in #14906 that it would've been better to not change the `QueryLogger` interface if possible, this PR proposes changes that bring it closer to alignment with the pre-3.0 `QueryLogger` interface contract - reverts `promql.Engine.exec()`'s usage of the query logger to the pattern of building up an array of args to pass at once to the end log call. Avoiding the repetitious calls to `.With()` are what resolve the issue with the logger growth/memory usage. - updates the scrape failure logger to use the update `QueryLogger` methods in the contract. - updates tests accordingly - cleans up unused methods Builds and passes tests successfully. Tested locally and confirmed I could no longer reproduce the issue/it resolved the issue. Signed-off-by: TJ Hoplock <t.hoplock@gmail.com>		1 day ago
..
fuzz-data	…
parser	Use a function to determine if an aggregation function is experimental (#15331 )	1 week ago
promqltest	PromQL: Convert more native histogram tests to promql-test framework (#15419 )	2 days ago
bench_test.go	v2.55.0	4 weeks ago
engine.go	fix!: stop unbounded memory usage from query log	1 day ago
engine_internal_test.go	chore!: adopt log/slog, remove go-kit/log	2 months ago
engine_test.go	fix!: stop unbounded memory usage from query log	1 day ago
functions.go	Merge branch 'main' into jhesketh/clamp	2 weeks ago
functions_internal_test.go	Fix issue where summation of +/- infinity returns NaN instead of infinity	5 months ago
functions_test.go	Refactor engine creation in tests	4 months ago
fuzz.go	scrape: provide a fallback format (#15136 )	1 month ago
fuzz_test.go	fix: use "ErrorContains" or "EqualError" instead of "Contains(t, err.Error()" and "Equal(t, err.Error()" (#15094 )	2 months ago
histogram_stats_iterator.go	Use CopyTo when resetting histogram in stats iterator	4 months ago
histogram_stats_iterator_test.go	Upgrade to golangci-lint v1.62.0 (#15424 )	2 days ago
info.go	enable errorf rule from perfsprint linter	2 weeks ago
info_test.go	[FEATURE] PromQL: Add experimental info function MVP (#14495 )	1 month ago
promql_test.go	Refactor engine creation in tests	4 months ago
quantile.go	promql(native histograms): Introduce exponential interpolation	2 months ago
quantile_test.go	PromQL: ignore small errors for bucketQuantile (#13153 )	1 year ago
query_logger.go	chore!: adopt log/slog, remove go-kit/log	2 months ago
query_logger_test.go	chore: Fix typos (#14868 )	2 months ago
value.go	chore: Fix typos (#14868 )	2 months ago
value_test.go	test: move most PromQL tests into separate test package	7 months ago