You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

beorn7 5b53aa1108 style: Replace `else if` cascades with `switch` ... Wiser coders than myself have come to the conclusion that a `switch` statement is almost always superior to a statement that includes any `else if`. The exceptions that I have found in our codebase are just these two: * The `if else` is followed by an additional statement before the next condition (separated by a `;`). * The whole thing is within a `for` loop and `break` statements are used. In this case, using `switch` would require tagging the `for` loop, which probably tips the balance. Why are `switch` statements more readable? For one, fewer curly braces. But more importantly, the conditions all have the same alignment, so the whole thing follows the natural flow of going down a list of conditions. With `else if`, in contrast, all conditions but the first are "hidden" behind `} else if `, harder to spot and (for no good reason) presented differently from the first condition. I'm sure the aforemention wise coders can list even more reasons. In any case, I like it so much that I have found myself recommending it in code reviews. I would like to make it a habit in our code base, without making it a hard requirement that we would test on the CI. But for that, there has to be a role model, so this commit eliminates all `if else` occurrences, unless it is autogenerated code or fits one of the exceptions above. Signed-off-by: beorn7 <beorn@grafana.com>		2 years ago
..
chunked.go	(storage): move from github.com/pkg/errors to 'errors' and 'fmt' (#10946)	2 years ago
chunked_test.go	…
client.go	remote.Client: store urlString	2 years ago
client_test.go	remote: Convert to RecoverableError using errors.As (#12103)	2 years ago
codec.go	style: Replace `else if` cascades with `switch`	2 years ago
codec_test.go	lint: Adjust to the lint warnings raised by current versions of golint-ci	2 years ago
ewma.go	style: Replace `else if` cascades with `switch`	2 years ago
intern.go	…
intern_test.go	…
max_timestamp.go	…
metadata_watcher.go	(storage): move from github.com/pkg/errors to 'errors' and 'fmt' (#10946)	2 years ago
metadata_watcher_test.go	(storage): move from github.com/pkg/errors to 'errors' and 'fmt' (#10946)	2 years ago
queue_manager.go	style: Replace `else if` cascades with `switch`	2 years ago
queue_manager_test.go	lint: Adjust to the lint warnings raised by current versions of golint-ci	2 years ago
read.go	labels: simplify call to get Labels from Builder	2 years ago
read_handler.go	remote/read_handler: pool input to Marshal() (#11357)	2 years ago
read_handler_test.go	Remove hacky promql.Test native histogram thing	2 years ago
read_test.go	Handle native histograms in remote read	2 years ago
storage.go	storage/remote: in tests use labels.FromStrings	2 years ago
storage_test.go	Update package storage/remote tests for new labels.Labels type	2 years ago
write.go	Support FloatHistogram in TSDB (#11522)	2 years ago
write_handler.go	Add support for native histograms to concreteSeriesIterator	2 years ago
write_handler_test.go	lint: Adjust to the lint warnings raised by current versions of golint-ci	2 years ago
write_test.go	Update package storage/remote tests for new labels.Labels type	2 years ago