prometheus

The Prometheus monitoring system and time series database.

prometheus hacktoberfest metrics alerting graphing monitoring time-series

beorn7 5b53aa1108 style: Replace `else if` cascades with `switch` Wiser coders than myself have come to the conclusion that a `switch` statement is almost always superior to a statement that includes any `else if`. The exceptions that I have found in our codebase are just these two: * The `if else` is followed by an additional statement before the next condition (separated by a `;`). * The whole thing is within a `for` loop and `break` statements are used. In this case, using `switch` would require tagging the `for` loop, which probably tips the balance. Why are `switch` statements more readable? For one, fewer curly braces. But more importantly, the conditions all have the same alignment, so the whole thing follows the natural flow of going down a list of conditions. With `else if`, in contrast, all conditions but the first are "hidden" behind `} else if `, harder to spot and (for no good reason) presented differently from the first condition. I'm sure the aforemention wise coders can list even more reasons. In any case, I like it so much that I have found myself recommending it in code reviews. I would like to make it a habit in our code base, without making it a hard requirement that we would test on the CI. But for that, there has to be a role model, so this commit eliminates all `if else` occurrences, unless it is autogenerated code or fits one of the exceptions above. Signed-off-by: beorn7 <beorn@grafana.com>		2 years ago
..
fuzz-data	textparse: Add fuzzing and fix bug caught	7 years ago
parser	style: Replace `else if` cascades with `switch`	2 years ago
testdata	Adds day_of_year function to PromQL	3 years ago
bench_test.go	lint: Adjust to the lint warnings raised by current versions of golint-ci	2 years ago
engine.go	style: Replace `else if` cascades with `switch`	2 years ago
engine_test.go	add ctx to QueryEngine interface	2 years ago
functions.go	style: Replace `else if` cascades with `switch`	2 years ago
functions_test.go	add ctx to QueryEngine interface	2 years ago
fuzz.go	refactor (promql): move from github.com/pkg/errors to 'errors' and 'fmt' (#10817 )	2 years ago
fuzz_test.go	error for invalid media type should not be completely swallowed (#10186 )	3 years ago
promql_test.go	add ctx to QueryEngine interface	2 years ago
quantile.go	style: Replace `else if` cascades with `switch`	2 years ago
query_logger.go	Close file descriptor in query logging (#11148 )	2 years ago
query_logger_test.go	refactor: move from io/ioutil to io and os packages (#10528 )	3 years ago
test.go	add ctx to QueryEngine interface	2 years ago
test_test.go	promql: Separate `Point` into `FPoint` and `HPoint`	2 years ago
value.go	promql: Separate `Point` into `FPoint` and `HPoint`	2 years ago
value_test.go	Shortcut `ContainsSameLabelset()` (#11000 )	2 years ago