You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Björn Rabenstein 4cb5f23c35 api: Improve doc comments for v1.MinTime and v1.MaxTime (#14986) ... api: Improve doc comments for v1.MinTime and v1.MaxTime While investigated something mostly unrelated, I got nerd-sniped by the calculation of v1.MinTime and v1.MaxTime. The seemingly magic number in there (62135596801) needed an explanation. While looking for it, I found out that the offsets used here are actually needlessly conservative. Since the timestamps are so far in the past or future, respectively, that there is no practical impact, except that the calculation is needlessly obfuscated. However, we won't change the values now to not cause any confusion for users of this code. Still, I think the doc comment should explain the circumstances so nobody gets nerd-sniped again as I did today. For the record: 62135596800 is the difference in seconds between 0001-01-01 00:00:00 (Unix time zero point) and 1971-01-01 00:00:00 (Go time zero point) in the Gregorian calendar. If "Prometheus time" were in seconds (not milliseconds), that difference would be relevant to prevent over-/underflow when converting from "Prometheus time" to "Go time". Signed-off-by: beorn7 <beorn@grafana.com> --------- Signed-off-by: beorn7 <beorn@grafana.com>		2 months ago
..
v1	api: Improve doc comments for v1.MinTime and v1.MaxTime (#14986)	2 months ago
notifications.go	Limit the number of SSE Subscribers to 16 by default	2 months ago
notifications_test.go	Limit the number of SSE Subscribers to 16 by default	2 months ago