github
/
prometheus
mirror of https://github.com/prometheus/prometheus
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
prometheus/storage/remote/otlptranslator
History
komisan19 3d84d4d6dc fix 
Signed-off-by: komisan19 <18901496+komisan19@users.noreply.github.com>
 		2024-04-22 19:04:00 +09:00
..
prometheus otlptranslator: fix up import paths 2024-03-13 15:56:14 +01:00
prometheusremotewrite fix 2024-04-22 19:04:00 +09:00
README.md otlptranslator: fix up import paths 2024-03-13 15:56:14 +01:00
update-copy.sh otlptranslator: fix up import paths 2024-03-13 15:56:14 +01:00

README.md

Copying from opentelemetry/opentelemetry-collector-contrib

This files in the prometheus/ and prometheusremotewrite/ are copied from the OpenTelemetry Project1.

This is done instead of adding a go.mod dependency because OpenTelemetry depends on prometheus/prometheus and a cyclic dependency will be created. This is just a temporary solution and the long-term solution is to move the required packages from OpenTelemetry into prometheus/prometheus.

To update the dependency is a multi-step process:

  1. Vendor the latest prometheus/prometheus@main into opentelemetry/opentelemetry-collector-contrib
  2. Update the VERSION in update-copy.sh.
  3. Run ./update-copy.sh.

Why copy?

This is because the packages we copy depend on the prompb package. While the package is relatively stable, there are still changes. For example, https://github.com/prometheus/prometheus/pull/11935 changed the types. This means if we depend on the upstream packages directly, we will never able to make the changes like above. Hence we're copying the code for now.

I need to manually change these files

When we do want to make changes to the types in prompb, we might need to edit the files directly. That is OK, please let @gouthamve or @jesusvazquez know so they can take care of updating the upstream code (by vendoring in prometheus/prometheus upstream and resolving conflicts) and then will run the copy script again to keep things updated.