prometheus

History

beorn7 0f760f63dd lint: Revamp our linting rules, mostly around doc comments Several things done here: - Set `max-issues-per-linter` to 0 so that we actually see all linter warnings and not just 50 per linter. (As we also set `max-same-issues` to 0, I assume this was the intention from the beginning.) - Stop using the golangci-lint default excludes (by setting `exclude-use-default: false`. Those are too generous and don't match our style conventions. (I have re-added some of the excludes explicitly in this commit. See below.) - Re-add the `errcheck` exclusion we have used so far via the defaults. - Exclude the signature requirement `govet` has for `Seek` methods because we use non-standard `Seek` methods a lot. (But we keep other requirements, while the default excludes completely disabled the check for common method segnatures.) - Exclude warnings about missing doc comments on exported symbols. (We used to be pretty adamant about doc comments, but stopped that at some point in the past. By now, we have about 500 missing doc comments. We may consider reintroducing this check, but that's outside of the scope of this commit. The default excludes of golangci-lint essentially ignore doc comments completely.) - By stop using the default excludes, we now get warnings back on malformed doc comments. That's the most impactful change in this commit. It does not enforce doc comments (again), but _if_ there is a doc comment, it has to have the recommended form. (Most of the changes in this commit are fixing this form.) - Improve wording/spelling of some comments in .golangci.yml, and remove an outdated comment. - Leave `package-comments` inactive, but add a TODO asking if we should change that. - Add a new sub-linter `comment-spacings` (and fix corresponding comments), which avoids missing spaces after the leading `//`. Signed-off-by: beorn7 <beorn@grafana.com>		3 months ago
..
azuread	lint: Revamp our linting rules, mostly around doc comments	3 months ago
googleiam	feat: add Google cloud roundtripper for remote write (#14346 )	4 months ago
otlptranslator	OTLP receiver: Warn when encountering invalid exponential histograms	3 months ago
chunked.go	(storage): move from github.com/pkg/errors to 'errors' and 'fmt' (#10946 )	2 years ago
chunked_test.go	golangci-lint: enable testifylint linter (#13254 )	12 months ago
client.go	Upgrade golangci-lint to v1.60.1	3 months ago
client_test.go	[PRW 2.0] Added Sender and RW Handler support for Response Stats. (#14444 )	4 months ago
codec.go	[PRW 2.0] Merging `remote-write-2.0` feature branch to main (PRW 2.0 support + metadata in WAL) (#14395 )	5 months ago
codec_test.go	[PRW 2.0] write_handler: Support for rc.2 spec & improved error handling for v2. (#14427 )	4 months ago
ewma.go	style: Replace `else if` cascades with `switch`	2 years ago
intern.go	Move away from testutil, refactor imports (#8087 )	4 years ago
intern_test.go	golangci-lint: enable testifylint linter (#13254 )	12 months ago
max_timestamp.go	chore(storage/remote): collect maxTimestamp when value is 0 as well.	5 months ago
metadata_watcher.go	[PRW 2.0] Merging `remote-write-2.0` feature branch to main (PRW 2.0 support + metadata in WAL) (#14395 )	5 months ago
metadata_watcher_test.go	[PRW 2.0] Merging `remote-write-2.0` feature branch to main (PRW 2.0 support + metadata in WAL) (#14395 )	5 months ago
queue_manager.go	Upgrade golangci-lint to v1.60.1	3 months ago
queue_manager_test.go	fix: fix slice init length	3 months ago
read.go	Pass limit param as hint to storage.Querier	5 months ago
read_handler.go	Revert "Chunked remote read: close the querier earlier"	4 months ago
read_handler_test.go	[PRW 2.0] Merging `remote-write-2.0` feature branch to main (PRW 2.0 support + metadata in WAL) (#14395 )	5 months ago
read_test.go	[PRW 2.0] Merging `remote-write-2.0` feature branch to main (PRW 2.0 support + metadata in WAL) (#14395 )	5 months ago
stats.go	[PRW 2.0] Added Sender and RW Handler support for Response Stats. (#14444 )	4 months ago
storage.go	[PRW 2.0] Merging `remote-write-2.0` feature branch to main (PRW 2.0 support + metadata in WAL) (#14395 )	5 months ago
storage_test.go	[PRW 2.0] Merging `remote-write-2.0` feature branch to main (PRW 2.0 support + metadata in WAL) (#14395 )	5 months ago
write.go	feat: add Google cloud roundtripper for remote write (#14346 )	4 months ago
write_handler.go	OTLP receiver: Warn when encountering invalid exponential histograms	3 months ago
write_handler_test.go	Upgrade golangci-lint to v1.60.1	3 months ago
write_test.go	prometheusremotewrite: Support resource attribute promotion	4 months ago