History

beorn7 0f760f63dd lint: Revamp our linting rules, mostly around doc comments Several things done here: - Set `max-issues-per-linter` to 0 so that we actually see all linter warnings and not just 50 per linter. (As we also set `max-same-issues` to 0, I assume this was the intention from the beginning.) - Stop using the golangci-lint default excludes (by setting `exclude-use-default: false`. Those are too generous and don't match our style conventions. (I have re-added some of the excludes explicitly in this commit. See below.) - Re-add the `errcheck` exclusion we have used so far via the defaults. - Exclude the signature requirement `govet` has for `Seek` methods because we use non-standard `Seek` methods a lot. (But we keep other requirements, while the default excludes completely disabled the check for common method segnatures.) - Exclude warnings about missing doc comments on exported symbols. (We used to be pretty adamant about doc comments, but stopped that at some point in the past. By now, we have about 500 missing doc comments. We may consider reintroducing this check, but that's outside of the scope of this commit. The default excludes of golangci-lint essentially ignore doc comments completely.) - By stop using the default excludes, we now get warnings back on malformed doc comments. That's the most impactful change in this commit. It does not enforce doc comments (again), but _if_ there is a doc comment, it has to have the recommended form. (Most of the changes in this commit are fixing this form.) - Improve wording/spelling of some comments in .golangci.yml, and remove an outdated comment. - Leave `package-comments` inactive, but add a TODO asking if we should change that. - Add a new sub-linter `comment-spacings` (and fix corresponding comments), which avoids missing spaces after the leading `//`. Signed-off-by: beorn7 <beorn@grafana.com>		3 months ago
..
README.md	Move packages out of deprecated pkg directory	3 years ago
interface.go	lint: Revamp our linting rules, mostly around doc comments	3 months ago
interface_test.go	model/textparse: parsers take a labels SymbolTable	9 months ago
openmetricslex.l	UTF-8: Add support for parsing UTF8 metric and label names	9 months ago
openmetricslex.l.go	UTF-8: Add support for parsing UTF8 metric and label names	9 months ago
openmetricsparse.go	textparse: Implement `CreatedTimestamp()` in `openmetricsparse.go` (#14356 )	4 months ago
openmetricsparse_test.go	textparse: Implement `CreatedTimestamp()` in `openmetricsparse.go` (#14356 )	4 months ago
promlex.l	UTF-8: Add support for parsing UTF8 metric and label names	9 months ago
promlex.l.go	UTF-8: Add support for parsing UTF8 metric and label names	9 months ago
promparse.go	docs: textparse.Parser return type mismatch	9 months ago
promparse_test.go	textparse: Implement `CreatedTimestamp()` in `openmetricsparse.go` (#14356 )	4 months ago
promtestdata.nometa.txt	Move packages out of deprecated pkg directory	3 years ago
promtestdata.txt	Move packages out of deprecated pkg directory	3 years ago
protobufparse.go	model/textparse: parsers take a labels SymbolTable	9 months ago
protobufparse_test.go	model/textparse: parsers take a labels SymbolTable	9 months ago

README.md

Making changes to textparse lexers

In the rare case that you need to update the textparse lexers, edit promlex.l or openmetricslex.l and then run the following command: golex -o=promlex.l.go promlex.l

Note that you need golex installed: go get -u modernc.org/golex