You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

beorn7 0f760f63dd lint: Revamp our linting rules, mostly around doc comments ... Several things done here: - Set `max-issues-per-linter` to 0 so that we actually see all linter warnings and not just 50 per linter. (As we also set `max-same-issues` to 0, I assume this was the intention from the beginning.) - Stop using the golangci-lint default excludes (by setting `exclude-use-default: false`. Those are too generous and don't match our style conventions. (I have re-added some of the excludes explicitly in this commit. See below.) - Re-add the `errcheck` exclusion we have used so far via the defaults. - Exclude the signature requirement `govet` has for `Seek` methods because we use non-standard `Seek` methods a lot. (But we keep other requirements, while the default excludes completely disabled the check for common method segnatures.) - Exclude warnings about missing doc comments on exported symbols. (We used to be pretty adamant about doc comments, but stopped that at some point in the past. By now, we have about 500 missing doc comments. We may consider reintroducing this check, but that's outside of the scope of this commit. The default excludes of golangci-lint essentially ignore doc comments completely.) - By stop using the default excludes, we now get warnings back on malformed doc comments. That's the most impactful change in this commit. It does not enforce doc comments (again), but _if_ there is a doc comment, it has to have the recommended form. (Most of the changes in this commit are fixing this form.) - Improve wording/spelling of some comments in .golangci.yml, and remove an outdated comment. - Leave `package-comments` inactive, but add a TODO asking if we should change that. - Add a new sub-linter `comment-spacings` (and fix corresponding comments), which avoids missing spaces after the leading `//`. Signed-off-by: beorn7 <beorn@grafana.com>		3 months ago
..
testdata	Fix yaml file format and clear ci errors	8 months ago
analyze.go	Add analyze histograms command to promtool (#12331)	11 months ago
analyze_test.go	Add analyze histograms command to promtool (#12331)	11 months ago
archive.go	Use github.com/klauspost/compress for gzip and zlib	9 months ago
backfill.go	tsdb: Extend compactor interface to allow compactions to create multiple output blocks (#14143)	5 months ago
backfill_test.go	Tests: use replacement DeepEquals using go-cmp	10 months ago
debug.go	refactor (package cmd): move from github.com/pkg/errors to 'errors' and 'fmt' packages (#10733)	3 years ago
main.go	lint: Revamp our linting rules, mostly around doc comments	3 months ago
main_test.go	Enable perfsprint linter and fix up code	6 months ago
metrics.go	lint: Revamp our linting rules, mostly around doc comments	3 months ago
query.go	Add analyze histograms command to promtool (#12331)	11 months ago
rules.go	refactor: utilize standard functions max/min	8 months ago
rules_test.go	golangci-lint: enable whitespace linter (#13905)	8 months ago
sd.go	promtool: use go-cmp instead of DeepEqual	10 months ago
sd_test.go	Tests: use replacement DeepEquals using go-cmp	10 months ago
tsdb.go	Upgrade golangci-lint to v1.60.1	3 months ago
tsdb_test.go	[Tests] Promtool: Sort output where Prometheus does not guarantee the order.	3 months ago
unittest.go	promtool: JUnit-Format XML Test Results (#14506)	4 months ago
unittest_test.go	promtool: JUnit-Format XML Test Results (#14506)	4 months ago