8 Commits (fb69a38e671db03edff09e4d90c0f228251d67bb)

Author	SHA1	Message	Date
beorn7	0f760f63dd	lint: Revamp our linting rules, mostly around doc comments ... Several things done here: - Set `max-issues-per-linter` to 0 so that we actually see all linter warnings and not just 50 per linter. (As we also set `max-same-issues` to 0, I assume this was the intention from the beginning.) - Stop using the golangci-lint default excludes (by setting `exclude-use-default: false`. Those are too generous and don't match our style conventions. (I have re-added some of the excludes explicitly in this commit. See below.) - Re-add the `errcheck` exclusion we have used so far via the defaults. - Exclude the signature requirement `govet` has for `Seek` methods because we use non-standard `Seek` methods a lot. (But we keep other requirements, while the default excludes completely disabled the check for common method segnatures.) - Exclude warnings about missing doc comments on exported symbols. (We used to be pretty adamant about doc comments, but stopped that at some point in the past. By now, we have about 500 missing doc comments. We may consider reintroducing this check, but that's outside of the scope of this commit. The default excludes of golangci-lint essentially ignore doc comments completely.) - By stop using the default excludes, we now get warnings back on malformed doc comments. That's the most impactful change in this commit. It does not enforce doc comments (again), but _if_ there is a doc comment, it has to have the recommended form. (Most of the changes in this commit are fixing this form.) - Improve wording/spelling of some comments in .golangci.yml, and remove an outdated comment. - Leave `package-comments` inactive, but add a TODO asking if we should change that. - Add a new sub-linter `comment-spacings` (and fix corresponding comments), which avoids missing spaces after the leading `//`. Signed-off-by: beorn7 <beorn@grafana.com>	3 months ago
Jayapriya Pai	2d2b440304	fix: correct the typo in azuread sdk auth (#14106) ... Signed-off-by: Jayapriya Pai <janantha@redhat.com>	6 months ago
Jan-Otto Kröpke	302e151de8	{discovery,remote_write}/azure: Support default SDK authentication (#13099) ... * discovery/azure: Offer default SDK authentication Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>	9 months ago
Oleksandr Redko	2a75604f8e	Enable default revive rules (#13068) ... Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>	1 year ago
Oleksandr Redko	fa90ca46e5	ci(lint): enable godot; append dot at the end of comments ... Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>	1 year ago
Oleksandr Redko	8e5f0387a2	ci(lint): enable nolintlint and remove redundant comments (#12926) ... Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>	1 year ago
rakshith210	cdad64002a	Added Azure OAuth support (#12572) ... * Added Azure OAuth support Signed-off-by: rakshith210 <rakshith.me@gmail.com> * Added missing comment Signed-off-by: rakshith210 <rakshith.me@gmail.com> * Addressing comment Signed-off-by: rakshith210 <rakshith.me@gmail.com> * Fixed lint issue Signed-off-by: rakshith210 <rakshith.me@gmail.com> * Fix test Signed-off-by: rakshith210 <rakshith.me@gmail.com> * Addressing comments Signed-off-by: rakshith210 <rakshith.me@gmail.com> * Added documentation and updated unit tests Signed-off-by: rakshith210 <rakshith.me@gmail.com> * Addressing comments Signed-off-by: rakshith210 <rakshith.me@gmail.com> --------- Signed-off-by: rakshith210 <rakshith.me@gmail.com>	1 year ago
rakshith210	b1675e23af	Add Azure AD package for remote write (#11944) ... * Add Azure AD package for remote write * Made AzurePublic default and updated configuration.md * Updated config structure and removed getToken at initialization * Changed passing context from request Signed-off-by: Rakshith Padmanabha <rapadman@microsoft.com> Signed-off-by: rakshith210 <rakshith.me@gmail.com>	2 years ago