prometheus

Commit Graph

Author	SHA1	Message	Date
Bryan Boreham	31c5760551	Neater string vs byte-slice conversions (#14425 ) unsafe.Slice and unsafe.StringData were added in Go 1.20 Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2 months ago
Mario Fernandez	5814920601	Fix: optimize .* regexp performance Shortcut for `.*` matches newlines as well. Add preamble change ^(?s: Add test dotAll flag por al regex Add and fix regex tests Signed-off-by: Mario Fernandez <mariofer@redhat.com>	2 months ago
Owen Williams	9da75328ea	fix(utf8): ensure correct validation when legacy mode turned on (#14736 ) fix(utf8): ensure correct validation when legacy mode turned on This depends on the included update of the prometheus/common dependency. --------- Signed-off-by: Owen Williams <owen.williams@grafana.com>	3 months ago
beorn7	0f760f63dd	lint: Revamp our linting rules, mostly around doc comments Several things done here: - Set `max-issues-per-linter` to 0 so that we actually see all linter warnings and not just 50 per linter. (As we also set `max-same-issues` to 0, I assume this was the intention from the beginning.) - Stop using the golangci-lint default excludes (by setting `exclude-use-default: false`. Those are too generous and don't match our style conventions. (I have re-added some of the excludes explicitly in this commit. See below.) - Re-add the `errcheck` exclusion we have used so far via the defaults. - Exclude the signature requirement `govet` has for `Seek` methods because we use non-standard `Seek` methods a lot. (But we keep other requirements, while the default excludes completely disabled the check for common method segnatures.) - Exclude warnings about missing doc comments on exported symbols. (We used to be pretty adamant about doc comments, but stopped that at some point in the past. By now, we have about 500 missing doc comments. We may consider reintroducing this check, but that's outside of the scope of this commit. The default excludes of golangci-lint essentially ignore doc comments completely.) - By stop using the default excludes, we now get warnings back on malformed doc comments. That's the most impactful change in this commit. It does not enforce doc comments (again), but _if_ there is a doc comment, it has to have the recommended form. (Most of the changes in this commit are fixing this form.) - Improve wording/spelling of some comments in .golangci.yml, and remove an outdated comment. - Leave `package-comments` inactive, but add a TODO asking if we should change that. - Add a new sub-linter `comment-spacings` (and fix corresponding comments), which avoids missing spaces after the leading `//`. Signed-off-by: beorn7 <beorn@grafana.com>	3 months ago
Bryan Boreham	d84282b105	Labels: use single byte as separator - small speedup Since `seps` is a variable, `seps[0]` has to be bounds-checked every time. Replacing with a constant everywhere it is used skips this overhead. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	4 months ago
Bryan Boreham	82a8c6abe2	[ENHANCEMENT] Optimize regexps with multiple prefixes (#13843 ) For example `foo.\|bar.\|baz.`. Instead of checking each one in turn, we build a map of prefixes, then check the smaller set that could match the string supplied. Signed-off-by: Bryan Boreham <bjboreham@gmail.com> Improve testing and readability Address review comments on #13843 Signed-off-by: Marco Pracucci <marco@pracucci.com>	5 months ago
Marco Pracucci	ec31acaf02	FastRegexMatcher: small optimization for the literal prefix case Signed-off-by: Marco Pracucci <marco@pracucci.com>	5 months ago
Bryan Boreham	7a82e4b503	Labels benchmarks: remove artefact of small symbol-tables Symbol tables with fewer than 128 entries, so everything can be represented as a single byte, are not realistic. Stuff the symbol table with fake entries before adding the real ones. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	5 months ago
Bryan Boreham	2ba7bc9446	Labels: further optimisation for dedupelabels Inline (by copy-paste) the fast path of `decodeVarint` in various places where it gets called a lot. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	5 months ago
Bryan Boreham	2ced2f6aec	[PERF] Labels: faster varint for dedupelabels Including tests. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	5 months ago
Bryan Boreham	84602bbace	Merge branch 'main' into fix-matcher-string-with-empty-label-name	5 months ago
Oleg Zaytsev	4f78cc809c	Refactor `toNormalisedLower`: shorter and slightly faster. (#14299 ) Refactor toNormalisedLower: shorter and slightly faster Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	5 months ago
Oleg Zaytsev	03cf6141d4	Fix Matcher.String() with empty label name When the label name is empty, which can happen now with quoted label name, it should be quoted when printed as a string again. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	5 months ago
Ranveer Avhad	39902ba694	[BUGFIX] FastRegexpMatcher: do Unicode normalization as part of case-insensitive comparison (#14170 ) * Converted string to standarized form * Added golang.org/x/text in Go dependencies * Added test cases for FastRegexMatcher * Added benchmark for toNormalizedLower Signed-off-by: RA <ranveeravhad777@gmail.com>	6 months ago
Marco Pracucci	d966ae6400	Optimize containsInOrder() inlining it Signed-off-by: Marco Pracucci <marco@pracucci.com>	6 months ago
Marco Pracucci	a0807733be	Improved tests Signed-off-by: Marco Pracucci <marco@pracucci.com>	6 months ago
Marco Pracucci	78fdd2188d	Improve contains check done by FastRegexMatcher Signed-off-by: Marco Pracucci <marco@pracucci.com>	6 months ago
Bryan Boreham	1e0b0e250a	Merge pull request #14090 from colega/improve-zeroOrOneCharacterStringMatcher-Matches Improve `zeroOrOneCharacterStringMatcher` by using `utf8.DecodeRuneInString`	6 months ago
Oleksandr Redko	f10c3454e9	Enable perfsprint linter and fix up code Signed-off-by: Oleksandr Redko <oleksandr.red+github@gmail.com>	6 months ago
Oleg Zaytsev	8b4c9459a2	Check utf8.RuneError result Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	7 months ago
Oleg Zaytsev	dbe88fae22	Add invalid utf8 test cases to regexp Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	7 months ago
Oleg Zaytsev	bcff5059e6	Use utf8.DecodeRuneInString(s) This replaces the custom `moreThanOneRune` function with the standard `utf8.DecodeRuneInString(s)` that can be used to figure out the size of the first rune. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	7 months ago
Oleg Zaytsev	fdfc6d4725	Benchmark zeroOrOneCharacterStringMatcher.Matches This adds some more test cases for unicode values, and also a benchmark for zeroOrOneCharacterStringMatcher.Matches() Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	7 months ago
Oleg Zaytsev	b7b4355807	Use bytes.Buffer from stack buf in Matcher.String() Also removed the growing until there's a benchmark for that. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	7 months ago
Oleg Zaytsev	6ebda5a7bc	Optimize Matcher.String() Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	7 months ago
Oleg Zaytsev	dabd789fd5	Quote label name in matchers when needed When the label name of a matcher contains non-standard characters, like a dot, or starts with a digit, it should be quoted. If it's not quoted, then `VectorSelector.String()` isn't a valid PromQL. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	7 months ago
Oleg Zaytsev	2524a91591	Fix FastRegexMatcher matching multibyte runes with . (#14059 ) When `zeroOrOneCharacterStringMatcher` wach checking the input string, it assumed that if there are more than one bytes, then there are more than one runes, but that's not necessarily true. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	7 months ago
Matthieu MOREL	d496687c8e	golangci-lint: enable usestdlibvars linter Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	8 months ago
Bryan Boreham	7c28521451	[TESTS] Truncate some long test names, for readability The strings produced by these tests can run to thousands of characters, which makes test logs difficult to read. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
carehabit	a672662073	all: fix some typos (#13863 ) Signed-off-by: carehabit <shenyuting@outlook.com>	8 months ago
Domantas	435f330d0b	[BUGFIX] labels: don't modify original labels in DropMetricName (#13845 ) Restrict the capacity of first argument to `append()` to force an allocation. This is for the slice implementation only. Signed-off-by: Domantas Jadenkus <djadenkus@gmail.com>	8 months ago
Bryan Boreham	48786ad4e8	Use slices insteda of exp/slices Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	080d440bf8	Merge remote-tracking branch 'origin/main' into pr/13461	8 months ago
Oleg Zaytsev	d12e785075	Improve readability As suggested by @bboreham Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	8 months ago
Oleg Zaytsev	9699598952	Improve Labels.Compare performance w/stringlabels I was bored on a train and I spent some amount of time trying to scratch some nanoseconds off the Labels.Compare when running with stringlabels. I would be ashamed to admit the real amount of time I spent on it. The worst thing is, I can't really explain why this is performing so much better, and someone should re-run the benchmarks on their machine to confirm that it's not something related to general relativity because the train is moving. I also added some extra real-life benchmark cases with longer labelsets (these aren't the longest we have in production, but kubernetes labelsets are fairly common in Prometheus so I thought it would be nice to have them). My benchmarks show this diff: goos: darwin goarch: arm64 pkg: github.com/prometheus/prometheus/model/labels │ old │ new │ │ sec/op │ sec/op vs base │ Labels_Compare/equal 5.898n ± 0% 5.875n ± 1% -0.40% (p=0.037 n=10) Labels_Compare/not_equal 11.78n ± 2% 11.01n ± 1% -6.54% (p=0.000 n=10) Labels_Compare/different_sizes 4.959n ± 1% 4.906n ± 2% -1.05% (p=0.050 n=10) Labels_Compare/lots 21.32n ± 0% 17.54n ± 5% -17.75% (p=0.000 n=10) Labels_Compare/real_long_equal 15.06n ± 1% 14.92n ± 0% -0.93% (p=0.000 n=10) Labels_Compare/real_long_different_end 25.20n ± 0% 24.43n ± 0% -3.04% (p=0.000 n=10) geomean 11.86n 11.25n -5.16% Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	8 months ago
Bryan Boreham	0bb5588386	labels: optimize String method (#13673 ) Use a stack buffer to reduce memory allocations. `Write(AppendQuote(AvailableBuffer` does not allocate or copy when the buffer has sufficient space. Also add a benchmark, with some refactoring. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	9 months ago
machine424	f477e0539a	Move from golang.org/x/exp/slices into slices now that we only support Go >= 1.21 Prevent adding back golang.org/x/exp/slices. Signed-off-by: machine424 <ayoubmrini424@gmail.com>	9 months ago
Bryan Boreham	e1a741a0d7	labels: update copyright dates Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	9 months ago
Bryan Boreham	55e7de04f8	model/labels (stringlabels): use strings.Clone Suggestion from @colega. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	9 months ago
Bryan Boreham	d16ce3c9bd	model/labels (dedupelabels): small clarifications Suggestion from @colega. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	9 months ago
Bryan Boreham	b39286fd1f	Add dedupelabels tag to not build regular labels Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	9 months ago
Bryan Boreham	d51a5344cd	labels: new version de-duplicating strings in SymbolTables The individual strings for label names and values are held in a table, and each Labels value is a run of varint-encoded indexes into that table. When creating new labels, a sync.Mutex is locked around reads and writes. When reading labels, there is no locking because the table of strings used by those labels is immutable. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	9 months ago
Bryan Boreham	28191109a8	Labels: add fake versions of SymbolTable apis So we can use them where necessary for internlabels implementation. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	9 months ago
Bryan Boreham	d1af84f6ee	Labels: move Builder and Reset out of common New internstrings implementation is different. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	9 months ago
Bryan Boreham	5aa4473894	labels tests: extend TestBuilder Start with empty base labels, also check new and re-used symbol tables Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	9 months ago
Bryan Boreham	bb82a57e64	Labels: Call NewScratchBuilder in test_utils Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	9 months ago
Bryan Boreham	cc5dc6a61b	labels: use Equal instead of DeepEqual This will work better with a different data structure. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	9 months ago
beorn7	553d92affd	model/labels: Fix new lint warning in test Signed-off-by: beorn7 <beorn@grafana.com>	10 months ago
Bryan Boreham	14b4fbc2ff	labels: make InternStrings a no-op for stringlabels version The current implementation of `InternStrings` will only save memory when the whole set of labels is identical to one already seen, and this cannot happen in the one place it is called from in Prometheus, remote-write, which already detects identical series. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	10 months ago
Marco Pracucci	501bc6419e	Add ShardedPostings() support to TSDB (#10421 ) This PR is a reference implementation of the proposal described in #10420. In addition to what described in #10420, in this PR I've introduced labels.StableHash(). The idea is to offer an hashing function which doesn't change over time, and that's used by query sharding in order to get a stable behaviour over time. The implementation of labels.StableHash() is the hashing function used by Prometheus before stringlabels, and what's used by Grafana Mimir for query sharding (because built before stringlabels was a thing). Follow up work As mentioned in #10420, if this PR is accepted I'm also open to upload another foundamental piece used by Grafana Mimir query sharding to accelerate the query execution: an optional, configurable and fast in-memory cache for the series hashes. Signed-off-by: Marco Pracucci <marco@pracucci.com>	10 months ago

1 2 3

113 Commits (fb69a38e671db03edff09e4d90c0f228251d67bb)