585 Commits (fabcd7e7c6db57ebd5456d7f5239f22cde37ba32)

Author	SHA1	Message	Date
Julien	d1eff95faf	Merge pull request #14100 from bboreham/windows-flake ... [TEST] Rules: Sleep 15ms to fit Windows behaviour better	6 months ago
Oleksandr Redko	f10c3454e9	Enable perfsprint linter and fix up code ... Signed-off-by: Oleksandr Redko <oleksandr.red+github@gmail.com>	6 months ago
Bryan Boreham	10eb23bd6b	[TEST] Rules: Sleep 15ms to fit Windows behaviour better ... On Windows, Go will sleep 15ms if you ask for less. TestAsyncRuleEvaluation compares actual delay to the nominal time, so using 15ms should work better on Windows, and be hardly noticeable elsewhere. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	7 months ago
Bryan Boreham	3fd24d1cd7	Merge pull request #13999 from bboreham/extract-promqltest ... [Test] Extract most PromQL test code into separate packages	7 months ago
Bryan Boreham	8fd96241ab	test: add promqltest package references ... To packages outside of promql. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	7 months ago
gotjosh	c10186eeea	BUGFIX: Mark the rule's restoration process as completed always (#14048) ... * BUGFIX: Mark the rule's restoration process as completed always In https://github.com/prometheus/prometheus/pull/13980 I introduced a change to reduce the number of queries executed when we restore alert statuses. With this, the querying semantics changed as we now need to go through all series before we enter the alert restoration loop and I missed the fact that exiting early when there are no rules to restore would lead to an incomplete restoration. An alert being restored is used as a proxy for "we're now ready to write `ALERTS/ALERTS_FOR_SERIES` metrics" so as a result we weren't writing the series if we didn't restore anything the first time around. --------- Signed-off-by: gotjosh <josue.abreu@gmail.com>	7 months ago
gotjosh	1dd0bff4f1	Merge pull request #13980 from prometheus/gotjosh/restore-only-with-rule-query ... Rule Manager: Only query once per alert rule when restoring alert state	7 months ago
gotjosh	379dec9d36	querier.Select cannot return a nil series set. ... Signed-off-by: gotjosh <josue.abreu@gmail.com>	7 months ago
gotjosh	05ca082b07	Rename `alerts` to `expectedAlerts` in the test case input ... Signed-off-by: gotjosh <josue.abreu@gmail.com>	7 months ago
gotjosh	f63dbc3db2	Remove duplicated sorted and assignment of expected alerts. ... Signed-off-by: gotjosh <josue.abreu@gmail.com>	7 months ago
gotjosh	63b09944b8	Use labels.Len() instead of manually counting the labels ... Signed-off-by: gotjosh <josue.abreu@gmail.com>	7 months ago
gotjosh	ccfafae36d	Rename QueryforStateSeries to QueryForStateSeries ... Signed-off-by: gotjosh <josue.abreu@gmail.com>	7 months ago
gotjosh	151f6e0ed6	Add an assertion on the count of alerts before adding an active alert ... Signed-off-by: gotjosh <josue.abreu@gmail.com>	7 months ago
George Robinson	dde2e5eb73	Improve comments around resending resolved alerts (#13990) ... Signed-off-by: George Robinson <george.robinson@grafana.com>	7 months ago
gotjosh	cc2207148e	fix typo ... Signed-off-by: gotjosh <josue.abreu@gmail.com>	7 months ago
gotjosh	2de2fee035	Allow the result map for the series set before hand with a hint. ... Signed-off-by: gotjosh <josue.abreu@gmail.com>	7 months ago
gotjosh	6cfc584308	- Add a changelog entry ... - Improve variable name of the map produced by the series set Signed-off-by: gotjosh <josue.abreu@gmail.com>	7 months ago
gotjosh	fa75985c1c	Use the string representation of the labels instead of the hash ... Signed-off-by: gotjosh <josue.abreu@gmail.com>	7 months ago
gotjosh	276201598c	Fix tests and a bug with the series lookup logic. ... Signed-off-by: gotjosh <josue.abreu@gmail.com>	7 months ago
gotjosh	e6dcbd2e26	bug: nil check against the series set not errors ... Signed-off-by: gotjosh <josue.abreu@gmail.com>	7 months ago
gotjosh	4daaa59c08	Rule Manager: Only query once per alert rule when restoring alert state ... Prometheus restores alert state between restarts and updates. For each rule, it looks at the alerts that are meant to be active and then queries the `ALERTS_FOR_STATE` series for _each_ alert within the rules. If the alert rule has 120 instances (or series) it'll execute the same query with slightly different labels. This PR changes the approach so that we only query once per alert rule and then match the corresponding alert that we're about to restore against the series-set. While the approach might use a bit more memory at start-up (if even?) the restore proccess is only ran once per restart so I'd consider this a big win. This builds on top of #13974 Signed-off-by: gotjosh <josue.abreu@gmail.com>	7 months ago
gotjosh	5beb2fe005	Improve the metric description ... Signed-off-by: gotjosh <josue.abreu@gmail.com>	7 months ago
gotjosh	381a77ac1e	Change variable name to `restoreStartTime` from `now` and introduce a log line to record total time ... Signed-off-by: gotjosh <josue.abreu@gmail.com>	7 months ago
gotjosh	e7219e3d36	Rule Manager: Add `rule_group_last_restore_duration_seconds` to measure restore time per rule group ... When a rule group changes or prometheus is restarted we need to ensure we restore the active alerts that were firing for a corresponding rule, for that Prometheus uses the `ALERTS_FOR_STATE` series to query the previous state and restore it. If a given rule has high cardinality (think 100s of 1000s for series) this proccess can take a bit of time - this is the first of a series of PRs to improve this problem and I'd like to start with exposing the time it takes to restore a rule group as a gauge. Signed-off-by: gotjosh <josue.abreu@gmail.com>	7 months ago
Björn Rabenstein	4ec5c25393	Merge pull request #13731 from suntala/suntala/native-histogram-template ... histograms: support expansion of native histogram values in templating	8 months ago
Matthieu MOREL	6f595c6762	golangci-lint: enable whitespace linter (#13905) ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	8 months ago
suntala	44f385fd51	Support expansion of native histogram values in alert templates ... Co-authored-by: Aleks Fazlieva <britishrum@users.noreply.github.com> Signed-off-by: suntala <arati.rana@grafana.com>	8 months ago
Łukasz Mierzwa	3bb27c33e9	Use consistent keys for logs ... Rule warnings are logged with numDropped=N while every other component uses num_dropped=N: ``` notifier/notifier.go: level.Warn(n.logger).Log("msg", "Alert batch larger than queue capacity, dropping alerts", "num_dropped", d) notifier/notifier.go: level.Warn(n.logger).Log("msg", "Alert notification queue full, dropping alerts", "num_dropped", d) storage/remote/write_handler.go: _ = level.Warn(h.logger).Log("msg", "Error on ingesting out-of-order exemplars", "num_dropped", outOfOrderExemplarErrs) rules/group.go: level.Warn(logger).Log("msg", "Error on ingesting out-of-order result from rule evaluation", "num_dropped", numOutOfOrder) rules/group.go: level.Warn(logger).Log("msg", "Error on ingesting too old result from rule evaluation", "num_dropped", numTooOld) rules/group.go: level.Warn(logger).Log("msg", "Error on ingesting results from rule evaluation with different value but same timestamp", "num_dropped", numDuplicates) scrape/scrape.go: level.Warn(sl.l).Log("msg", "Error on ingesting out-of-order samples", "num_dropped", appErrs.numOutOfOrder) scrape/scrape.go: level.Warn(sl.l).Log("msg", "Error on ingesting samples with different value but same timestamp", "num_dropped", appErrs.numDuplicates) scrape/scrape.go: level.Warn(sl.l).Log("msg", "Error on ingesting samples that are too old or are too far into the future", "num_dropped", appErrs.numOutOfBounds) scrape/scrape.go: level.Warn(sl.l).Log("msg", "Error on ingesting out-of-order exemplars", "num_dropped", appErrs.numExemplarOutOfOrder) ``` Rename numDropped to num_dropped for consistency. Signed-off-by: Łukasz Mierzwa <l.mierzwa@gmail.com>	8 months ago
Charles Korn	4e77e8e5ef	Allow using alternative PromQL engines for rule evaluation ... Signed-off-by: Charles Korn <charles.korn@grafana.com>	9 months ago
machine424	f477e0539a	Move from golang.org/x/exp/slices into slices now that we only support Go >= 1.21 ... Prevent adding back golang.org/x/exp/slices. Signed-off-by: machine424 <ayoubmrini424@gmail.com>	9 months ago
Bryan Boreham	3716326f3f	rules: call NewScratchBuilder ... Need to initialize ScratchBuilder with a SymbolTable. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	9 months ago
Bryan Boreham	c0e36e6bb3	Standardise exemplar label as "trace_id" ... This is consistent with the OpenTelemetry standard, and an example in OpenMetrics. https://github.com/open-telemetry/opentelemetry-specification/blob/89aa01348139/specification/metrics/data-model.md#exemplars https://github.com/OpenObservability/OpenMetrics/blob/138654493130/specification/OpenMetrics.md#exemplars-1 Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	9 months ago
Bryan Boreham	17f48f2b3b	Tests: use replacement DeepEquals in more places ... Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	10 months ago
Bryan Boreham	39af788dbd	Tests: use replacement DeepEquals using go-cmp ... Use DeepEqual replacement using go-cmp, which is more flexible. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	10 months ago
Marco Pracucci	5ee3fbe825	Decouple ruler dependency controller from concurrency controller ... Signed-off-by: Marco Pracucci <marco@pracucci.com>	10 months ago
Marco Pracucci	cbbbd6e70a	Remove superfluous nil check in Group.metrics ... Signed-off-by: Marco Pracucci <marco@pracucci.com>	10 months ago
Marco Pracucci	046cd7599f	Introduced sequentialRuleEvalController ... Signed-off-by: Marco Pracucci <marco@pracucci.com>	10 months ago
Marco Pracucci	23f89c18b2	Improved RuleConcurrencyController interface doc ... Signed-off-by: Marco Pracucci <marco@pracucci.com>	10 months ago
Marco Pracucci	2764c46531	Added more test cases to TestDependenciesEdgeCases ... Signed-off-by: Marco Pracucci <marco@pracucci.com>	10 months ago
Marco Pracucci	52bc568d04	Add more test cases to TestDependenciesEdgeCases ... Signed-off-by: Marco Pracucci <marco@pracucci.com>	10 months ago
Marco Pracucci	21a03dc018	Simplify the design to update concurrency controller once the rule evaluation has done ... Signed-off-by: Marco Pracucci <marco@pracucci.com>	10 months ago
Danny Kopping	7aa3b10c3f	Block until all rules, both sync & async, have completed evaluating ... Updated & added tests Review feedback nits Return empty map if not indeterminate Use highWatermark to track inflight requests counter Appease the linter Clarify feature flag Signed-off-by: Danny Kopping <danny.kopping@grafana.com>	10 months ago
Danny Kopping	f922534c4d	Refactoring for performance, and to allow controller to be overridden ... Signed-off-by: Danny Kopping <danny.kopping@grafana.com>	10 months ago
Danny Kopping	94cdfa30cd	Refactoring ... Signed-off-by: Danny Kopping <danny.kopping@grafana.com>	10 months ago
Danny Kopping	0dc7036db3	Optimising dependencies/dependents funcs to not produce new slices each request ... Signed-off-by: Danny Kopping <danny.kopping@grafana.com>	10 months ago
Danny Kopping	e7758d187e	Refactor concurrency control ... Signed-off-by: Danny Kopping <danny.kopping@grafana.com>	10 months ago
Danny Kopping	940f83a540	Implementation ... NOTE: Rebased from main after refactor in #13014 Signed-off-by: Danny Kopping <danny.kopping@grafana.com>	10 months ago
Filip Petkovski	583f3e587c	Optimize histogram iterators (#13340) ... Optimize histogram iterators Histogram iterators allocate new objects in the AtHistogram and AtFloatHistogram methods, which makes calculating rates over long ranges expensive. In #13215 we allowed an existing object to be reused when converting an integer histogram to a float histogram. This commit follows the same idea and allows injecting an existing object in the AtHistogram and AtFloatHistogram methods. When the injected value is nil, iterators allocate new histograms, otherwise they populate and return the injected object. The commit also adds a CopyTo method to Histogram and FloatHistogram which is used in the BufferedIterator to overwrite items in the ring instead of making new copies. Note that a specialized HPoint pool is needed for all of this to work (`matrixSelectorHPool`). --------- Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>	10 months ago
Filip Petkovski	10a82f87fd	Enable reusing memory when converting between histogram types ... The 'ToFloat' method on integer histograms currently allocates new memory each time it is called. This commit adds an optional *FloatHistogram parameter that can be used to reuse span and bucket slices. It is up to the caller to make sure the input float histogram is not used anymore after the call. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>	12 months ago
Matthieu MOREL	9c4782f1cc	golangci-lint: enable testifylint linter (#13254) ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	12 months ago