Thomas Jackson
a6dace8829
Check for timeout in each iteration of matrixSelector ( #4300 )
...
Signed-off-by: Thomas Jackson <jacksontj.89@gmail.com>
Fixes #4288
7 years ago
Michael Khalil
78e0784d04
return error exit status in prometheus cli ( #4296 )
...
Signed-off-by: mikeykhalil <mikeyfkhalil@gmail.com>
7 years ago
Thomas Jackson
630f42fcf1
Timeout if populating iterators takes too long ( #4291 )
...
Right now promql won't time out a request if populating the iterators
takes a long time.
Signed-off-by: Thomas Jackson <jacksontj.89@gmail.com>
Fixes #4289
7 years ago
Brian Brazil
fb695fb435
Merge pull request #4285 from prometheus/release-2.3
...
Merge release-2.3 back to master
7 years ago
Brian Brazil
188ca45bd8
Merge pull request #4284 from prometheus/231
...
Release 2.3.1
7 years ago
Brian Brazil
141799da6e
Release 2.3.1
...
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
7 years ago
Tom Wilkie
4e4f0d4e41
spelling.
...
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
7 years ago
Tom Wilkie
b8217720ac
Review feedback.
...
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
7 years ago
Tom Wilkie
e518f51a99
Extend API tests to cover remote read API.
...
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
7 years ago
Corentin Chary
db9dbeeaec
federation: nil pointer deference when using remove read
...
```
level=error ts=2018-06-13T07:19:04.515149169Z caller=stdlib.go:89 component=web caller="http: panic serving [::1" msg="]:56202: runtime error: invalid memory address or nil pointer dereference"
level=error ts=2018-06-13T07:19:04.516199547Z caller=stdlib.go:89 component=web caller="http: panic serving [::1" msg="]:56204: runtime error: invalid memory address or nil pointer dereference"
level=error ts=2018-06-13T07:19:04.51717692Z caller=stdlib.go:89 component=web caller="http: panic serving [::1" msg="]:56206: runtime error: invalid memory address or nil pointer dereference"
level=error ts=2018-06-13T07:19:04.564952878Z caller=stdlib.go:89 component=web caller="http: panic serving [::1" msg="]:56208: runtime error: invalid memory address or nil pointer dereference"
level=error ts=2018-06-13T07:19:04.566575791Z caller=stdlib.go:89 component=web caller="http: panic serving [::1" msg="]:56210: runtime error: invalid memory address or nil pointer dereference"
level=error ts=2018-06-13T07:19:04.567106063Z caller=stdlib.go:89 component=web caller="http: panic serving [::1" msg="]:56212: runtime error: invalid memory address or nil pointer dereference"
```
When remove read is enabled, federation will call `q.Select(nil, mset...)`
which will break remote reads because it currently doesn't handle empty
SelectParams.
Signed-off-by: Corentin Chary <c.chary@criteo.com>
7 years ago
Simon Pasquier
dacb6c530a
discovery/file: fix logging ( #4178 )
...
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
7 years ago
Paul Gier
5c70213f9f
config: set target group source index during unmarshalling ( #4245 )
...
* config: set target group source index during unmarshalling
Fixes issue #4214 where the scrape pool is unnecessarily reloaded for a
config reload where the config hasn't changed. Previously, the discovery
manager changed the static config after loading which caused the in-memory
config to differ from a freshly reloaded config.
Signed-off-by: Paul Gier <pgier@redhat.com>
* [issue #4214 ] Test that static targets are not modified by discovery manager
Signed-off-by: Paul Gier <pgier@redhat.com>
7 years ago
Tom Wilkie
47809cae01
Merge pull request #4282 from prometheus/4263-remote
...
remote read: nil pointer deference when using remove read
7 years ago
Brian Brazil
78efdc6d6b
Avoid infinite loop on duplicate NaN values. ( #4275 )
...
Fixes #4254
NaNs don't equal themselves, so a duplicate NaN would
always hit the break statement and never get popped.
We should not be returning multiple data point for the same
timestamp, so don't compare values at all.
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
7 years ago
Tom Wilkie
fcc3f43acd
spelling.
...
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
7 years ago
Tom Wilkie
0b189b2da9
Review feedback.
...
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
7 years ago
Tom Wilkie
ae29512444
Extend API tests to cover remote read API.
...
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
7 years ago
Corentin Chary
530107f8ef
federation: nil pointer deference when using remove read
...
```
level=error ts=2018-06-13T07:19:04.515149169Z caller=stdlib.go:89 component=web caller="http: panic serving [::1" msg="]:56202: runtime error: invalid memory address or nil pointer dereference"
level=error ts=2018-06-13T07:19:04.516199547Z caller=stdlib.go:89 component=web caller="http: panic serving [::1" msg="]:56204: runtime error: invalid memory address or nil pointer dereference"
level=error ts=2018-06-13T07:19:04.51717692Z caller=stdlib.go:89 component=web caller="http: panic serving [::1" msg="]:56206: runtime error: invalid memory address or nil pointer dereference"
level=error ts=2018-06-13T07:19:04.564952878Z caller=stdlib.go:89 component=web caller="http: panic serving [::1" msg="]:56208: runtime error: invalid memory address or nil pointer dereference"
level=error ts=2018-06-13T07:19:04.566575791Z caller=stdlib.go:89 component=web caller="http: panic serving [::1" msg="]:56210: runtime error: invalid memory address or nil pointer dereference"
level=error ts=2018-06-13T07:19:04.567106063Z caller=stdlib.go:89 component=web caller="http: panic serving [::1" msg="]:56212: runtime error: invalid memory address or nil pointer dereference"
```
When remove read is enabled, federation will call `q.Select(nil, mset...)`
which will break remote reads because it currently doesn't handle empty
SelectParams.
Signed-off-by: Corentin Chary <c.chary@criteo.com>
7 years ago
Callum Styan
d0ee4da932
fix minor issues in custom SD example ( #4278 )
...
Signed-off-by: Callum Styan <callumstyan@gmail.com>
7 years ago
Simon Pasquier
6eab4bbca1
kubernetes_sd: fix namespace filtering ( #4273 )
...
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
7 years ago
Fabian Reinartz
e7cfc7dae5
web: restore old path prefix behavior
...
Signed-off-by: Fabian Reinartz <freinartz@google.com>
7 years ago
Simon Pasquier
8cd59da857
kubernetes_sd: fix namespace filtering ( #4273 )
...
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
7 years ago
Alin Sinpalean
91ce63a140
Log the line when failing a PromQL test. ( #4272 )
...
Signed-off-by: Alin Sinpalean <alin.sinpalean@gmail.com>
7 years ago
Paul Gier
d24d2acd11
config: set target group source index during unmarshalling ( #4245 )
...
* config: set target group source index during unmarshalling
Fixes issue #4214 where the scrape pool is unnecessarily reloaded for a
config reload where the config hasn't changed. Previously, the discovery
manager changed the static config after loading which caused the in-memory
config to differ from a freshly reloaded config.
Signed-off-by: Paul Gier <pgier@redhat.com>
* [issue #4214 ] Test that static targets are not modified by discovery manager
Signed-off-by: Paul Gier <pgier@redhat.com>
7 years ago
Frederic Branczyk
f77b65d430
Merge pull request #4259 from prometheus/rmsecheaders
...
web: remove security headers
7 years ago
Fabian Reinartz
97767eb581
Merge pull request #4256 from prometheus/routeprefix
...
web: restore old path prefix behavior
7 years ago
Fabian Reinartz
7a74689973
Merge pull request #4258 from prometheus/rmsecheaders
...
web: remove security headers
7 years ago
Fabian Reinartz
8a4bda8d57
web: remove security headers
...
Signed-off-by: Fabian Reinartz <freinartz@google.com>
7 years ago
Fabian Reinartz
4d675e2aa8
web: restore old path prefix behavior
...
Signed-off-by: Fabian Reinartz <freinartz@google.com>
7 years ago
Simon Pasquier
0e5e7f75cd
discovery/file: fix logging ( #4178 )
...
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
7 years ago
Henri DF
a3ddde0800
Add prompb/README ( #4222 )
...
Signed-off-by: Henri DF <henridf@gmail.com>
7 years ago
Simon Pasquier
45b8dea320
Makefile: update .PHONY target ( #4234 )
...
Makefile: update .PHONY target
* Move .PHONY declarations near their targets
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
7 years ago
Brian Brazil
25e2d9f152
Update example console template for node exporter 0.16.0 ( #4208 )
...
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
7 years ago
Andreas Auernhammer
37d1bcf495
limit size of POST requests against remote read endpoint ( #4239 )
...
This commit fixes a denial-of-service issue of the remote
read endpoint. It limits the size of the POST request body
to 32 MB such that clients cannot write arbitrary amounts
of data to the server memory.
Fixes #4238
Signed-off-by: Andreas Auernhammer <aead@mail.de>
7 years ago
Fabian Reinartz
32223e1dfb
Merge pull request #4237 from prometheus/release-2.3
...
Release 2.3
7 years ago
Thomas Jackson
404abe0f1c
Bubble up errors to promql from populating iterators ( #4136 )
...
This changes the Walk/Inspect API inside the promql package to bubble
up errors. This is done by having the inspector return an error (instead
of a bool) and then bubbling that up in the Walk. This way if any error
is encountered in the Walk() the walk will stop and return the error.
This avoids issues where errors from the Querier where being ignored
(causing incorrect promql evaluation).
Signed-off-by: Thomas Jackson <jacksontj.89@gmail.com>
Fixes #4136
7 years ago
Fabian Reinartz
04b12703f2
Update changelog
...
Signed-off-by: Fabian Reinartz <freinartz@google.com>
7 years ago
Mario Trangoni
0e2aa35771
promql: fix unconvert issues ( #4040 )
...
See,
$ gometalinter --vendor --disable-all --enable=unconvert --deadline 6m ./...
promql/engine.go:1396:26⚠️ unnecessary conversion (unconvert)
promql/engine.go:1396:40⚠️ unnecessary conversion (unconvert)
promql/engine.go:1398:26⚠️ unnecessary conversion (unconvert)
promql/engine.go:1398:40⚠️ unnecessary conversion (unconvert)
promql/engine.go:1427:26⚠️ unnecessary conversion (unconvert)
promql/engine.go:1427:40⚠️ unnecessary conversion (unconvert)
promql/engine.go:1429:26⚠️ unnecessary conversion (unconvert)
promql/engine.go:1429:40⚠️ unnecessary conversion (unconvert)
promql/engine.go:1505:50⚠️ unnecessary conversion (unconvert)
promql/engine.go:1573:46⚠️ unnecessary conversion (unconvert)
promql/engine.go:1578:46⚠️ unnecessary conversion (unconvert)
promql/engine.go:1591:80⚠️ unnecessary conversion (unconvert)
promql/engine.go:1602:94⚠️ unnecessary conversion (unconvert)
promql/engine.go:1630:18⚠️ unnecessary conversion (unconvert)
promql/engine.go:1631:24⚠️ unnecessary conversion (unconvert)
promql/engine.go:1634:18⚠️ unnecessary conversion (unconvert)
promql/engine.go:1635:34⚠️ unnecessary conversion (unconvert)
promql/functions.go:302:42⚠️ unnecessary conversion (unconvert)
promql/functions.go:315:42⚠️ unnecessary conversion (unconvert)
promql/functions.go:334:26⚠️ unnecessary conversion (unconvert)
promql/functions.go:395:31⚠️ unnecessary conversion (unconvert)
promql/functions.go:406:31⚠️ unnecessary conversion (unconvert)
promql/functions.go:454:27⚠️ unnecessary conversion (unconvert)
promql/functions.go:701:46⚠️ unnecessary conversion (unconvert)
promql/functions.go:701:78⚠️ unnecessary conversion (unconvert)
promql/functions.go:730:43⚠️ unnecessary conversion (unconvert)
promql/functions.go:1220:23⚠️ unnecessary conversion (unconvert)
promql/functions.go:1249:23⚠️ unnecessary conversion (unconvert)
promql/quantile.go:107:54⚠️ unnecessary conversion (unconvert)
promql/quantile.go:182:16⚠️ unnecessary conversion (unconvert)
promql/quantile.go:182:64⚠️ unnecessary conversion (unconvert)
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
7 years ago
Fabian Reinartz
e4bb42208f
Merge pull request #4183 from prometheus/metastore
...
scrape,api: provide per-target metric metadata
7 years ago
Fabian Reinartz
057a5ae2b1
Address comments
...
Signed-off-by: Fabian Reinartz <freinartz@google.com>
7 years ago
Fabian Reinartz
0ff42e754e
pkg/textparse: unescape help string
...
Signed-off-by: Fabian Reinartz <freinartz@google.com>
7 years ago
Fabian Reinartz
ad4c33c1ff
scrape,api: provide per-target metric metadata
...
This adds a per-target cache of scraped metadata. The metadata is only
available for the lifecycle of the attached target. An API endpoint allows
to select metadata by metric name and a label selection of targets.
Signed-off-by: Fabian Reinartz <freinartz@google.com>
7 years ago
Fabian Reinartz
290d71791a
*: cut v2.3.0
...
Signed-off-by: Fabian Reinartz <freinartz@google.com>
7 years ago
Fabian Reinartz
0e7112330e
Merge pull request #4162 from prometheus/scrapemeta
...
pkg/textparse: refactor and add metadata handling
7 years ago
Fabian Reinartz
37dc0adcbd
Merge pull request #4217 from prometheus/update
...
Update TSDB and merge release-2.2
7 years ago
Fabian Reinartz
32324f79c7
vendour: update prometheus/tsdb
...
Signed-off-by: Fabian Reinartz <freinartz@google.com>
7 years ago
Fabian Reinartz
9c83e815d1
Merge branch 'release-2.2' into update
7 years ago
Simon Pasquier
097439b0f9
web: limit the number of dropped targets ( #4212 )
...
Displaying all the dropped targets in the service-discovery page hurts
the Prometheus server as well as the browser when thousands of dropped
targets exist. This change limits this number to 1,000 and display the
number of active/total targets per scrape configuration.
Add warning when more than 100 targets are dropped
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
7 years ago
Fabian Reinartz
5fcc5b6028
pkg/textparse: support null bytes in comments and help
...
Signed-off-by: Fabian Reinartz <freinartz@google.com>
7 years ago
Fabian Reinartz
fe80dddbc4
Merge pull request #4210 from bboreham/log-remote-name
...
Add queue name to logger for remote writes
7 years ago