prometheus

Commit Graph

Author	SHA1	Message	Date
Charles Korn	2dd07fbb1b	notifier: optionally drain queued notifications before shutting down (#14290 ) * Add draining of queued notifications to `notifier.Manager` Signed-off-by: Charles Korn <charles.korn@grafana.com> * Update docs Signed-off-by: Charles Korn <charles.korn@grafana.com> * Address PR feedback Signed-off-by: Charles Korn <charles.korn@grafana.com> * Add more logging Signed-off-by: Charles Korn <charles.korn@grafana.com> * Address offline feedback: remove timeout Signed-off-by: Charles Korn <charles.korn@grafana.com> * Ensure stopping takes priority over further processing, make tests more robust Signed-off-by: Charles Korn <charles.korn@grafana.com> * Make channel unbuffered Signed-off-by: Charles Korn <charles.korn@grafana.com> * Update docs Signed-off-by: Charles Korn <charles.korn@grafana.com> * Fix race in test Signed-off-by: Charles Korn <charles.korn@grafana.com> * Remove unnecessary context Signed-off-by: Charles Korn <charles.korn@grafana.com> * Make Stop safe to call multiple times Signed-off-by: Charles Korn <charles.korn@grafana.com> --------- Signed-off-by: Charles Korn <charles.korn@grafana.com>	5 months ago
Bryan Boreham	f24ce00320	Merge pull request #13434 from bboreham/elide-queriers storage: don't wrap single querier in merge-queriers	5 months ago
Arve Knudsen	1abeebacb8	Merge pull request #14340 from aknuds1/arve/fix-lint Upgrade to golangci-lint v1.59.1, fix errors	5 months ago
Daniel Mellado	1b5f65002a	Bump go-retryablehttp to fix basic auth creds leak This PR updates go-retryablehttp to version 0.7.7, even if it's used as an indirect import. Versions previous to that can didn't sanitize urls, discussed at HDCSEC-2024-12 [1] [1] https://discuss.hashicorp.com/t/hcsec-2024-12-go-retryablehttp-can-leak-basic-auth-credentials-to-log-files/68027 Signed-off-by: Daniel Mellado <dmellado@redhat.com>	5 months ago
Jan-Otto Kröpke	99355443c7	remote write handler: reject samples with future timestamps (#14304 ) * fix(remote_write): reject samples with future timestamps * increase check to +10 minutes to allow for clock drift --------- Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de> Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de> Co-authored-by: Bryan Boreham <bjboreham@gmail.com>	5 months ago
Bryan Boreham	348f7f8d0c	Merge pull request #14341 from charleskorn/charleskorn/cleanup-pending-read Fix issue where pending OOO read can be left dangling if creating querier fails	5 months ago
Ben Ye	246b7c6a5c	TSDB: Change block populator to accept postings index function (#14213 ) Signed-off-by: Ben Ye <benye@amazon.com>	5 months ago
Ben Ye	5585a3c7e5	tsdb: expose hook to customize block querier (#14114 ) * expose hook for block querier Signed-off-by: Ben Ye <benye@amazon.com> * update comment Signed-off-by: Ben Ye <benye@amazon.com> * use defined type Signed-off-by: Ben Ye <benye@amazon.com> --------- Signed-off-by: Ben Ye <benye@amazon.com>	5 months ago
Charles Korn	2c5e88748e	Fix issue where pending OOO read can be left dangling if creating querier fails Signed-off-by: Charles Korn <charles.korn@grafana.com>	5 months ago
Arve Knudsen	0395b04419	golangci-lint: Upgrade to v1.59.1 Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 months ago
Arve Knudsen	d902116b41	Fix various linting errors Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 months ago
Bryan Boreham	6030407d25	Merge branch 'main' into elide-queriers Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	5 months ago
Bryan Boreham	b6aba4ff14	Merge pull request #14074 from bboreham/kahan-sum-sum [ENHANCEMENT] PromQL: use Kahan summation for sum()	5 months ago
György Krajcsovits	505ffd34ef	Fix lint error Some weird formatting issue in using comment suggestion Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	5 months ago
George Krajcsovits	f45709e710	Update model/histogram/histogram_test.go Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com>	5 months ago
Martin Chodur	00b110c65c	Fix data corruption in remote write if max_sample_age is applied (#14078 ) * fix: try to reproduce the bug from https://github.com/prometheus/prometheus/issues/13979 in a test case Signed-off-by: David Vavra <sevenood@gmail.com> * fix: data corruption in remote write if max_sample_age is applied Signed-off-by: David Vavra <sevenood@gmail.com> * add benchmark for buildTimeSeries which does the filtering Signed-off-by: Callum Styan <callumstyan@gmail.com> --------- Signed-off-by: David Vavra <sevenood@gmail.com> Signed-off-by: Callum Styan <callumstyan@gmail.com> Co-authored-by: David Vavra <sevenood@gmail.com> Co-authored-by: Callum Styan <callumstyan@gmail.com>	5 months ago
Bryan Boreham	7a82e4b503	Labels benchmarks: remove artefact of small symbol-tables Symbol tables with fewer than 128 entries, so everything can be represented as a single byte, are not realistic. Stuff the symbol table with fake entries before adding the real ones. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	5 months ago
Bryan Boreham	2ba7bc9446	Labels: further optimisation for dedupelabels Inline (by copy-paste) the fast path of `decodeVarint` in various places where it gets called a lot. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	5 months ago
unknown	0d25931049	rebase main and adjust the configuration Signed-off-by: ouyang1204@gmail.com <ouyang1204@gmail.com>	5 months ago
Bryan Boreham	2ced2f6aec	[PERF] Labels: faster varint for dedupelabels Including tests. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	5 months ago
Piotr	d78253319d	queue_manager: add histogram info to error logs (#14326 ) Signed-off-by: Piotr Gwizdala <17101802+thampiotr@users.noreply.github.com>	5 months ago
Łukasz Mierzwa	dbd29df5df	Fix @goyacc invocation (#14324 ) goyacc is installed using 'install-goyacc' and ends up in GOPATH/bin. GOPATH isn't usually part of standard PATH, so when make tries to run goyacc it fails, unless PATH includes GOPATH/bin. Other Go tools, like golangci-lint, are also installed via go install into GOPATH/bin but they run correctly because make invocations for them use FIRST_GOPATH viriable to use full path. Call goyacc using FIRST_GOPATH/bin as well so it works without GOPATH being included in PATH. Signed-off-by: Lukasz Mierzwa <lukasz@cloudflare.com>	5 months ago
🌲 Harry 🌊 John 🏔	d5f6887294	Pass limit param as hint to storage.Querier Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>	5 months ago
George Krajcsovits	a3d92dd72f	Merge pull request #14292 from zenador/nhcb-review-2 [nhcb branch] update missed suggested change from code review	5 months ago
Jeanette Tan	dda5f48c9e	Merge branch 'main' into nhcb-review-2	5 months ago
Jeanette Tan	fc9dc72028	remove eval_with_nhcb Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	5 months ago
Jeanette Tan	a6d788b1be	update missed suggested change from code review Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	5 months ago
akunszt	2aaf99dd0a	discovery: aws: expose Primary IPv6 addresses as label, partially fixes #7406 (#14156 ) * discovery: aws: expose Primary IPv6 addresses as label Add __meta_ec2_primary_ipv6_addresses label. This label contains the Primary IPv6 address for every ENI attached to the EC2 instance. It is ordered by the DeviceIndex and the missing elements (interface without Primary IPv6 address) are kept in the list. --------- Signed-off-by: Arpad Kunszt <akunszt@hiya.com> Co-authored-by: Ayoub Mrini <ayoubmrini424@gmail.com>	5 months ago
George Krajcsovits	c25d6d8ac6	Merge pull request #14316 from pracucci/export-labelsToLabelsProto Export remote.LabelsToLabelsProto() and remote.LabelProtosToLabels()	5 months ago
Marco Pracucci	b6dc9c1817	Merge branch 'main' into export-labelsToLabelsProto	5 months ago
machine424	f9ca6c4ae6	chore: add an alert based on the metric prometheus_sd_kubernetes_failures_total that was introcued in https://github.com/prometheus/prometheus/pull/13554 The same motivation for adding the metric applies: To avoid silent SD failures, as existing logs may not be regularly checked and can be missed. Signed-off-by: machine424 <ayoubmrini424@gmail.com> Co-authored-by: Simon Pasquier <spasquie@redhat.com>	5 months ago
Marco Pracucci	35564c0cb0	Export remote.LabelsToLabelsProto() and remote.LabelProtosToLabels() Signed-off-by: Marco Pracucci <marco@pracucci.com>	5 months ago
Bryan Boreham	5c417684f8	Merge pull request #14296 from colega/fix-matcher-string-with-empty-label-name Fix `Matcher.String()` with empty label name	5 months ago
Bryan Boreham	6685cbc234	Merge branch 'main' into fix-matcher-string-with-empty-label-name	5 months ago
Arve Knudsen	f45b0fd9ef	Merge pull request #14311 from aknuds1/arve/loggercheck golangci-lint: Enable loggercheck linter	5 months ago
Bryan Boreham	84602bbace	Merge branch 'main' into fix-matcher-string-with-empty-label-name	5 months ago
Bryan Boreham	5a1886d247	Merge branch 'main' into arve/loggercheck	5 months ago
George Krajcsovits	9a8b6c52ca	Merge pull request #14313 from prometheus/merge-2.53-to-main Merge 2.53 to main	5 months ago
György Krajcsovits	fcabffb999	Merge branch 'release-2.53' into merge-2.53-to-main	5 months ago
machine424	70beda092a	fix(notifier): take alertmanagerSet.mtx before checking alertmanagerSet.ams in sendAll Signed-off-by: machine424 <ayoubmrini424@gmail.com>	5 months ago
machine424	690de487e2	chore(notifier): Split 'Run()' into two goroutines: one to receive target updates and trigger reloads and the other one to send notifications. This is done to prevent the latter operation from blocking/starving the former, as previously, the `tsets` channel was consumed by the same goroutine that consumes and feeds the buffered `n.more` channel, the `tsets` channel was less likely to be ready as it's unbuffered and only fed every `SDManager.updatert` seconds. See https://github.com/prometheus/prometheus/issues/13676 and https://github.com/prometheus/prometheus/issues/8768 The synchronization with the sendLoop goroutine is managed through the n.mtx mutex. This uses a similar approach than scrape manager's `efbd6e41c5/scrape/manager.go (L115-L117)` The old TestHangingNotifier was replaced by the new one to more closely reflect reality. Signed-off-by: machine424 <ayoubmrini424@gmail.com>	5 months ago
machine424	94d28cd6cf	chore(notifier): add a reproducer for https://github.com/prometheus/prometheus/issues/13676 to show "targets groups update" starvation when the notifications queue is full and an Alertmanager is down. The existing `TestHangingNotifier` that was added in https://github.com/prometheus/prometheus/pull/10948 doesn't really reflect the reality as the SD changes are manually fed into `syncCh` in a continuous way, whereas in reality, updates are only resent every `updatert`. The test added here sets up an SD manager and links it to the notifier. The SD changes will be triggered by that manager as it's done in reality. Signed-off-by: machine424 <ayoubmrini424@gmail.com> Co-authored-by: Ethan Hunter <ehunter@hudson-trading.com>	5 months ago
anarcat	545d31f184	docs: clarify backup requirements for storage (#14297 ) * clarify backup requirements for storage After reading this (again) recently, I was under the impression that our backup strategy ("just throw Bacula at it") was just not good enough and that our backups were inconsistent. I filed [an issue internally][41627] about this because of that concern. But reading a conversation with @SuperQ on IRC, I came under the impression that only the WAL files would be lost. This is an attempt at documenting this more clearly. [41627]: https://gitlab.torproject.org/tpo/tpa/team/-/issues/41627 --------- Signed-off-by: anarcat <anarcat@users.noreply.github.com> Co-authored-by: Ben Kochie <superq@gmail.com>	5 months ago
Arve Knudsen	be975bf8d7	golangci-lint: Enable loggercheck linter Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 months ago
Björn Rabenstein	b6ef745016	Merge pull request #14305 from charleskorn/charleskorn/convert-range-query-tests promql: Convert more test cases to test scripting language	5 months ago
Björn Rabenstein	d968408f51	Merge branch 'main' into charleskorn/convert-range-query-tests	5 months ago
George Krajcsovits	d3318c21a3	Merge pull request #14287 from krajorama/nhcb-suggest-fix native histograms: only reduce resolution for exponential histograms	5 months ago
György Krajcsovits	79020b1e85	Comment float histogram as well Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	5 months ago
György Krajcsovits	c309f50ee7	Add comment to state intent of check Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	5 months ago
George Krajcsovits	4c35b9250a	Merge pull request #14303 from prometheus/prepare-2.53.0-release Prepare 2.53.0 release	5 months ago

... 8 9 10 11 12 ...

13580 Commits (eb4004c344bf78b9e6f7e62a464a33db39a147cb) All Branches Search

13580 Commits (eb4004c344bf78b9e6f7e62a464a33db39a147cb)

All Branches