126 Commits (e681a57d73eb3c68c2458c582bfcb8c0dae58dd1)

Author	SHA1	Message	Date
Fabian Reinartz	36184f3530	Show correct error on wrong DNS response.	10 years ago
beorn7	fa1935a644	Remove /api/targets call and do not show job and instance labels on status. ... /api/targets was undocumented and never used and also broken. Showing instance and job labels on the status page (next to targets) does not make sense as those labels are set in an obvious way. Also add a doc comment to TargetStateToClass.	10 years ago
beorn7	be11cb2b07	Remove the sample ingestion channel. ... The one central sample ingestion channel has caused a variety of trouble. This commit removes it. Targets and rule evaluation call an Append method directly now. To incorporate multiple storage backends (like OpenTSDB), storage.Tee forks the Append into two different appenders. Note that the tsdb queue manager had its own queue anyway. It was a queue after a queue... Much queue, so overhead... Targets have their own little buffer (implemented as a channel) to avoid stalling during an http scrape. But a new scrape will only be started once the old one is fully ingested. The contraption of three pipelined ingesters was removed. A Target is an ingester itself now. Despite more logic in Target, things should be less confusing now. Also, remove lint and vet warnings in ast.go.	10 years ago
Julius Volz	140eede5e0	Rename UNREACHABLE to UNHEALTHY. ... The current wording suggests that a target is not reachable at all, although it might also get set when the target was reachable, but there was some other error during the scrape (invalid headers or invalid scrape content). UNHEALTHY is a more general wording that includes all these cases. For consistency, ALIVE is also renamed to HEALTHY.	10 years ago
Sergiusz 'q3k' Bazański	0d0bb3c030	Change instance identifiers to be host:port ... This changes the PublicURL function into InstanceIdentifier, which now returns a simple <host>:<port> string instead of a full URL.	10 years ago
Sergiusz 'q3k' Bazański	bb69a3d284	Hide HTTP auth parts from URL ... This instroduces an extra function in the Target interface (PublicURL) which is used to populate the instance field in scraped metrics.	10 years ago
Julius Volz	af627bb2b9	Copy vendored deps manually instead of using Godeps. ... We were using Godep incorrectly (cloning repos from the internet during build time instead of including Godeps/_workspace in the GOPATH via "godep go"). However, to avoid even having to fetch "godeps" from the internet during build, this now just copies the vendored files into the GOPATH. Also, the protocol buffer library moved from Google Code to GitHub, which is reflected in these updates. This fixes https://github.com/prometheus/prometheus/issues/525	10 years ago
beorn7	11b3c2387c	Improvements after review. ... - Increase samplesQueueCapacity. - Improve docstring for the above. - Accept a short waiting period for the ingest channel to become ready. This should depend on the http timeout, but 100ms is probably good enough to cushion bursts bigger than samplesQueueCapacity, while it is unlikely that anybody ever will set an HTTP timeout similarly short.	10 years ago
beorn7	0f191629c6	Next try to deal with backed-up ingestion. ... This is now not even trying to throttle in a benign way, but creates a fully-fledged error. Advantage: It shows up very visible on the status page. Disadvantage: The server does not really adjusts to a lower scraping rate. However, if your ingestion backs up, you are in a very irregulare state, I'd say it _should_ be considered an error and not dealt with in a more graceful way. In different news: I'll work on optimizing ingestion so that we will not as easily run into that situation in the first place.	10 years ago
beorn7	16a1a6d324	Add another check for stopped scraper.	10 years ago
beorn7	5678a86924	Throttle scraping if a scrape took longer than the configured interval. ... The simple algorithm applied here will increase the actual interval incrementally, whenever and as long as the scrape itself takes longer than the configured interval. Once it takes shorter again, the actual interval will iteratively decrease again.	10 years ago
Bjoern Rabenstein	5859b74f1b	Clean up license issues. ... - Move CONTRIBUTORS.md to the more common AUTHORS. - Added the required NOTICE file. - Changed "Prometheus Team" to "The Prometheus Authors". - Reverted the erroneous changes to the Apache License.	10 years ago
Bjoern Rabenstein	b09453af1d	Adjust to new client_golang API.	10 years ago
Julius Volz	d6b9e97655	Remove extraction.Result type, simplify code.	10 years ago
juliusv	917acb6baf	Merge pull request #429 from brian-brazil/scrape-time ... Have scrape time as a pseudovariable, not a prometheus variable.	10 years ago
Brian Brazil	e56786b221	Have scrape time as a pseudovariable, not a prometheus variable. ... This ensures it has the right timestamp, and is easier to work with. Switch sd variable away from 'outcome', using total/failed instead.	10 years ago
Brian Brazil	89c43dd0d7	Sort targets on the status page. ... Change-Id: I6b59c97ab50093c50b608e29be2304475bc5d9f6	10 years ago
Johannes 'fish' Ziemke	ff95a52b0f	Rename Address to URL ... The "Address" is actually a URL which may contain username and password. Calling this Address is misleading so we rename it. Change-Id: I441c7ab9dfa2ceedc67cde7a47e6843a65f60511	10 years ago
Bjoern Rabenstein	b1e4956142	Apply a giant code cleanup. ... Essentially: - Remove unused code. - Make it 'go vet' clean. The only remaining warnings are in generated code. - Make it 'golint' clean. The only remaining warnings are in gerenated code. - Smoothed out same minor things. Change-Id: I3fe5c1fbead27b0e7a9c247fee2f5a45bc2d42c6	10 years ago
Bjoern Rabenstein	89bb376bce	Reduce lock-protected area during scrape. ... Change-Id: Iaa7faa7c916b1890b568d05bd8bfff6299b6767d	10 years ago
Bjoern Rabenstein	fee88a7a77	Remove the remaining races, new and old. ... Also, resolve a few other TODOs. Change-Id: Icb39b5a5e8ca22ebcb48771cd8951c5d9e112691	10 years ago
Bjoern Rabenstein	14bda4180c	Changes after pair code review. ... Change-Id: Ib72d40f8e9027818cfbbd32a7a7201eebda07455	10 years ago
Bjoern Rabenstein	a2feed343a	Convert another occurrence from chan bool to chan struct{}. ... Change-Id: I11ba127a934ee3aec0fcd139ad32a7751cff77a0	10 years ago
Bjoern Rabenstein	74c143c4c9	Improve scraper shutdown time. ... - Stop target pools in parallel. - Stop individual scrapers in goroutines, too. - Timing tweaks. Change-Id: I9dff1ee18616694f14b04408eaf1625d0f989696	10 years ago
Bjoern Rabenstein	92156ee89d	Drain the newBaseLabels channel upon shutdown. ... This should help cut down shutdown times. Change-Id: I6e70a598a9e49aa6eeeb2034105b1bc6e9014324	10 years ago
Bjoern Rabenstein	6b37e47f9e	Remove unused metrics. ... Change-Id: Icf03ba4ce92a5e38daf12930f9661daba79c83bb	10 years ago
Bjoern Rabenstein	4fc8ad6677	Fix retrieval unit tests. ... Change-Id: I299b71406b59539230e5182ccc37bc8a83af60b3	10 years ago
Bjoern Rabenstein	b3ed9aa7a2	Clean up start-up and shut-down. ... Change-Id: Idff4bbb0a15a9f879bfbb3da5b1025179cab5e2c	10 years ago
Bjoern Rabenstein	4447708c9f	Fix a race in target.go. ... Also, fix problems in shutdown. Starting serving and shutdown still has to be cleaned up properly. It's a mess. Change-Id: I51061db12064e434066446e6fceac32741c4f84c	10 years ago
Bjoern Rabenstein	38fc24d0ed	Fix targetpool_test.go and other tests. ... Change-Id: I91a4dd1d39e01f174e1aaae653ce1ed7aecaa624	10 years ago
Julius Volz	7f5d3c2c29	Fix and improve the fp locker. ... Benchmark: $ go test -bench 'Fingerprint' -test.run 'Fingerprint' -test.cpu=1,2,4 OLD BenchmarkFingerprintLockerParallel 500000 3618 ns/op BenchmarkFingerprintLockerParallel-2 100000 12257 ns/op BenchmarkFingerprintLockerParallel-4 500000 10164 ns/op BenchmarkFingerprintLockerSerial 10000000 283 ns/op BenchmarkFingerprintLockerSerial-2 10000000 284 ns/op BenchmarkFingerprintLockerSerial-4 10000000 288 ns/op NEW BenchmarkFingerprintLockerParallel 1000000 1018 ns/op BenchmarkFingerprintLockerParallel-2 1000000 1164 ns/op BenchmarkFingerprintLockerParallel-4 2000000 910 ns/op BenchmarkFingerprintLockerSerial 50000000 56.0 ns/op BenchmarkFingerprintLockerSerial-2 50000000 47.9 ns/op BenchmarkFingerprintLockerSerial-4 50000000 54.5 ns/op Change-Id: I3c65a43822840e7e64c3c3cfe759e1de51272581	10 years ago
Bjoern Rabenstein	e0a6cb281e	Fix the accept header. ... A '/' is a separator and has to be in a quoted string. Change-Id: If7a3a847f84f8f709074d05dc98b5b21e954030c	10 years ago
Brian Brazil	5edf689133	Stagger scrapes to spread out load. ... Change-Id: Ib141b271e4adfb817886871f86051c207b05cf35	10 years ago
Bjoern Rabenstein	1909686789	Make metrics exported by the Prometheus server itself more consistent. ... - Always spell out the time unit (e.g. milliseconds instead of ms). - Remove "_total" from the names of metrics that are not counters. - Make use of the "Namespace" and "Subsystem" fields in the options. - Removed the "capacity" facet from all metrics about channels/queues. These are all fixed via command line flags and will never change during the runtime of a process. Also, they should not be part of the same metric family. I have added separate metrics for the capacity of queues as convenience. (They will never change and are only set once.) - I left "metric_disk_latency_microseconds" unchanged, although that metric measures the latency of the storage device, even if it is not a spinning disk. "SSD" is read by many as "solid state disk", so it's not too far off. (It should be "solid state drive", of course, but "metric_drive_latency_microseconds" is probably confusing.) - Brian suggested to not mix "failure" and "success" outcome in the same metric family (distinguished by labels). For now, I left it as it is. We are touching some bigger issue here, especially as other parts in the Prometheus ecosystem are following the same principle. We still need to come to terms here and then change things consistently everywhere. Change-Id: If799458b450d18f78500f05990301c12525197d3	10 years ago
Brian Brazil	4a2b96f848	Remove backoff on scrape failure. ... Having metrics with variable timestamps inconsistently spaced when things fail will make it harder to write correct rules. Update status page, requires some refactoring to insert a function. Change-Id: Ie1c586cca53b8f3b318af8c21c418873063738a8	10 years ago
Julius Volz	1bb7074fec	Fix HTTP connection leak upon non-OK status. ... Change-Id: Ie7fbd7dcc089b8306b40631be3e3d736c23c1cd3	10 years ago
Bjoern Rabenstein	bacc31d5cc	Remove work-around that required copying all bytes of a scrape. ... Now that the subtle bug in matttproud/golang_protobuf_extensions is fixed, we do not need to copy the bytes of a scrape into a buffer first before starting to parse it. Change-Id: Ib73ecae16173ddd219cda56388a8f853332f8853	10 years ago
Bjoern Rabenstein	8956faeccb	Migrate to new client_golang. ... This change will only be submitted when the new client_golang has been moved to the new version. Change-Id: Ifceb59333072a08286a8ac910709a8ba2e3a1581	10 years ago
Bjoern Rabenstein	814e479723	Treat non-200 HTTP response as error. ... Change-Id: I2a9f3b47012b3c4839be53aa44c66d16dd41a24a	10 years ago
Bjoern Rabenstein	ca6a4fccef	Weed out our homegrown test.Tester. ... The Go stdlib has testing.TB now, which fulfills the exact same purpose. Change-Id: I0db9c73400e208ca376b932a02b7e3402234b87c	11 years ago
Brian Brazil	23255f1499	Fix negative Next Retrieval on status page. ... Change-Id: Ifa754034660a251fee71f166dbf057697ec4e872	11 years ago
Bjoern Rabenstein	64811caaec	Make Prometheus announce its new super-power: text format! ... Change-Id: Ia2ddfb28999c145e4d46c395381a9bf89d43148c	11 years ago
Julius Volz	84df022025	Cleanup server address handling, support IPv6. ... This fixes https://github.com/prometheus/prometheus/issues/377, as IPv6 server addresses are now handled correctly. Change-Id: Iebde7cfdadb0a52041472517e6fdcff4303a25ab	11 years ago
Julius Volz	b382e8b7bd	Remove overly verbose DNS-SD logging line. ... Change-Id: Ie4534437ab88b9a6b99f5cb6c2f32c9588c1fff6	11 years ago
Julius Volz	0378c2ca1f	Nonexistent labels in BY-clauses shouldn't propagate to result. ... This fixes bug 2. of https://github.com/prometheus/prometheus/issues/374 Change-Id: Ia4a13153616bafce5bf10597966b071434422d09	11 years ago
Stuart Nelson	48a6326d25	Added DNS-SD lookup counter for successful/unsuccessful lookups ... Change-Id: I0a71e994a989cecace280b5134a31ebc2ace7591	11 years ago
Julius Volz	fb44580110	Cleanup/fix program termination sequence. ... Change-Id: I2bc58a2583fb079c9ef383cfc7a5e0fbe613f1cd	11 years ago
Julius Volz	740d448983	Use custom timestamp type for sample timestamps and related code. ... So far we've been using Go's native time.Time for anything related to sample timestamps. Since the range of time.Time is much bigger than what we need, this has created two problems: - there could be time.Time values which were out of the range/precision of the time type that we persist to disk, therefore causing incorrectly ordered keys. One bug caused by this was: https://github.com/prometheus/prometheus/issues/367 It would be good to use a timestamp type that's more closely aligned with what the underlying storage supports. - sizeof(time.Time) is 192, while Prometheus should be ok with a single 64-bit Unix timestamp (possibly even a 32-bit one). Since we store samples in large numbers, this seriously affects memory usage. Furthermore, copying/working with the data will be faster if it's smaller. *MEMORY USAGE RESULTS* Initial memory usage comparisons for a running Prometheus with 1 timeseries and 100,000 samples show roughly a 13% decrease in total (VIRT) memory usage. In my tests, this advantage for some reason decreased a bit the more samples the timeseries had (to 5-7% for millions of samples). This I can't fully explain, but perhaps garbage collection issues were involved. *WHEN TO USE THE NEW TIMESTAMP TYPE* The new clientmodel.Timestamp type should be used whenever time calculations are either directly or indirectly related to sample timestamps. For example: - the timestamp of a sample itself - all kinds of watermarks - anything that may become or is compared to a sample timestamp (like the timestamp passed into Target.Scrape()). When to still use time.Time: - for measuring durations/times not related to sample timestamps, like duration telemetry exporting, timers that indicate how frequently to execute some action, etc. *NOTE ON OPERATOR OPTIMIZATION TESTS* We don't use operator optimization code anymore, but it still lives in the code as dead code. It still has tests, but I couldn't get all of them to pass with the new timestamp format. I commented out the failing cases for now, but we should probably remove the dead code soon. I just didn't want to do that in the same change as this. Change-Id: I821787414b0debe85c9fffaeb57abd453727af0f	11 years ago
Johannes 'fish' Ziemke	8c08a5031f	Add search domain support to SRV lookups ... This adds search domain support by trying to resolve a name by appending each search domain configured in /etc/resolv.conf until the query succeeds (NOERROR) and has at least one answer. Change-Id: Ibdc5138c5d8cc049e11fab90c3d5243d5a06852c	11 years ago
Julius Volz	274934bcd3	Revert "Revert "Merge pull request #317 from prometheus/fix/miekg-dns-for-srv"" ... This reverts commit 88099328d1. Change-Id: I7bf74de5fda458e2e6f9eea2eacd0e256f95bdee	11 years ago