4fd2556baa
Extract processWithBoundedParallelismAndConsistentWorkers
...
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
2024-09-26 15:43:19 +02:00
751100b3d0
Merge pull request #12998 from ringerc/docs-instant-vector-staleness
...
Docs: Refer to staleness in instant vector documentation
2024-09-26 14:52:34 +02:00
7f99d2930d
[BUGFIX] PromQL: make sort_by_label stable
...
Go's sorting functions can re-order equal elements, so the strategy of
sorting by the fallback ordering first does not always work.
Pulling the fallback into the main comparison function is more reliable
and more efficient.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-09-26 11:12:33 +01:00
15b68e989c
Refer to staleness in instant vector documentation
...
The instant vector documentation does not explain which metric samples are selected - in particular, it makes no reference to staleness.
It's confusing when reading the docs to understand how exactly Prometheus selects the metrics to report: the most recent sample older than the search timestamp specified in the API request, so long as that metric is not "stale".
Signed-off-by: Craig Ringer <craig.ringer@enterprisedb.com>
2024-09-26 11:54:31 +12:00
fcbd18dabb
Remove Query page alert close buttons that don't do anything
...
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2024-09-25 18:27:27 +02:00
be0f10054e
Remove no-default-scrape-port featureFlag
...
Signed-off-by: Alex Johnson <alex.kattathra.johnson@gmail.com>
2024-09-25 10:13:19 -05:00
ccd0308abc
Don't do anything if MemPostings are empty
...
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
2024-09-25 15:00:10 +02:00
9c417aa710
Fix deadlock with empty MemPostings
...
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
2024-09-25 14:08:50 +02:00
71fd2d93a9
Merge branch 'main' into nhcb-scrape-impl
...
# Conflicts:
# config/config.go
# scrape/scrape.go
2024-09-25 13:43:57 +02:00
97ba2fc39d
use caps for NHCB
...
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2024-09-25 13:38:30 +02:00
90c266845b
fix lint
...
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2024-09-25 13:38:27 +02:00
050b5fc257
refine test cases according to spec
...
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2024-09-25 13:38:22 +02:00
de9de320a4
start to cover all test cases for scrape
...
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2024-09-25 13:38:18 +02:00
f35c6649e4
don't blindly convert series with the classic histogram name suffixes if they are not actually histograms based on metadata
...
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2024-09-25 13:38:15 +02:00
8b3ae15ad5
expand tests for classic and exponential native histograms
...
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2024-09-25 13:38:10 +02:00
e3899187da
expand tests for protobuf and fix problems
...
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2024-09-25 13:38:08 +02:00
cd498964e6
expand tests and support conversion to nhcb in the middle of scrape
...
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2024-09-25 13:38:04 +02:00
41c7f7d352
don't reuse the buffer
...
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2024-09-25 13:38:01 +02:00
57bde06d2c
add doc comments
...
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2024-09-25 13:37:56 +02:00
cbd5488cd3
skip nhcb conversion if there is native histogram of same name
...
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2024-09-25 13:37:51 +02:00
0e5072b873
keep only 1 nhcb in memory at at time
...
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2024-09-25 13:37:46 +02:00
172d4f2405
insert nhcb parser as intermediate layer
...
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2024-09-25 13:37:37 +02:00
f596f17024
allow option to convert classic histograms to nhcb entirely (don't append classic histogram series)
...
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2024-09-25 13:37:30 +02:00
02d5abf60e
don't use cache for nhcb maps
...
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2024-09-25 13:37:26 +02:00
0a321fe4d8
improve new scrape test
...
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2024-09-25 13:37:20 +02:00
4503145c8b
convert classic histograms to int nhcb where possible instead
...
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2024-09-25 13:37:08 +02:00
62e7f0438d
implement basic conversion of classic to nhcb in scrape
...
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2024-09-25 13:36:56 +02:00
5d8f0ef0c2
Merge pull request #14721 from bboreham/exp-grow-postings
...
[PERF] TSDB: Grow postings by doubling
2024-09-25 10:47:55 +01:00
e196b977af
Process MemPostings.Delete() with GOMAXPROCS workers
...
We are still seeing lock contention on MemPostings.mtx, and MemPostings.Delete() is by far the most expensive operation on that mutex.
This adds parallelism to that method, trying to reduce the amount of time we spend with the mutex held.
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
2024-09-25 10:38:47 +02:00
5037cf75f2
Merge pull request #14972 from prometheus/jvp/make-mantime-ui-assets-relative
...
UI: Make mantime UI assets relative
2024-09-24 17:38:21 +02:00
67caa03dc1
Merge pull request #14970 from prometheus/beorn7/doc
...
docs: Improve, clarify, and fix documentation on scrape limits
2024-09-24 16:30:15 +02:00
cb4bc5e786
UI: Make mantime UI assets relative
...
Signed-off-by: Jesus Vazquez <jesusvzpg@gmail.com>
2024-09-24 15:30:54 +02:00
a9243d4d2c
docs: Improve, clarify, and fix documentation on scrape limits
...
In detail:
- Clarify that label name and value length limits are in byte,
not in UTF-8 data points.
- More consistent formatting to keep 80 characters line limet.
- Clarify various misleading specifications around "per sample",
"per scrape", "per scrape config", "per job"...
- Fix grammar.
Signed-off-by: beorn7 <beorn@grafana.com>
2024-09-24 14:55:54 +02:00
a0f26febc2
Merge pull request #12180 from damnever/perf/relabel-add-label
...
Optimize constant label pair adding from relabeling.
2024-09-24 12:22:05 +01:00
c2bbabb4a7
promql.Engine: Refactor vector selector evaluation into a method ( #14900 )
...
* PromQL.Engine: Refactor Matrix expansion into a method
Add utility method promql.evaluator.expandSeriesToMatrix, for expanding a slice
of storage.Series into a promql.Matrix.
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
* Rename to generateMatrix
Rename evaluator.expandSeriesToMatrix into generateMatrix, while also dropping
the start, end, interval arguments since they are evaluator fields.
Write more extensive method documentation.
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
* Rename to evalVectorSelector
Rename to evalVectorSelector after discussing with @michahoffmann.
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
---------
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2024-09-24 11:03:56 +01:00
faf5ba29ba
Merge pull request #14959 from prometheus/merge-2.55-into-main
...
Merge 2.55 into main
2024-09-23 18:39:37 +01:00
3f9b869fb5
Fix react-app (old UI) package-lock.json
...
cd web/ui/react-app
npm install
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2024-09-23 16:34:37 +01:00
f179cb948b
chore: bump client_golang from 1.20.3 to 1.20.4 ( #14963 )
...
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2024-09-23 13:46:51 +02:00
919648cafc
Merge pull request #14947 from roidelapluie/reloadinvalidyaml
...
fix(autoreload): Reload invalid yaml files
2024-09-23 10:03:23 +02:00
4c90118361
Remove CHANGELOG duplicate line
...
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
#14402 is the issue and #14403 is the fix.
2024-09-22 17:53:41 +01:00
ca673eb749
Merge remote-tracking branch 'origin/release-2.55' into merge-2.55-into-main
...
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-09-22 17:49:34 +01:00
e3f5c7c2a0
[Release 2.55] Update CHANGELOG
...
Make text more consistent with 3.0 branch
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-09-22 17:42:04 +01:00
31c5760551
Neater string vs byte-slice conversions ( #14425 )
...
unsafe.Slice and unsafe.StringData were added in Go 1.20
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-09-21 12:19:21 +02:00
6bcb064d93
Merge pull request #14950 from Maniktherana/fuzz-om-minor-change
...
chore: remove unused code
2024-09-21 09:22:17 +01:00
52fe4cc4ee
Merge pull request #14944 from roidelapluie/copy
...
Mantine UI: removed unuse file
2024-09-20 21:28:09 +02:00
dfc6f4b5bc
Merge pull request #14945 from roidelapluie/submillis
...
fix(web): properly format sub-millisecond durations in target status page
2024-09-20 21:27:16 +02:00
e0260930d6
Merge pull request #14951 from prometheus/update-rel-2.55
...
[release-2.55] Add #14948 to rc0
2024-09-20 18:42:51 +01:00
d42232e178
Merge pull request #14932 from bboreham/chunk-xor-combine-writebits
...
[PERF] TSDB: Chunk encoding: shorten some write sequences
2024-09-20 17:53:54 +01:00
e3617cbd2c
Add #14948 to CHANGELOG
...
Also update the date of the RC which hasn't gone out yet.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-09-20 17:48:04 +01:00
6f0d6038b7
[BUGFIX] TSDB: Only query chunks up to truncation time ( #14948 )
...
If the query overlaps the range currently undergoing compaction, we
should only fetch chunks up to that time. Need to store that min time
in `HeadAndOOOIndexReader`.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-09-20 17:44:04 +01:00
Oleg Zaytsev