76 Commits (d6c590018bb5a13150068bb017db6de07d3fecd1)

Author	SHA1	Message	Date
Fabian Reinartz	b7e2f407de	rules: Fix double-locking of mutex ... Signed-off-by: Fabian Reinartz <freinartz@google.com>	6 years ago
Benji Visser	8bb6e0dd6e	Show rule evaluation errors on rules page (#4457) ... * adding information about the health and errors for Rules adding Health() and LastError() to the Rule interface. This will allow us to easily surface information about rules. Signed-off-by: noqcks <benny@noqcks.io> * updating rules.html with fields for Rule errors and health state Signed-off-by: noqcks <benny@noqcks.io> * fix code comment grammar & access Rule health/error info using a mutex Signed-off-by: noqcks <benny@noqcks.io> * s/Errors/Error/ in rules.html to remain consistent with targets.html Signed-off-by: noqcks <benny@noqcks.io> * adding periods to code comments in reporting/alerting Signed-off-by: noqcks <benny@noqcks.io> * putting health/error below mutex in struct field Signed-off-by: noqcks <benny@noqcks.io>	6 years ago
Julius Volz	2b8fc062a8	rules: HTML-escape rule YAML marshal errors (#4464) ... This was pointed out by `gosec`. Signed-off-by: Julius Volz <julius.volz@gmail.com>	6 years ago
Ganesh Vernekar	f1db699dff	Persist alert 'for' state across restarts (#4061) ... Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>	6 years ago
Max Leonard Inden	71fafad099	api/v1: Coninue work exposing rules and alerts ... Signed-off-by: Max Leonard Inden <IndenML@gmail.com>	6 years ago
mg03	31f8ca0dfb	api v1 alerts/rules json endpoint ... Signed-off-by: mg03 <mgeng03@gmail.com>	6 years ago
Julius Volz	9e3171f6e3	rules: Minor naming/comment cleanups (#4328) ... Signed-off-by: Julius Volz <julius.volz@gmail.com>	6 years ago
ferhat elmas	ec8e4d8a7c	all: remove unnecessary type conversions (#3992) ... excep promql due to not to create conflict with #3966.	7 years ago
Simon Pasquier	81c0ab69e0	Don't reset FiredAt for inactive alerts ... Otherwise AlertManager receives resolved alerts where StartsAt is zero which fails the validation.	7 years ago
Fabian Reinartz	62461379b7	rules: decouple notifier packages ... The dependency on the notifier packages caused a transitive dependency on discovery and with that all client libraries our service discovery uses.	7 years ago
Fabian Reinartz	2d0e3746ac	rules: remove dependency on promql.Engine	7 years ago
Goutham Veeramachaneni	a880c86375	Fix unexported method on exported interface. ... Also move to model.Duration Signed-off-by: Goutham Veeramachaneni <cs14btech11014@iith.ac.in>	7 years ago
conorbroderick	55aaece116	Add rule evaluation time	7 years ago
Julius Volz	099df0c5f0	Migrate "golang.org/x/net/context" -> "context" (#3333) ... In some places, where ctxhttp or gRPC are concerned, we still need to use the old contexts.	7 years ago
Fabian Reinartz	2d0b8e8b94	Merge branch 'master' into dev-2.0	7 years ago
beorn7	c2e9a151ab	Make all rule links link to the "Console" tab rather than "Graph" ... Clicking on a rule, either the name or the expression, opens the rule result (or the corresponding expression, repsectively) in the expression browser. This should by default happen in the console tab, as, more often than not, displaying it in the graph tab runs into a timeout.	7 years ago
Fabian Reinartz	d21f149745	*: migrate to go-kit/log	7 years ago
Goutham Veeramachaneni	e1fc9dc78d	Move /rules to new format (#2901) ... Fixes #2891 Signed-off-by: Goutham Veeramachaneni <goutham@boomerangcommerce.com>	8 years ago
Goutham Veeramachaneni	507790a357	Rework logging to use explicitly passed logger ... Mostly cleaned up the global logger use. Still some uses in discovery package. Signed-off-by: Goutham Veeramachaneni <cs14btech11014@iith.ac.in>	8 years ago
Brian Brazil	dcea3e4773	Don't append a 0 when alert is no longer pending/firing ... With staleness we no longer need this behaviour.	8 years ago
Fabian Reinartz	06c2b76cd4	Merge branch 'master' into uptsdb	8 years ago
Julius Volz	ac203ef0ee	Add externalURL template function (#2716) ... This allows users to e.g. add links back to the generating Prometheus right in their alert templates.	8 years ago
Julius Volz	fe11c5933a	Fix mutation of active alert elements by notifier (#2656) ... This caused the external label application in the notifier to bleed back into the rule manager's active alerting elements.	8 years ago
Fabian Reinartz	e94b0899ee	rules: fix tests, remove model types	8 years ago
Fabian Reinartz	5817cb5bde	*: migrate from model.* to promql.* types	8 years ago
Fabian Reinartz	e68a3cf21f	rules: update annotations on each iteration	8 years ago
Jonathan Lange	2a2da40223	Make rule evaluation publicly available ... Means that a third-party can parse rules and run them with their own execution model.	8 years ago
Julius Volz	c187308366	storage: Contextify storage interfaces. ... This is based on https://github.com/prometheus/prometheus/pull/1997. This adds contexts to the relevant Storage methods and already passes PromQL's new per-query context into the storage's query methods. The immediate motivation supporting multi-tenancy in Frankenstein, but this could also be used by Prometheus's normal local storage to support cancellations and timeouts at some point.	8 years ago
Julius Volz	ed5a0f0abe	promql: Allow per-query contexts. ... For Weaveworks' Frankenstein, we need to support multitenancy. In Frankenstein, we initially solved this without modifying the promql package at all: we constructed a new promql.Engine for every query and injected a storage implementation into that engine which would be primed to only collect data for a given user. This is problematic to upstream, however. Prometheus assumes that there is only one engine: the query concurrency gate is part of the engine, and the engine contains one central cancellable context to shut down all queries. Also, creating a new engine for every query seems like overkill. Thus, we want to be able to pass per-query contexts into a single engine. This change gets rid of the promql.Engine's built-in base context and allows passing in a per-query context instead. Central cancellation of all queries is still possible by deriving all passed-in contexts from one central one, but this is now the responsibility of the caller. The central query context is now created in main() and passed into the relevant components (web handler / API, rule manager). In a next step, the per-query context would have to be passed to the storage implementation, so that the storage can implement multi-tenancy or other features based on the contextual information.	8 years ago
Julius Volz	da7206ec29	Fix rule HTML escaping issues ... This was mentioned as part of https://github.com/prometheus/alertmanager/issues/452	8 years ago
Brian Brazil	6fc88d4b4d	Remove __name__ from alerts sent to AM. ... Fixes #1861	8 years ago
Brian Brazil	0509b0f2db	Expand alert templates at eval time. ... Fixes #1678 #1677	9 years ago
beorn7	b95c096a45	Fix style issues in rules/...	9 years ago
Fabian Reinartz	d89c254849	Make copying alerting state safer. ... This considers static labels in the equality of alerts to avoid falsely copying state from a different alert definition with the same name across reloads. To be safe, it also copies the state map rather than just its pointer so that remaining collisions disappear after one evaluation interval.	9 years ago
Tobias Schmidt	f1f8317fa5	Fix detection of flapping alerts ... Alerts in the resolve retention period must be transitioned to the active state again when their condition is met.	9 years ago
beorn7	a7408bfb47	Unify duration parsing ... It's actually happening in several places (and for flags, we use the standard Go time.Duration...). This at least reduces all our home-grown parsing to one place (in model).	9 years ago
Fabian Reinartz	a6935024e1	Remove old WITH clause in alert printing	9 years ago
Fabian Reinartz	0cf3c6a9ef	Add comments, rename a method	9 years ago
Fabian Reinartz	bf6abac8f4	Send resolved notifications	9 years ago
Fabian Reinartz	52e5224f5a	Refactor rules/ package	9 years ago
Fabian Reinartz	7c90db22ed	Use annotation based alerts in rules/ ... This commit breaks the previously used alert format.	9 years ago
Julius Volz	995d3b831d	Fix most golint warnings. ... This is with `golint -min_confidence=0.5`. I left several lint warnings untouched because they were either incorrect or I felt it was better not to change them at the moment.	9 years ago
Fabian Reinartz	d6b8da8d43	Switch promql types to common/model	9 years ago
Fabian Reinartz	306e8468a0	Switch from client_golang/model to common/model	9 years ago
Fabian Reinartz	749ae450c5	promql: add runbook to alert statement. ... This commit adds the RUNBOOK keyword to alert statements. The field is optional and expected to be a link.	10 years ago
Julius Volz	d868264bb8	Improve UI of /alerts page. ... Changes to the UI: - "Active Since" timestamps are now human-readable. - Alerting rules are now pretty-printed better. - Labels are no longer just strings, but alert bubbles (like we do on the status page for base labels). - Alert states and target health states are now capitalized in the presentation layer rather than at the source.	10 years ago
Fabian Reinartz	5e13880201	General cleanup of rules.	10 years ago
Fabian Reinartz	75c920c95e	Remove DotGraph method from Rule interface	10 years ago
Fabian Reinartz	83d07516e8	Remove EvalRaw methods from Rule interface	10 years ago
Fabian Reinartz	0de6edbdfc	Move pkg/ to util/	10 years ago