278 Commits (d5ef0c64dc1befc88ee4ec0560aa7d5cefd5fc8d)

Author	SHA1	Message	Date
Matt T. Proud	30b1cf80b5	WIP - Snapshot of Moving to Client Model.	12 years ago
juliusv	42198c1f1c	Merge pull request #311 from prometheus/fix/watermarking/on-first-write ... Ensure new metrics are watermarked early.	12 years ago
Matt T. Proud	b811ccc161	Disable paranoid checks and expose max FDs option. ... We shouldn't need paranoid checks now. We also shouldn't need too many FDs being open due to rule evaluator hitting in-memory values stream.	12 years ago
Matt T. Proud	4137c75523	Shrink default LRU cache sizes. ... Observing Prometheus in production confirms we can lower these values safely.	12 years ago
Matt T. Proud	ecb9c7bb9d	Code Review: Swap ordering of elements.	12 years ago
Matt T. Proud	5daa0a09ea	Code Review: Swap ordering of watermark getting. ... A test for Julius.	12 years ago
Matt T. Proud	ee840904d2	Code Review: !Before -> After.	12 years ago
Matt T. Proud	2d5de99fbf	Regard in-memory series as new. ... This commit ensures that series that exist only in-memory and not on-disk are not regarded as too old for operation exclusion.	12 years ago
Matt T. Proud	81c406630a	Merge pull request #312 from prometheus/fix/sample-append-logging ... Log correct sample count when appending to disk.	12 years ago
Matt T. Proud	a1a23fbaf8	Ensure new metrics are watermarked early. ... With the checking of fingerprint freshness to cull stale metrics from queries, we should write watermarks early to aid in more accurate responses.	12 years ago
Julius Volz	ba8c122147	Log correct sample count when appending to disk.	12 years ago
Julius Volz	f2b4067b7b	Speedup and clean up operation optimization.	12 years ago
Julius Volz	008bc09da8	Move check for empty memory series to separate method.	12 years ago
Julius Volz	16364eda37	Drop empty series from memory after flushing.	12 years ago
Julius Volz	71199e2c93	Cache disk fingerprint->metric lookups in memory.	12 years ago
Matt T. Proud	a73f061d3c	Persist solely Protocol Buffers. ... An design question was open for me in the beginning was whether to serialize other types to disk, but Protocol Buffers quickly won out, which allows us to drop support for other types. This is a good start to cleaning up a lot of cruft in the storage stack and can let us eventually decouple the various moving parts into separate subsystems for easier reasoning. This commit is not strictly required, but it is a start to making the rest a lot more enjoyable to interact with.	12 years ago
juliusv	95400cb785	Merge pull request #290 from prometheus/fix/go-vet ... Minor "go tool vet" cleanups	12 years ago
Julius Volz	558281890b	Minor "go tool vet" cleanups	12 years ago
juliusv	615972dd01	Merge pull request #288 from prometheus/fix/curator/fallthrough-compaction-ordering ... Fix fallthrough compaction value ordering.	12 years ago
Matt T. Proud	86f63b078b	Fix fallthrough compaction value ordering. ... We discovered a regression whereby data chunks could be appended out of order if the fallthrough case was hit.	12 years ago
Julius Volz	7b9ee95030	Minor LevelDB watermark handling cleanups.	12 years ago
Julius Volz	84741b227d	Use LRU cache to avoid querying stale series.	12 years ago
Julius Volz	f98853d7b7	Fix type error in watermark list handling.	12 years ago
Matt T. Proud	ef1d5fd8a2	Introduce semaphores for tiered storage. ... This commit wraps the tiered storage access componnets in semaphores, since we can handle several concurrent memory reads.	12 years ago
Matt T. Proud	819045541e	Code Review: Make double-drain a panic.	12 years ago
Matt T. Proud	e217a9fb41	Race Work: Make memory arena locks more coarse. ... We can optimize these as needed later.	12 years ago
Matt T. Proud	beaaf386e7	Add storage state guards and transition callbacks. ... To ensure that we access tiered storage in the proper way, we have guards now.	12 years ago
Matt T. Proud	abb5353ade	Merge pull request #283 from prometheus/feature/storage/consult-watermark ... Include LRU cache for fingerprint watermarks.	12 years ago
Matt T. Proud	2c3df44af6	Ensure database access waits until it is started. ... This commit introduces a channel message to ensure serving state has been reached with the storage stack before anything attempts to use it.	12 years ago
Matt T. Proud	cbe2f3a7b1	Include LRU cache for fingerprint watermarks.	12 years ago
Julius Volz	51689d965d	Add debug timers to instant and range queries. ... This adds timers around several query-relevant code blocks. For now, the query timer stats are only logged for queries initiated through the UI. In other cases (rule evaluations), the stats are simply thrown away. My hope is that this helps us understand where queries spend time, especially in cases where they sometimes hang for unusual amounts of time.	12 years ago
Matt T. Proud	8339a189cb	Code Review: Fix seriesPresent scope. ... The seriesPresent scope should be constrained to the scope of a scanJob, since this is keyed to given series.	12 years ago
Matt T. Proud	fe41ce0b19	Conditionalize disk initializations. ... This commit conditionalizes the creation of the diskFrontier and seriesFrontier along with the iterator such that they are provisioned once something is actually required from disk.	12 years ago
Julius Volz	a8468a2e5e	Fix reversed disk flush cutoff behavior.	12 years ago
Julius Volz	eb1f956909	Revert "Revert "Ensure that all extracted samples are added to view."" ... This reverts commit 4b30fb86b4.	12 years ago
Matt T. Proud	4b30fb86b4	Revert "Ensure that all extracted samples are added to view." ... This reverts commit 008314b5a8. By running an automated git bisection described in https://gist.github.com/matttproud-soundcloud/22a371a8d2cba382ea64 this commit was found.	12 years ago
Julius Volz	750f862d9a	Use GetBoundaryValues() for non-counter deltas.	12 years ago
Julius Volz	f2b48b8c4a	Make getValuesAtIntervalOp consume all chunk data in one pass. ... This is mainly a small performance improvement, since we skip past the last extracted time immediately if it was also the last sample in the chunk, instead of trying to extract non-existent values before the chunk end again and again and only gradually approaching the end of the chunk.	12 years ago
Julius Volz	83d60bed89	extractValuesAroundTime() code simplification.	12 years ago
Julius Volz	008314b5a8	Ensure that all extracted samples are added to view. ... The current behavior only adds those samples to the view that are extracted by the last pass of the last processed op and throws other ones away. This is a bug. We need to append all samples that are extracted by each op pass. This also makes view.appendSamples() take an array of samples.	12 years ago
Matt T. Proud	b586801830	Code Review: Fix to-disk queue infinite growth. ... We discovered a bug while manually testing this branch on a live instance, whereby the to-disk queue was never actually dumped to disk.	12 years ago
Matt T. Proud	285a8b701b	Code Review: Extend lock.	12 years ago
Matt T. Proud	2526ab8c81	Code Review: Extend lock scope for appending.	12 years ago
Matt T. Proud	f994482d15	Code Review: Avenues for future improvemnet noted.	12 years ago
Matt T. Proud	298a90c143	Code Review: Initial arena size name.	12 years ago
Matt T. Proud	c07abf8521	Initial move away from skiplist.	12 years ago
Matt T. Proud	74a66fd938	Spawn grouping of fingerprints with free semaphore. ... The previous implementation spawned N goroutines to group samples together and would not start work until the semaphore unblocked. While this didn't leak, it polluted the scheduling space. Thusly, the routine only starts after a semaphore has been acquired.	12 years ago
Julius Volz	5b105c77fc	Repointerize fingerprints.	12 years ago
Matt T. Proud	ec5b5bae28	Fuck you, Travis.	12 years ago
Matt T. Proud	e5ac91222b	Benchmark memory arena; simplify map generation. ... The one-off keys have been replaced with ``model.LabelPair``, which is indexable. The performance impact is negligible, but it represents a cognitive simplification.	12 years ago
juliusv	360477f66c	Merge pull request #257 from prometheus/feature/better-memory-behaviors ... Pointerize memorySeriesArena.	12 years ago
Matt T. Proud	e1f20de2e9	Pointerize memorySeriesArena.	12 years ago
Matt T. Proud	8f4c7ece92	Destroy naked returns in half of corpus. ... The use of naked return values is frowned upon. This is the first of two bulk updates to remove them.	12 years ago
Matt T. Proud	4e0c932a4f	Simplify Encoder's encoding signature. ... The reality is that if we ever try to encode a Protocol Buffer and it fails, it's likely that such an error is ultimately not a runtime error and should be fixed forthwith. Thusly, we should rename ``Encoder.Encode`` to ``Encoder.MustEncode`` and drop the error return value.	12 years ago
juliusv	516101f015	Merge pull request #250 from prometheus/refactor/drop-unused-storage-setting ... Drop unused writeMemoryInterval	12 years ago
juliusv	9ff00b651d	Merge pull request #251 from prometheus/fix/memory-metric-mutability ... Fix GetMetricForFingerprint() metric mutability.	12 years ago
Bernerd Schaefer	63d9988b9c	Drop unused writeMemoryInterval	12 years ago
Julius Volz	83c60ad43a	Fix GetMetricForFingerprint() metric mutability. ... Some users of GetMetricForFingerprint() end up modifying the returned metric labelset. Since the memory storage's implementation of GetMetricForFingerprint() returned a pointer to the metric (and maps are reference types anyways), the external mutation propagated back into the memory storage. The fix is to make a copy of the metric before returning it.	12 years ago
Bernerd Schaefer	428d91c86f	Rename test helper files to helpers_test.go ... This ensures that these files are properly included only in testing.	12 years ago
juliusv	98e512d755	Merge pull request #246 from prometheus/fix/interval-value-extraction ... Fix and optimize getValuesAtIntervalOp data extraction.	12 years ago
Julius Volz	71a3172abb	Fix and optimize getValuesAtIntervalOp data extraction. ... - only the data extracted in the last loop iteration of ExtractSamples() was emitted as output - if e.g. op interval < sample interval, there were situations where the same sample was added multiple times to the output	12 years ago
Matt T. Proud	244a4a9cdb	Update to go1.1. ... This commit updates the documentation, Makefiles, formatting, and code semantics to support the 1.1. runtime, which includes ... 1. ``make advice``, 2. ``make format``, and 3. ``go fix`` on various targets.	12 years ago
Matt T. Proud	b224251981	Simplify compaction and expose database sizes. ... This commit simplifies the way that compactions across a database's keyspace occur due to reading the LevelDB internals. Secondarily it introduces the database size estimation mechanisms. Include database health and help interfaces. Add database statistics; remove status goroutines. This commit kills the use of Go routines to expose status throughout the web components of Prometheus. It also dumps raw LevelDB status on a separate /databases endpoint.	12 years ago
juliusv	92ad65ff13	Merge pull request #232 from prometheus/optimize/granular-storage-locking ... Synchronous memory appends and more fine-grained storage locks.	12 years ago
Matt T. Proud	1f7f89b4e3	Simplify compaction and expose database sizes. ... This commit simplifies the way that compactions across a database's keyspace occur due to reading the LevelDB internals. Secondarily it introduces the database size estimation mechanisms.	12 years ago
Matt T. Proud	d538b0382f	Include long-tail data deletion mechanism. ... This commit introduces the long-tail deletion mechanism, which will automatically cull old sample values. It is an acceptable hold-over until we get a resampling pipeline implemented. Kill legacy OS X documentation, too.	12 years ago
Julius Volz	ce1ee444f1	Synchronous memory appends and more fine-grained storage locks. ... This does two things: 1) Make TieredStorage.AppendSamples() write directly to memory instead of buffering to a channel first. This is needed in cases where a rule might immediately need the data generated by a previous rule. 2) Replace the single storage mutex by two new ones: - memoryMutex - needs to be locked at any time that two concurrent goroutines could be accessing (via read or write) the TieredStorage memoryArena. - memoryDeleteMutex - used to prevent any deletion of samples from memoryArena as long as renderView is running and assembling data from it. The LevelDB disk storage does not need to be protected by a mutex when rendering a view since renderView works off a LevelDB snapshot. The rationale against adding memoryMutex directly to the memory storage: taking a mutex does come with a small inherent time cost, and taking it is only required in few places. In fact, no locking is required for the memory storage instance which is part of a view (and not the TieredStorage).	12 years ago
Matt T. Proud	fa6a1f97d0	Expose interfaces for pruner and make pruner tool. ... In order to run database cleanups and diagnostics, we should have a means for pruning a database---even if LevelDB does this for us.	12 years ago
Matt T. Proud	161c8fbf9b	Include deletion processor for long-tail values. ... This commit extracts the model.Values truncation behavior into the actual tiered storage, which uses it and behaves in a peculiar way—notably the retention of previous elements if the chunk were to ever go empty. This is done to enable interpolation between sparse sample values in the evaluation cycle. Nothing necessarily new here—just an extraction. Now, the model.Values TruncateBefore functionality would do what a user would expect without any surprises, which is required for the DeletionProcessor, which may decide to split a large chunk in two if it determines that the chunk contains the cut-off time.	12 years ago
Matt Proud	7f0d816574	Schedule the background compactors to run. ... This commit introduces three background compactors, which compact sparse samples together. 1. Older than five minutes is grouped together into chunks of 50 every 30 minutes. 2. Older than 60 minutes is grouped together into chunks of 250 every 50 minutes. 3. Older than one day is grouped together into chunks of 5000 every 70 minutes.	12 years ago
Julius Volz	caab131ada	Repointerize TieredStorage method receiver types.	12 years ago
juliusv	89de116ea9	Merge pull request #225 from prometheus/refactor/fmt-cleanups ... Slice expression simplifications.	12 years ago
Julius Volz	05afa970d2	Slice expression simplifications.	12 years ago
Matt T. Proud	f897164bcf	Expose TieredStorage.DiskStorage.	12 years ago
Matt T. Proud	ce45787dbf	Storage interface to TieredStorage. ... This commit drops the Storage interface and just replaces it with a publicized TieredStorage type. Storage had been anticipated to be used as a wrapper for testability but just was not used due to practicality. Merely overengineered. My bad. Anyway, we will eventually instantiate the TieredStorage dependencies in main.go and pass them in for more intelligent lifecycle management. These changes will pave the way for managing the curators without Law of Demeter violations.	12 years ago
Bernerd Schaefer	5eb9840ed7	Fix goroutine leak in leveldb.AppendSamples ... The error channels in AppendSamples need to be buffered, since in the presence of errors their values may not be consumed.	12 years ago
Matt T. Proud	a3f1d81e24	Publicize a few storage components for curation. ... This commit introduces the publicization of Stop and other components, which the compaction curator shall take advantage of.	12 years ago
Matt T. Proud	4298bab2b0	Publicize Curator and Processors. ... This commit publicizes the curation and processor frameworks for purposes of making them available in the main processor loop.	12 years ago
Julius Volz	368a792dd2	Adjust memory queue size after change to send arrays over channel.	12 years ago
juliusv	b02debd69c	Merge pull request #205 from prometheus/julius-channel-arrays ... Send sample arrays instead of single samples over channels.	12 years ago
Julius Volz	d8110fcd9c	Send sample arrays instead of single samples over channels.	12 years ago
Matt T. Proud	3362bf36e2	Include curator status in web heads-up-display.	12 years ago
Matt T. Proud	6fac20c8af	Harden the tests against OOMs. ... This commit employs explicit memory freeing for the in-memory storage arenas. Secondarily, we take advantage of smaller channel buffer sizes in the test.	12 years ago
Matt T. Proud	66bc3711ea	Merge pull request #197 from prometheus/feature/storage/curation-table ... Add curation remark table and refactor error mgmt.	12 years ago
Matt T. Proud	d46cd089b5	Merge pull request #199 from prometheus/refactor/telemetry/api-refresh ... Refresh Prometheus client API usage.	12 years ago
Matt T. Proud	3fa260f180	Complete sentence.	12 years ago
Matt T. Proud	e527941b6a	Use tagged struct fields.	12 years ago
Matt T. Proud	a48ab34dd0	Refresh Prometheus client API usage. ... The client API has been updated per https://github.com/prometheus/client_golang/pull/9.	12 years ago
Matt T. Proud	561974308d	Add curation remark table and refactor error mgmt. ... The curator requires the existence of a curator remark table, which stores the progress for a given curation policy. The tests for the curator create an ad hoc table, but core Prometheus presently lacks said table, which this commit adds. Secondarily, the error handling for the LevelDB lifecycle functions in the metric persistence have been wrapped into an UncertaintyGroup, which mirrors some of the functions of sync.WaitGroup but adds error capturing capability to the mix.	12 years ago
Matt T. Proud	b3e34c6658	Implement batch database sample curator. ... This commit introduces to Prometheus a batch database sample curator, which corroborates the high watermarks for sample series against the curation watermark table to see whether a curator of a given type needs to be run. The curator is an abstract executor, which runs various curation strategies across the database. It remarks the progress for each type of curation processor that runs for a given sample series. A curation procesor is responsible for effectuating the underlying batch changes that are request. In this commit, we introduce the CompactionProcessor, which takes several bits of runtime metadata and combine sparse sample entries in the database together to form larger groups. For instance, for a given series it would be possible to have the curator effectuate the following grouping: - Samples Older than Two Weeks: Grouped into Bunches of 10000 - Samples Older than One Week: Grouped into Bunches of 1000 - Samples Older than One Day: Grouped into Bunches of 100 - Samples Older than One Hour: Grouped into Bunches of 10 The benefits hereof of such a compaction are 1. a smaller search space in the database keyspace, 2. better employment of compression for repetious values, and 3. reduced seek times.	12 years ago
Julius Volz	2202cd71c9	Track alerts over time and write out alert timeseries.	12 years ago
Johannes 'fish' Ziemke	1ad41d4c00	Call closer.Close() earlier.	12 years ago
Johannes 'fish' Ziemke	22da76e8ab	Close of reportTicker to exit goroutine.	12 years ago
Johannes 'fish' Ziemke	5043c6fce7	Have goroutine exit on signal via defer block.	12 years ago
juliusv	af7ddc36e2	Merge pull request #176 from prometheus/optimization/view-materialization/slice-chunking ... Truncate irrelevant chunk values.	12 years ago
Julius Volz	9b8c671ec9	Fixes/cleanups to renderView() samples truncation.	12 years ago
Matt T. Proud	05504d3642	WIP - Truncate irrelevant chunk values. ... This does not work with the view tests.	12 years ago
Matt T. Proud	a32602140e	Convert the TestInstant value into UTC. ... For the forthcoming Curator, we don't record timezone information in the samples, nor do we in the curation remarks. All times are recorded UTC. That said, for the test environment to better match production, the special instant should be in UTC.	12 years ago
Matt T. Proud	b1a8e51b07	Extract dto.SampleValueSeries into model.Values.	12 years ago
Matt T. Proud	422003da8e	Convert trailing float64s.	12 years ago