prometheus

Commit Graph

Author	SHA1	Message	Date
Oleg Zaytsev	6e2905a4d4	Use zeropool.Pool to workaround SA6002 (#12189 ) * Use zeropool.Pool to workaround SA6002 I built a tiny library called https://github.com/colega/zeropool to workaround the SA6002 staticheck issue. While searching for the references of that SA6002 staticheck issues on Github first results was Prometheus itself, with quite a lot of ignores of it. This changes the usages of `sync.Pool` to `zeropool.Pool[T]` where a pointer is not available. Also added a benchmark for HeadAppender Append/Commit when series already exist, which is one of the most usual cases IMO, as I didn't find any. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Improve BenchmarkHeadAppender with more cases Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * A little copying is better than a little dependency https://www.youtube.com/watch?v=PAAkCSZUG1c&t=9m28s Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Fix imports order Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Add license header Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Copyright should be on one of the first 3 lines Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Use require.Equal for testing I don't depend on testify in my lib, but here we have it available. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Avoid flaky test Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Also use zeropool for pointsPool in engine.go Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> --------- Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	2 years ago
Bryan Boreham	f2fd85df82	promql: use faster heap method for topk/bottomk Call `Fix()` instead of `Pop()` followed by `Push()`. This is slightly faster. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2 years ago
Bryan Boreham	cf54a14f9c	promql: add a benchmark for topk with k > 1 I picked k = 5. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2 years ago
Ganesh Vernekar	b33a382646	Remove mistakenly added file It got added in https://github.com/prometheus/prometheus/pull/11992 Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>	2 years ago
Ganesh Vernekar	211ae4f1f0	Merge pull request #12184 from codesome/edit-codeowners Remove codesome as codeowner from promql/	2 years ago
Ganesh Vernekar	22806f2e83	Remove codesome as codeowner from promql/ Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>	2 years ago
Alan Protasio	6ddadd98b4	Optimization on `mergedStringIter` (#12132 ) Optimization on NewMergedStringIter Signed-off-by: Alan Protasio <alanprot@gmail.com>	2 years ago
Alison	3ac49d4ae2	Set SourceMap to false to fix UI in MCR builds (#12175 ) * Set sourceMap to false Signed-off-by: Alison Burgess <alburgess@microsoft.com> * add sourcemap=false to package.json build Signed-off-by: Alison Burgess <alburgess@microsoft.com> * set sourcemap to true in tsconfig Signed-off-by: Alison Burgess <alburgess@microsoft.com> --------- Signed-off-by: Alison Burgess <alburgess@microsoft.com> Co-authored-by: Alison Burgess <alburgess@microsoft.com>	2 years ago
Bryan Boreham	edc8e75c40	Merge pull request #12174 from bboreham/builder-range-smaller labels: shrink stack arrays in Builder.Range	2 years ago
Oleg Zaytsev	344c630857	Fix context.Canceled wrapping in compaction We need to make sure that `tsdb_errors.NewMulti` handles the errors.Is() calls properly, like it's done in grafana/dskit. Also we need to check that `errors.Is(err, context.Canceled)`, not that `err == context.Canceled`. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	2 years ago
Oleg Zaytsev	2f32a9e3c3	Test compaction not failed during shutdown Test that blocks are not marked as "compaction failed" during shutdown. This shouldn't happen but this test currently fails. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	2 years ago
Bryan Boreham	ee1157c14a	labels: shrink stack arrays in Builder.Range Go spends some time initializing all the elements of these arrays to zero, so reduce the size from 1024 to 128. This is still much bigger than we ever expect for a set of labels. (If someone does have more than 128 labels it will still work, but via heap allocation.) Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2 years ago
Bryan Boreham	b987afa7ef	labels: simplify call to get Labels from Builder It took a `Labels` where the memory could be re-used, but in practice this hardly ever benefitted. Especially after converting `relabel.Process` to `relabel.ProcessBuilder`. Comparing the parameter to `nil` was a bug; `EmptyLabels` is not `nil` so the slice was reallocated multiple times by `append`. Lastly `Builder.Labels()` now estimates that the final size will depend on labels added and deleted. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2 years ago
Bryan Boreham	90b2f7a540	Merge pull request #12161 from codesome/update-comment tsdb: Fix a comment in tsdb/head_read.go	2 years ago
Bryan Boreham	5d90dc0627	Merge pull request #12084 from bboreham/target-labels scraping: reduce memory allocations on Target labels	2 years ago
Julien Pivotto	8ac5363590	Merge pull request #12168 from roidelapluie/booldoc Docs: use boolean instead of bool	2 years ago
Julien Pivotto	ae220724d4	Docs: use boolean instead of bool boolean makes the type consistent and clickable on https://prometheus.io/docs/prometheus/latest/configuration/configuration/ Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Julien Pivotto	de50efbf7a	Merge pull request #12165 from prometheus/release-2.43 Merge 2.43 in main	2 years ago
Björn Rabenstein	559adab471	Merge pull request #12085 from leizor/leizor/prometheus/issues/11204 Handle native histograms in remote read	2 years ago
Vernon Miller	ca0abf26c5	Adds an affirmative log message for successful WAL repair (#12135 ) * Adds an affirmative log message for successful WAL repair Signed-off-by: Vernon Miller <vernon.miller@grafana.com> Signed-off-by: Vernon Miller <96601789+aldernero@users.noreply.github.com> Co-authored-by: Ganesh Vernekar <ganeshvern@gmail.com>	2 years ago
Julien Pivotto	edfc3bcd02	Merge pull request #12164 from roidelapluie/rel-243 Address review comments on release 2.43 changelog.	2 years ago
Julien Pivotto	67f48f47c7	Address review comments Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Julien Pivotto	842ab019ed	Merge pull request #12162 from roidelapluie/rel-2.43 Release 2.43.0	2 years ago
Julien Pivotto	1070c9b06c	Release 2.43.0 Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
SuperQ	f14665b9e3	Fix docker tag sanitizer Use a `-` instead of `_` to make the docker tag also pass semver checks. Signed-off-by: SuperQ <superq@gmail.com>	2 years ago
Ganesh Vernekar	1b7d973f14	tsdb: Fix a comment in tsdb/head_read.go Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>	2 years ago
Julien Pivotto	fd8992cdbd	Merge pull request #12137 from g3offrey/fix/update-prometheus-ansible-link docs: update ansible installation link	2 years ago
Julien Pivotto	901937c6ac	Merge pull request #12142 from colega/store-the-remote-client-url-string remote.Client: store urlString	2 years ago
Julien Pivotto	bc7ce50d85	Merge pull request #12115 from prometheus/superq/go_1.20 Update Go version	2 years ago
Bryan Boreham	0c09c3feb0	scrape sync: avoid copy of labels for dropped targets Since the Target object was just created in this function, nobody else has a reference to it and there are no concerns about it being modified concurrently so we don't need to copy the value. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2 years ago
Bryan Boreham	0dfa1e73f8	scrape: use LabelsRange instead of Labels, for performance Includes a rewrite of `resolveConflictingExposedLabels` to use `labels.Builder.Get`, which simplifies it considerably. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2 years ago
Bryan Boreham	2fde2fb37d	scrape: add Target.LabelsRange This allows users of a Target to iterate labels without allocating heap memory. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2 years ago
Julien Pivotto	d08254324e	Merge pull request #12149 from roidelapluie/relrc1-updatemakefile Update makefile to better handle semver build metadata	2 years ago
Julien Pivotto	f8eb70c46d	Merge branch 'release-2.43' of https://github.com/prometheus/prometheus into release-2.43	2 years ago
Julien Pivotto	71b24c25c2	Merge pull request #12147 from roidelapluie/relrc1 2.43.0-rc.1	2 years ago
Julien Pivotto	331a7dfd21	Replace '+' with '_' in docker image tag for semver compatibility This change introduces a new variable, SANITIZED_DOCKER_IMAGE_TAG, which replaces any '+' characters in the original DOCKER_IMAGE_TAG with '_' characters. This ensures better compatibility with semver standards, particularly when using metadata in version tags. Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Julien Pivotto	2c6168be5f	Release 2.43.0-rc.1 Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Bryan Boreham	934c520d37	labels: cope with mutating Builder during Range call Although we had a different slice, the underlying memory was the same so any changes meant we could skip some values. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2 years ago
Bryan Boreham	bd23e8899d	labels: add test for Builder.Range Including mutating the Builder being Ranged over. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2 years ago
Bartlomiej Plotka	a494c44746	Merge pull request #12145 from bboreham/fix-label-builder labels: cope with mutating Builder during Range call	2 years ago
Björn Rabenstein	d303fa77b9	Merge pull request #12144 from prometheus/beorn7/doc docs: Clarify that range selectors use a closed interval	2 years ago
Bryan Boreham	3743d87c56	labels: cope with mutating Builder during Range call Although we had a different slice, the underlying memory was the same so any changes meant we could skip some values. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2 years ago
Bryan Boreham	3c4ab7a069	labels: add test for Builder.Range Including mutating the Builder being Ranged over. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2 years ago
beorn7	71c57a1292	docs: Clarify that range selectors use a closed interval Signed-off-by: beorn7 <beorn@grafana.com>	2 years ago
Abhijit Mukherjee	8f6d5dcd45	Fix: getting rid of EncOOOXOR chunk encoding (#12111 ) Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io>	2 years ago
Oleg Zaytsev	beb7d3b80f	remote.Client: store urlString During remote write, we call url.String() twice: - to add the Endpoint() to the span - to actually know where whe should send the request This value does not change over time, and it's not really that lightweight to calculate. I wrote this simple benchmark: func BenchmarkURLString(b testing.B) { u, err := url.Parse("https://remote.write.com/api/v1") require.NoError(b, err) b.Run("string", func(b testing.B) { count := 0 for i := 0; i < b.N; i++ { count += len(u.String()) } }) } And the results are ~200ns/op, 80B/op, 3 allocs/op. Yes, we're going to go to the network here, which is a huge amount of resources compared to this, but still, on agents that send 500 requests per second, that is 1500 wasteful allocations per second. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	2 years ago
g3offrey	d01c51fad0	docs: update ansible installation link Signed-off-by: g3offrey <11151445+g3offrey@users.noreply.github.com>	2 years ago
Ganesh Vernekar	58a8d526e8	Merge pull request #11992 from codesome/no-reencode-chunk Do not re-encode head chunk for ChunkQuerier	2 years ago
Ganesh Vernekar	0a3f203c63	Update tests to not assume the chunk implementation Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>	2 years ago
Ganesh Vernekar	45b025898f	Add BenchmarkHeadChunkQuerier and BenchmarkHeadQuerier Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>	2 years ago

1 2 3 4 5 ...

11132 Commits (ca6580828aeef078370116b86ff3fbe9759b75ed) All Branches Search

11132 Commits (ca6580828aeef078370116b86ff3fbe9759b75ed)

All Branches