cccbe72514
TSDB: Fix some edge cases when OOO is enabled ( #14710 )
...
Fix some edge cases when OOO is enabled
Signed-off-by: Vanshikav123 <vanshikav928@gmail.com>
Signed-off-by: Vanshika <102902652+Vanshikav123@users.noreply.github.com>
Signed-off-by: Jesus Vazquez <jesusvzpg@gmail.com>
Co-authored-by: Jesus Vazquez <jesusvzpg@gmail.com>
2024-10-23 17:34:28 +02:00
7c7116fea8
Merge pull request #15176 from jhesketh/jhesketh/round
...
Round function should ignore native histograms
2024-10-22 19:14:16 +02:00
aa81210c8b
NHCB scrape: refactor state handling and speed up scrape test ( #15193 )
...
* NHCB: scrape use state field and not booleans
From comment https://github.com/prometheus/prometheus/pull/14978#discussion_r1800898724
Also make compareLabels read only and move storeLabels to the first
processed classic histogram series.
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
* Speed up TestConvertClassicHistogramsToNHCB 3x
Reduce the startup time and timeouts
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
* lint fix
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
---------
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2024-10-22 17:49:25 +01:00
3bb5e28c6b
Merge pull request #15197 from prometheus/alexg/docs-issue-11570
...
docs: add keep_firing_for in alerting rules
2024-10-22 15:35:36 +02:00
1b4e7f74e6
feat(tools): add debug printouts to rules unit testing ( #15196 )
...
* promtool: Add debug flag for rule tests
This makes it print out the tsdb state (both input_series and rules that
are run) at the end of a test, making reasoning about tests much easier.
Signed-off-by: David Leadbeater <dgl@dgl.cx>
* Reuse generated test name from junit testing
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
---------
Signed-off-by: David Leadbeater <dgl@dgl.cx>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Co-authored-by: David Leadbeater <dgl@dgl.cx>
2024-10-22 15:24:36 +02:00
3afcda82be
docs: add keep_firing_for in alerting rules
...
Signed-off-by: alexgreenbank <alex.greenbank@grafana.com>
2024-10-22 14:19:01 +01:00
cebcdce78a
fix(storage/mergeQuerier): copy the matcjers slice before passing it to queriers as
...
some of them may alter it.
Signed-off-by: machine424 <ayoubmrini424@gmail.com>
2024-10-22 14:08:47 +02:00
eb523a6b29
fix(storage/mergeQuerier): add a reproducer for data race that occurs when one of the queriers alters the passed matchers and propose a fix
...
Signed-off-by: machine424 <ayoubmrini424@gmail.com>
2024-10-22 14:08:46 +02:00
91d80252c3
Merge pull request #15194 from prometheus/make-release-2.55
...
Create release 2.55.0
2024-10-22 11:53:52 +01:00
bb27c6b896
Create release 2.55.0
...
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-10-22 09:31:02 +01:00
ad4857de52
Merge pull request #14978 from prometheus/nhcb-scrape-impl
...
feat: NHCB: convert classic histograms to nhcb in scrape MVP
2024-10-22 07:55:58 +02:00
d2802c6fac
api: Add rule group pagination to list rules api ( #14017 )
...
* Add paginated feature to list rules api
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* Refactor to simplify code:
* Reduce number of variables
* Reduce type convesion
Signed-off-by: Raphael Silva <rapphil@gmail.com>
* Simplify paginated implementation
* Remove maxAlerts parameter.
* Reuse existing API responses by using omitempty in some fields
Signed-off-by: Raphael Silva <rapphil@gmail.com>
* Simplify pagination implementation
* Eliminate the need to sort the rule groups.
Signed-off-by: Raphael Silva <rapphil@gmail.com>
* Fix linting error
Signed-off-by: Raphael Silva <rapphil@gmail.com>
* Add more unit tests
Signed-off-by: Raphael Silva <rapphil@gmail.com>
* Update pagination parameters to be consistent with existing parameters
Signed-off-by: Raphael Silva <rapphil@gmail.com>
* Rename max_rule_groups to max_groups
Signed-off-by: Raphael Silva <rapphil@gmail.com>
* Refactor to simplify code
Signed-off-by: Raphael Silva <rapphil@gmail.com>
* Refactor to simplify the calculation of next token
Signed-off-by: Raphael Silva <rapphil@gmail.com>
* Handle corner case in pagination request
Signed-off-by: Raphael Silva <rapphil@gmail.com>
* Handle corner cases for pagination of list rules
Signed-off-by: Raphael Silva <rapphil@gmail.com>
* Update documentation for list rules parameters
Signed-off-by: Raphael Silva <rapphil@gmail.com>
* Refactor comments
Signed-off-by: Raphael Silva <rapphil@gmail.com>
* Simplify pagination implementation
* Eliminate need for extra structs to store pagination parameters
Signed-off-by: Raphael Silva <rapphil@gmail.com>
* Update docs/querying/api.md
Co-authored-by: Julius Volz <julius.volz@gmail.com>
Signed-off-by: Raphael Philipe Mendes da Silva <rapphil@gmail.com>
* Update web/api/v1/api.go
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Raphael Philipe Mendes da Silva <rapphil@gmail.com>
* Update comment describing the need for next token
Signed-off-by: Raphael Silva <rapphil@gmail.com>
---------
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
Signed-off-by: Raphael Silva <rapphil@gmail.com>
Signed-off-by: Raphael Philipe Mendes da Silva <rapphil@gmail.com>
Co-authored-by: Raphael Silva <rapphil@gmail.com>
Co-authored-by: Julius Volz <julius.volz@gmail.com>
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
2024-10-22 00:04:40 +01:00
877fd2a60e
Update scrape/scrape.go
...
Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com>
2024-10-21 16:01:34 +02:00
70e2d23027
Merge pull request #11474 from clwluvw/group-label
...
[FEATURE] rules: add labels at group level
2024-10-21 14:47:12 +01:00
25ef4d3483
benchmark, rename parser omtext_with_nhcb
...
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2024-10-21 15:40:48 +02:00
bee1eb7720
goimports run
...
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2024-10-21 14:02:32 +02:00
555bd6292a
Better docstring on test
...
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2024-10-21 13:48:21 +02:00
a6947e1e6d
Remove omcounterdata.txt as redundant
...
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2024-10-21 13:45:33 +02:00
eaee6bacc7
Fix failing benchmarks
...
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2024-10-21 13:40:16 +02:00
5ee0980cd1
Add unit test to show that current wrapper is sub-optimal
...
https://github.com/prometheus/prometheus/pull/14978#discussion_r1800755481
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2024-10-21 13:35:33 +02:00
4283ae73dc
Rename convert_classic_histograms to convert_classic_histograms_to_nhcb
...
On reviewer request.
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2024-10-21 13:22:58 +02:00
a23aed5634
More followup to #15164
...
Scrape test for NHCB modified.
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2024-10-21 11:10:50 +02:00
70742a64aa
Follow up #15178
...
Renaming
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2024-10-21 11:03:47 +02:00
482bb453c6
Followup to #15164
...
Update test cases
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2024-10-21 11:03:07 +02:00
8c1b5a6251
Merge branch 'main' into nhcb-scrape-impl
2024-10-21 11:00:41 +02:00
6b36a5592a
Merge pull request #14618 from machine424/para
...
test(cmd/prometheus): speed up test execution by t.Parallel() when possible
2024-10-20 18:19:51 +01:00
d8c1605930
Merge pull request #15164 from machine424/quantile
...
feat: normalize "le" and "quantile" labels values upon ingestion
2024-10-19 21:13:03 +02:00
cf128a0472
test(cmd/prometheus): speed up test execution by t.Parallel() when possible
...
turn some loops into subtests to make use of t.Parallel()
requires Go 1.22 to make use of https://go.dev/blog/loopvar-preview
Signed-off-by: machine424 <ayoubmrini424@gmail.com>
2024-10-18 17:52:59 +02:00
8bcb4d865d
feat: normalize "le" and "quantile" labels values upon ingestion
...
Signed-off-by: machine424 <ayoubmrini424@gmail.com>
Co-authored-by: beorn7 <beorn@grafana.com>
2024-10-18 17:37:29 +02:00
98dcd28b1a
Merge pull request #15170 from machine424/awldi
...
fix(discovery): Handle cache.DeletedFinalStateUnknown in node informers' DeleteFunc
2024-10-18 17:33:08 +02:00
421a3c22ea
scrape: provide a fallback format ( #15136 )
...
scrape: Remove implicit fallback to the Prometheus text format
Remove implicit fallback to the Prometheus text format in case of invalid/missing Content-Type and fail the scrape instead. Add ability to specify a `fallback_scrape_protocol` in the scrape config.
---------
Signed-off-by: alexgreenbank <alex.greenbank@grafana.com>
Signed-off-by: Alex Greenbank <alex.greenbank@grafana.com>
Co-authored-by: Björn Rabenstein <beorn@grafana.com>
2024-10-18 17:12:31 +02:00
5505c83a4d
Merge pull request #15167 from machine424/impor
...
feat: ProtobufParse.formatOpenMetricsFloat: improve float formatting by using strconv.AppendFloat instead of fmt.Sprint
2024-10-18 15:35:21 +02:00
c78d5b94af
Disallowing configure AM with the v1 api ( #13883 )
...
* Stop supporting Alertmanager v1
* Disallowing configure AM with the v1 api
Signed-off-by: alanprot <alanprot@gmail.com>
* Update config/config_test.go
Co-authored-by: Ayoub Mrini <ayoubmrini424@gmail.com>
Signed-off-by: Alan Protasio <alanprot@gmail.com>
* Update config/config.go
Co-authored-by: Ayoub Mrini <ayoubmrini424@gmail.com>
Signed-off-by: Alan Protasio <alanprot@gmail.com>
* Addressing coments
Signed-off-by: alanprot <alanprot@gmail.com>
* Update notifier/notifier.go
Co-authored-by: Ayoub Mrini <ayoubmrini424@gmail.com>
Signed-off-by: Alan Protasio <alanprot@gmail.com>
* Update config/config_test.go
Co-authored-by: Jan Fajerski <jan--f@users.noreply.github.com>
Signed-off-by: Alan Protasio <alanprot@gmail.com>
---------
Signed-off-by: alanprot <alanprot@gmail.com>
Signed-off-by: Alan Protasio <alanprot@gmail.com>
Co-authored-by: Ayoub Mrini <ayoubmrini424@gmail.com>
Co-authored-by: Jan Fajerski <jan--f@users.noreply.github.com>
2024-10-18 15:23:14 +02:00
18b81ad79d
feat: ProtobufParse.formatOpenMetricsFloat: improve float formatting by using strconv.AppendFloat instead of fmt.Sprint
...
Signed-off-by: machine424 <ayoubmrini424@gmail.com>
2024-10-18 15:19:55 +02:00
754c104a3e
Merge pull request #15173 from prometheus/merge-2.55-into-main-3
...
Merge release-2.55 into main (interim)
2024-10-18 10:28:20 +01:00
763cbdf35f
Merge pull request #15180 from prometheus/ooo-nh-corrupt-chunk
...
fix(tsdb): populateWithDelChunkSeriesIterator corrupting chunk meta
2024-10-18 10:49:02 +02:00
a4083f14e8
Fix populateWithDelChunkSeriesIterator corrupting chunk meta
...
When handling recoded histogram chunks the min time of the chunk is
updated by mistake. It should only update when the chunk is completely new.
Otherwise the ongoing chunk's meta will be later than the previously
written samples in it.
Same bug as https://github.com/prometheus/prometheus/pull/14629
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2024-10-18 10:34:22 +02:00
e6a682f046
Reproduce populateWithDelChunkSeriesIterator corrupting chunk meta
...
When handling recoded histogram chunks the min time of the chunk is
updated by mistake. It should only update when the chunk is completely
new.
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2024-10-18 10:34:22 +02:00
efc43d0714
s/scrape_classic_histograms/always_scrape_classic_histograms (3.0 breaking change) ( #15178 )
...
This is for readability, especially when we can converting to nhcb option.
See discussion https://cloud-native.slack.com/archives/C077Z4V13AM/p1729155873397889
Signed-off-by: bwplotka <bwplotka@gmail.com>
2024-10-18 08:32:15 +01:00
5ee698de2c
Apply review comments
...
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2024-10-17 12:55:45 +02:00
04b827dd77
Merge branch 'main' into nhcb-scrape-impl
2024-10-17 12:34:44 +02:00
2cabd1b707
config: remove expand-external-labels flag in release 3.0 ( #14657 )
...
remove expand-external-labels feature flag
and enabled env arg expansion for external labels by default.
Signed-off-by: jyz0309 <45495947@qq.com>
2024-10-17 10:25:05 +02:00
14ef1ce8ab
Round function should ignore native histograms
...
As per the documentation, native histograms are skipped. This is in line with other simpleFunc's.
Signed-off-by: Joshua Hesketh <josh@nitrotech.org>
2024-10-17 15:39:48 +11:00
1f9e6341f9
Merge pull request #15007 from prometheus/prep-2.55.0-rc.1
...
Prepare release 2.55.0-rc.1
2024-10-16 17:46:06 +01:00
2788d2038e
Add CHANGELOG entry for #12532
...
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-10-16 15:08:58 +01:00
6ce21b8399
Merge pull request #15172 from krajorama/update-client-golang
...
chore(deps): update client_golang from 1.20.4 to 1.20.5
2024-10-16 15:26:41 +02:00
5dd5aec0e6
Merge pull request #14599 from machine424/sigsegv
...
test(tsdb): add a reproducer for https://github.com/prometheus/prometheus/issues/14422
2024-10-16 14:16:54 +01:00
a846bf9a5e
Merge branch 'release-2.55' into merge-2.55-into-main-3
2024-10-16 14:08:54 +01:00
4271670a82
chore(deps): update client_golang from 1.20.4 to 1.20.5
...
Ref: https://github.com/prometheus/client_golang/releases/tag/v1.20.5
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2024-10-16 15:02:13 +02:00
5a4e4f6936
Fix stddev/stdvar when aggregating histograms, NaNs, and infinities ( #14941 )
...
promql: Fix stddev/stdvar when aggregating histograms, NaNs, and Infs
Native histograms are ignored when calculating stddev or stdvar.
However, for the first series of each group, a `groupedAggregation` is
always created. If the first series that was encountered is a histogram
then it acts as the equivalent of a 0 point.
This change creates the first `groupedAggregation` with the `seen` field set to `false` if the point is a
histogram, thus ignoring it like the rest of the aggregation function does. A new `groupedAggregation`
will then be created once an actual float value is encountered.
This commit also sets the `floatValue` field of the `groupedAggregation` to `NaN`, if the first
float value of a group is `NaN` or `±Inf`, so that the outcome is consistently `NaN` once those
values are in the mix.
(The added tests fail without this change).
Signed-off-by: Joshua Hesketh <josh@nitrotech.org>
Signed-off-by: beorn7 <beorn@grafana.com>
---------
Signed-off-by: Joshua Hesketh <josh@nitrotech.org>
Signed-off-by: beorn7 <beorn@grafana.com>
Co-authored-by: beorn7 <beorn@grafana.com>
2024-10-16 15:00:46 +02:00
Vanshika