68 Commits (c92673fb1480cd6e3404a004522cbb851be4115d)

Author	SHA1	Message	Date
Simon Pasquier	71e0ec7512	improve unused recipe for go modules ... Signed-off-by: Simon Pasquier <spasquie@redhat.com>	6 years ago
Simon Pasquier	79e0fb5a3d	Tidy up Makefile.common ... Signed-off-by: Simon Pasquier <spasquie@redhat.com>	6 years ago
Simon Pasquier	ac16ef8f0e	Add missing tools.go ... Also rearrange the code to be more consistent. Signed-off-by: Simon Pasquier <spasquie@redhat.com>	6 years ago
Simon Pasquier	b9f824e617	try go install honnef.co/tools/cmd/staticcheck ... Signed-off-by: Simon Pasquier <spasquie@redhat.com>	6 years ago
Simon Pasquier	ea18ea66b1	GOOS= and GOARCH= ... Signed-off-by: Simon Pasquier <spasquie@redhat.com>	6 years ago
Simon Pasquier	cc1b953394	go list -m honnef.co/go/tools ... Signed-off-by: Simon Pasquier <spasquie@redhat.com>	6 years ago
Simon Pasquier	c141833d45	*: use staticcheck@next to support Go modules ... Signed-off-by: Simon Pasquier <spasquie@redhat.com>	6 years ago
Simon Pasquier	80de93b6af	*: support for Go modules ... Signed-off-by: Simon Pasquier <spasquie@redhat.com>	6 years ago
Bartek Plotka	c3434a39b7	proto: Allow reproducible proto generation. ... Current way of setting prometheus project to generate repo is tedious. If you just go install packages described in README.md it ends up with those (non buildable code) ``` ../../../prompb/remote.pb.go:61:34: undefined: "github.com/prometheus/prometheus/vendor/github.com/gogo/protobuf/proto".InternalMessageInfo ../../../prompb/remote.pb.go:109:33: undefined: "github.com/prometheus/prometheus/vendor/github.com/gogo/protobuf/proto".InternalMessageInfo ../../../prompb/remote.pb.go:164:34: undefined: "github.com/prometheus/prometheus/vendor/github.com/gogo/protobuf/proto".InternalMessageInfo ../../../prompb/remote.pb.go:214:27: undefined: "github.com/prometheus/prometheus/vendor/github.com/gogo/protobuf/proto".InternalMessageInfo ../../../prompb/remote.pb.go:284:33: undefined: "github.com/prometheus/prometheus/vendor/github.com/gogo/protobuf/proto".InternalMessageInfo ``` The issue is that the guide presented in proto folder is asking to install some GO packages. It does not mention from what version and there is strong mismatch between those used to generate proto and those that are vendored and used to run the code later... The particular outdated packages in vendor are: `github.com/gogo/protobuf` and `google.golang.org/grpc`. Just updating vendor would be not enough, as it would only tmp fix. I propose adding script that will parse version from vendor.json and install correct version. Changes: - Added script that uses packages in *exactly* the same version the Go code is build against later. - Regenerated proto with those pinned deps. - Updated REAMDE.md - Added `make proto`Current way of setting prometheus project to generate code from proto files is tedious. If you just go install packages described in README.md, it ends up with this (non buildable code) ``` ../../../prompb/remote.pb.go:61:34: undefined: "github.com/prometheus/prometheus/vendor/github.com/gogo/protobuf/proto".InternalMessageInfo ../../../prompb/remote.pb.go:109:33: undefined: "github.com/prometheus/prometheus/vendor/github.com/gogo/protobuf/proto".InternalMessageInfo ../../../prompb/remote.pb.go:164:34: undefined: "github.com/prometheus/prometheus/vendor/github.com/gogo/protobuf/proto".InternalMessageInfo ../../../prompb/remote.pb.go:214:27: undefined: "github.com/prometheus/prometheus/vendor/github.com/gogo/protobuf/proto".InternalMessageInfo ../../../prompb/remote.pb.go:284:33: undefined: "github.com/prometheus/prometheus/vendor/github.com/gogo/protobuf/proto".InternalMessageInfo ``` The issue is that the guide presented in proto folder is asking to install some GO packages. It does not mention from what version and there is strong mismatch between those used to generate proto and those that are vendored and used to run the code later... The particular outdated packages in vendor are: `github.com/gogo/protobuf` and `google.golang.org/grpc`. Just updating vendor would be not enough, as it would only tmp fix. I propose adding script that will parse version from vendor.json and install correct version. Changes: - Added script that uses packages in *exactly* the same version the Go code is build against later. - Regenerated proto with those pinned deps. - Updated REAMDE.md - Added `make proto` Signed-off-by: Bartek Plotka <bwplotka@gmail.com>	6 years ago
Simon Pasquier	a827f91aff	Makefile: improve 'make style' reporting ... Signed-off-by: Simon Pasquier <spasquie@redhat.com>	6 years ago
Paul Gier	cfb3f31538	add prefix "common-" to make target names ... This allows rules to be overridden with warnings about conflicting target names. Signed-off-by: Paul Gier <pgier@redhat.com>	6 years ago
Ben Kochie	709ad10d97	Reduce CircleCI duplication (#4335) ... Reduce the duplication of per-project specifics in the CircleCI config. * Add docker repo variable, default to docker hub. * Add make targets for docker push and tag latest. Signed-off-by: Ben Kochie <superq@gmail.com>	6 years ago
Simon Pasquier	45b8dea320	Makefile: update .PHONY target (#4234) ... Makefile: update .PHONY target * Move .PHONY declarations near their targets Signed-off-by: Simon Pasquier <spasquie@redhat.com>	7 years ago
Ben Kochie	4a4e8a7d3b	Fix spelling in Makefile.common. (#4105) ... Signed-off-by: Ben Kochie <superq@gmail.com>	7 years ago
Krasi Georgiev	98c51d241b	run the style target to fail if the code is not properly formated ... Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>	7 years ago
Krasi Georgiev	0b0c9f4b6b	unused target didn't trigger an error for unused packages (#4101) ... Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>	7 years ago
Krasi Georgiev	416db814e8	use package shorthand selection that excludes vendored. (#4100) ... Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>	7 years ago
Krasi Georgiev	3f2b2c50dd	use the Makefile.common (#3978) ... split common targets in a Makefile.common to reuse it across projects Signed-off-by: Krasi Georgiev <krasi.root@gmail.com>	7 years ago