prometheus

Commit Graph

Author	SHA1	Message	Date
Matthieu MOREL	bae9a21200	Merge branch 'main' into linter/nilerr Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	2 years ago
beorn7	5b53aa1108	style: Replace `else if` cascades with `switch` Wiser coders than myself have come to the conclusion that a `switch` statement is almost always superior to a statement that includes any `else if`. The exceptions that I have found in our codebase are just these two: * The `if else` is followed by an additional statement before the next condition (separated by a `;`). * The whole thing is within a `for` loop and `break` statements are used. In this case, using `switch` would require tagging the `for` loop, which probably tips the balance. Why are `switch` statements more readable? For one, fewer curly braces. But more importantly, the conditions all have the same alignment, so the whole thing follows the natural flow of going down a list of conditions. With `else if`, in contrast, all conditions but the first are "hidden" behind `} else if `, harder to spot and (for no good reason) presented differently from the first condition. I'm sure the aforemention wise coders can list even more reasons. In any case, I like it so much that I have found myself recommending it in code reviews. I would like to make it a habit in our code base, without making it a hard requirement that we would test on the CI. But for that, there has to be a role model, so this commit eliminates all `if else` occurrences, unless it is autogenerated code or fits one of the exceptions above. Signed-off-by: beorn7 <beorn@grafana.com>	2 years ago
beorn7	c3c7d44d84	lint: Adjust to the lint warnings raised by current versions of golint-ci We haven't updated golint-ci in our CI yet, but this commit prepares for that. There are a lot of new warnings, and it is mostly because the "revive" linter got updated. I agree with most of the new warnings, mostly around not naming unused function parameters (although it is justified in some cases for documentation purposes – while things like mocks are a good example where not naming the parameter is clearer). I'm pretty upset about the "empty block" warning to include `for` loops. It's such a common pattern to do something in the head of the `for` loop and then have an empty block. There is still an open issue about this: https://github.com/mgechev/revive/issues/810 I have disabled "revive" altogether in files where empty blocks are used excessively, and I have made the effort to add individual `// nolint:revive` where empty blocks are used just once or twice. It's borderline noisy, though, but let's go with it for now. I should mention that none of the "empty block" warnings for `for` loop bodies were legitimate. Signed-off-by: beorn7 <beorn@grafana.com>	2 years ago
Matthieu MOREL	fb3eb21230	enable gocritic, unconvert and unused linters Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	2 years ago
Julien Pivotto	5f3a02f1e2	Update go dependencies Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Fish-pro	43d77f7c41	Use http constants instead of string Signed-off-by: Fish-pro <zechun.chen@daocloud.io>	2 years ago
Peter Nicholson	138a1362d8	Add support for EndpointSlice conditions Signed-off-by: Peter Nicholson <petergoods@hotmail.com>	2 years ago
Frederic Branczyk	9f91215bf6	Merge pull request #11844 from bawhetst/add-pod-container-id discovery/kubernetes: add container ID as a meta label for pod targets	2 years ago
Bryan Boreham	b768247df8	Merge pull request #11760 from bboreham/discovery-log-setname service discovery: add name to log messages	2 years ago
Bryan Boreham	2f58be840d	service discovery: add config name to log messages This makes it easier to connect a log message with the config it relates to. Each SD config has a name, either the scrape job name or something like "config-0" for Alertmanager config. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2 years ago
Ben Whetstone	32e9f6a39c	Add container ID as a meta label for pod targets Signed-off-by: Ben Whetstone <ben.whetstone@sysdig.com>	2 years ago
Jens Erat	728fdc959e	Kubernetes SD: disable resync timer While originally the resync period also forced refreshing from Kubernetes API server, this has been removed for some years now because watching the API server got more stable [1]. Today, this just results in all entities being sent to the service discovery again, which is valid from a general Prometheus perspective, but results in unnecessary CPU load and also breaks service discovery metrics. In especially, this makes monitoring "do we actually observe changes from Kubernetes API server" impossible (receiving constant updates from Kubernetes service discovery is a pretty valid assumption, for example nodes get frequent status updates, ...). Signed-off-by: Jens Erat <jens.erat@mercedes-benz.com>	2 years ago
David Fridman	52adf55631	Add VM size label to azure service discovery (#11575 ) (#11650 ) * Add VM size label to azure service discovery (#11575) Signed-off-by: davidifr <davidfr.mail@gmail.com> * Add VM size label to azure service discovery (#11575) Signed-off-by: davidifr <davidfr.mail@gmail.com> * Add VM size label to azure service discovery (#11575) Signed-off-by: davidifr <davidfr.mail@gmail.com> Signed-off-by: davidifr <davidfr.mail@gmail.com>	2 years ago
Julien Pivotto	3677d61a4b	Update kubernetes dependencies A new API is available for AddEventHandlers, to get errors but also be able to cancel handlers. Doing the easy thing for the release, which is just to log errors. We could see how to improve this in the future to handle the errors properly and cancel the handlers. Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Levi Harrison	f81fae2414	Add common HTTP client to AWS SDs (#11611 ) * Common client in EC2 and Lightsail Signed-off-by: Levi Harrison <git@leviharrison.dev> * Azure -> AWS Signed-off-by: Levi Harrison <git@leviharrison.dev> Signed-off-by: Levi Harrison <git@leviharrison.dev>	2 years ago
Michael Fuller	15ba7a0d2d	file sd: create and increment an inotify error counter when file-SD i… (#11066 ) * file sd: create and increment an inotify error counter when file-SD is unable to watch files. Additionally, order metrics alphabetically. Signed-off-by: Michael Fuller <mfuller@digitalocean.com> * file.go: consistent naming and help for prometheus_sd_file_watcher_errors_total Signed-off-by: Michael Fuller <mfuller@digitalocean.com> Signed-off-by: Michael Fuller <mfuller@digitalocean.com> Co-authored-by: Michael Fuller <mfuller@digitalocean.com>	2 years ago
Julien Pivotto	7a67a728a8	Followup on OVHCloud merge (#11529 ) Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu> Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Marine Bal	16c3aa75c0	Add service discovery for OvhCloud (#10802 ) * feat(ovhcloud): add ovhcloud management Signed-off-by: Marine Bal <marine.bal@corp.ovh.com> Co-authored-by: Arnaud Sinays <sinaysarnaud@gmail.com>	2 years ago
Viacheslav Panasovets	3d2e18bad5	Fix time.Since() in defer. Wrap in anonymous function (#11489 ) Function arguments in defer evaluated during definition of defer, not during execution Signed-off-by: Slavik Panasovets <slavik@google.com> Signed-off-by: Slavik Panasovets <slavik@google.com>	2 years ago
David Cañadillas	51a44e6657	Adding Consul Enterprise Admin Partitions (#11482 ) * Adding Consul Enterprise Admin Partitions Signed-off-by: dcanadillas <dcanadillas@hashicorp.com>	2 years ago
Maciej Borsz	56eba3ace2	Use protobuf encoding in client-go Signed-off-by: Maciej Borsz <maciejborsz@google.com>	2 years ago
Brian Candler	4a493db432	Add __meta_ec2_region label (#11326 ) Fixes #11320 Signed-off-by: Brian Candler <b.candler@pobox.com> Signed-off-by: Brian Candler <b.candler@pobox.com>	2 years ago
Julien Pivotto	96d5a32659	Update go to 1.19, set min version to 1.18 (#11279 ) * Update go to 1.19, set min version to 1.18 Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu> * Update golangci-lint Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu> Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Julien Pivotto	15fa34936b	PuppetDB SD: Add __meta_puppetdb_query label (#11238 ) Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Cosrider	bef6556ca5	delete redundant alias (#11180 ) Signed-off-by: Cosrider <cosrider7@gmail.com> Signed-off-by: Cosrider <cosrider7@gmail.com>	2 years ago
Renato Costa	d521933053	Fix incorrect use of loop variable in parallel test (#11205 ) This fixes an occurrence of a loop variable being captured in a parallel test (`TestInitialUpdate`). Prior to this commit, only the last test case declared in that test would actually execute. To work around this problem, we create a copy of the range variable before the paralllel test, as suggested in the documentation for the `testing` package: https://pkg.go.dev/testing#hdr-Subtests_and_Sub_benchmarks The test immediately after the one fixed here (`TestInvalidFile`) followed the same pattern but correctly created a copy of the loop variable, illustrating how easy it is to forget to do this in practice. Issue was automatically found using the `loopvarcapture` linter. Signed-off-by: Renato Costa <renato@cockroachlabs.com> Signed-off-by: Renato Costa <renato@cockroachlabs.com>	2 years ago
Karl Piplies	3782cb40d5	add loadbalancerip to service labels Signed-off-by: Karl Piplies <karl.piplies@mercedes-benz.com>	2 years ago
David Leadbeater	d677ec489e	Support using MX records for DNS discovery (#10099 ) It's currently possible to use blackbox_exporter to probe MX records themselves. However it's not possible to do an end-to-end test, like is possible with SRV records. This makes it possible to use MX records as a source of hostnames in the same way as SRV records. Signed-off-by: David Leadbeater <dgl@dgl.cx>	2 years ago
Abirdcfly	465558e93a	fix minor code unreachability error (#11040 ) Signed-off-by: Abirdcfly <fp544037857@gmail.com>	2 years ago
Frederic Branczyk	414c3e549c	Merge pull request #11002 from yngwiewang/feature/k8s-service-port-number feat:(kubernetes_sd): add __meta_kubernetes_service_port_number (#10945)	2 years ago
Robert Fratto	97be65387d	discovery/kubernetes: fix broken tests Signed-off-by: Robert Fratto <robertfratto@gmail.com>	2 years ago
Robert Fratto	823d24d1e9	discovery/kubernetes: add container image as metadata This commits adds a __meta_kubernetes_pod_container_image as a new metadata label. This can be used to alert on mismatched versions of targets who don't have a build_info metric, as well as injecting it into log lines for other consumers of discovery/kubernetes (e.g., Promtail). Signed-off-by: Robert Fratto <robertfratto@gmail.com>	2 years ago
yngwiewang	1abbf5a5c5	add __meta_kubernetes_service_port_number (#10945 ) Signed-off-by: yngwiewang <yngwiewang@163.com>	2 years ago
Julien Pivotto	466f053a6e	nomad: Use failuresCount counter Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Julien Pivotto	d9347bf128	nomad: Fix documentation and comments. Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Bram Vogelaar	4456dcc26e	feat(nomad): add nomad service discovery Signed-off-by: Bram Vogelaar <bram@attachmentgenie.com>	2 years ago
Filip Petkovski	05da373dcb	kubernetes_sd: Allow attaching node labels for endpoint role The Kubernetes service discovery can only add node labels to targets from the pod role. This commit extends this functionality to the endpoints and endpointslices roles. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>	2 years ago
Sebastian Poxhofer	3f9a9d1e62	chore(discoveryManager): expose Discoverer refresh function (#10531 ) Signed-off-by: secustor <sebastian@poxhofer.at>	2 years ago
Julien Pivotto	e4a09f2b4b	uyuni: Use default HTTP client and set relative paths (#10814 ) Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	3 years ago
Filip Petkovski	7a78897d0b	Improve reliability of Kubernetes SD tests (#10761 ) The tests for Kubernetes SD rely on comparing target groups by first serializing them to JSON. However, the target group MarshalJSON function only serializes the __address__ label, which makes eliminates all other labels from the comparison. This commit implements a separate marshaling function intended for use in Kubernetes SD tests. The function serializes all target labels, making comparisons much more reliable. The commit also fixes all tests that started to fail due to the newly introduced change. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>	3 years ago
Julien Pivotto	143a760e76	Hetzner SD: Implement set directory (#10813 ) Makes path relative to Prometheus config file. Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	3 years ago
Matthieu MOREL	f43749e82f	refactor (discovery): move from github.com/pkg/errors to 'errors' and 'fmt' (#10807 ) Signed-off-by: Matthieu MOREL <mmorel-35@users.noreply.github.com> Co-authored-by: Matthieu MOREL <mmorel-35@users.noreply.github.com>	3 years ago
David Leadbeater	57f4aab27d	Update godoc links and remove note about TSDB versioning (#10754 ) Signed-off-by: David Leadbeater <dgl@dgl.cx>	3 years ago
Julien Pivotto	1afe72f0af	vultr: ram is in mb, not bytes Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	3 years ago
Julien Pivotto	c9d4e5fc94	vultr: minor fixups Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	3 years ago
David Dymko	3ef153b00c	vultr integration Signed-off-by: David Dymko <dymkod@gmail.com>	3 years ago
Felix Ehrenpfort	ce3bc818a8	Add service discovery for IONOS Cloud (#10514 ) * Add service discovery for IONOS Cloud Signed-off-by: Felix Ehrenpfort <felix@ehrenpfort.de>	3 years ago
TJ Hoplock	c40e269c3e	feat: add linode SD failure count metric (#10673 ) This commit introduces a new metric to count the number of failed requests to Linode's API when using Linode SD. Resolves #10672, inspired by #10476. _Note_: this doens't count failures when polling the `/account/events` endpoint, as a `401` there is how we determine if the supplied token has the needed API scopes to do event polling vs full refreshes each interval. Signed-off-by: TJ Hoplock <t.hoplock@gmail.com>	3 years ago
Matthieu MOREL	e2ede285a2	refactor: move from io/ioutil to io and os packages (#10528 ) * refactor: move from io/ioutil to io and os packages * use fs.DirEntry instead of os.FileInfo after os.ReadDir Signed-off-by: MOREL Matthieu <matthieu.morel@cnp.fr>	3 years ago
David Heap	685493187e	Support numerical labels in PuppetDB service discovery (#10633 ) Fixes #10626 where previously only bool and string were supported Signed-off-by: David Heap <david.heap@tnp.net.uk>	3 years ago

1 2 3 4 5 ...

607 Commits (c06c02b3b10b3d98bd7d59400d0a1b3762e90af3)