Jeanette Tan
3ccaaa40ba
Fix according to code review
...
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2023-11-02 13:37:07 +08:00
György Krajcsovits
4296ecbd14
tsdb/compact_test.go: test mixed typed series with PopulateBlock
...
Add testcase and update test so that it can test native histograms as well.
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2023-11-02 13:33:42 +08:00
Jeanette Tan
27abf09e7f
Fix missing MinTime in histogram chunks
...
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2023-11-02 13:33:39 +08:00
Jeanette Tan
2f7060bd5a
Expand TestPopulateWithTombSeriesIterators to test earlier deletion intervals for histogram chunks as well as time-overlapping chunks
...
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2023-11-02 13:33:35 +08:00
Jeanette Tan
7a4a1127b7
Expand TestPopulateWithTombSeriesIterators to test min max times of chunks, including mixed chunks
...
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2023-11-02 13:33:33 +08:00
Jeanette Tan
04aabdd7cc
Refactor TestPopulateWithDelSeriesIterator unit tests to reuse more code
...
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2023-11-02 13:33:30 +08:00
Jeanette Tan
46be85f2dc
Make TestPopulateWithDelSeriesIterator tests cover histogram types and check MinTime
...
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2023-11-02 13:33:26 +08:00
Charles Korn
8274e248ad
Fix issue where `concatenatingChunkIterator` can obscure errors.
...
Signed-off-by: Charles Korn <charles.korn@grafana.com>
2023-11-02 15:29:09 +11:00
Levi Harrison
8b87f3bbf1
Release 2.48.0-rc.2
...
Signed-off-by: Levi Harrison <git@leviharrison.dev>
2023-11-01 21:19:24 -04:00
Levi Harrison
287511d92f
Merge pull request #13066 from prometheus/superq/pick_timestamp
...
scrape: Added trackTimestampsStaleness configuration option
2023-11-01 21:00:43 -04:00
dependabot[bot]
2d6f27f10a
build(deps): bump actions/checkout from 4.1.0 to 4.1.1 in /scripts
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](8ade135a41...b4ffde65f4
)
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-11-01 23:55:51 +00:00
dependabot[bot]
1103569841
build(deps): bump the go-opentelemetry-io group with 2 updates
...
Bumps the go-opentelemetry-io group with 2 updates: [go.opentelemetry.io/collector/pdata](https://github.com/open-telemetry/opentelemetry-collector ) and [go.opentelemetry.io/collector/semconv](https://github.com/open-telemetry/opentelemetry-collector ).
Updates `go.opentelemetry.io/collector/pdata` from 1.0.0-rcv0016 to 1.0.0-rcv0017
- [Release notes](https://github.com/open-telemetry/opentelemetry-collector/releases )
- [Changelog](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG-API.md )
- [Commits](https://github.com/open-telemetry/opentelemetry-collector/compare/pdata/v1.0.0-rcv0016...pdata/v1.0.0-rcv0017 )
Updates `go.opentelemetry.io/collector/semconv` from 0.87.0 to 0.88.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-collector/releases )
- [Changelog](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG-API.md )
- [Commits](https://github.com/open-telemetry/opentelemetry-collector/compare/v0.87.0...v0.88.0 )
---
updated-dependencies:
- dependency-name: go.opentelemetry.io/collector/pdata
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: go-opentelemetry-io
- dependency-name: go.opentelemetry.io/collector/semconv
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: go-opentelemetry-io
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-11-01 23:44:15 +00:00
dependabot[bot]
ae2b00d77d
build(deps): bump the k8s-io group with 2 updates
...
Bumps the k8s-io group with 2 updates: [k8s.io/api](https://github.com/kubernetes/api ) and [k8s.io/client-go](https://github.com/kubernetes/client-go ).
Updates `k8s.io/api` from 0.28.2 to 0.28.3
- [Commits](https://github.com/kubernetes/api/compare/v0.28.2...v0.28.3 )
Updates `k8s.io/client-go` from 0.28.2 to 0.28.3
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md )
- [Commits](https://github.com/kubernetes/client-go/compare/v0.28.2...v0.28.3 )
---
updated-dependencies:
- dependency-name: k8s.io/api
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/client-go
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-11-01 23:43:56 +00:00
dependabot[bot]
1c272a1f4f
build(deps): bump ossf/scorecard-action from 2.2.0 to 2.3.1
...
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action ) from 2.2.0 to 2.3.1.
- [Release notes](https://github.com/ossf/scorecard-action/releases )
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md )
- [Commits](08b4669551...0864cf1902
)
---
updated-dependencies:
- dependency-name: ossf/scorecard-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-11-01 23:32:14 +00:00
dependabot[bot]
b4448e0ef2
build(deps): bump actions/checkout from 4.1.0 to 4.1.1
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](8ade135a41...b4ffde65f4
)
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-11-01 23:32:08 +00:00
dependabot[bot]
b9f75ceedd
build(deps): bump github/codeql-action from 2.21.9 to 2.22.5
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 2.21.9 to 2.22.5.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](ddccb87388...74483a38d3
)
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-11-01 23:32:04 +00:00
dependabot[bot]
f9d060c65f
build(deps): bump github.com/prometheus/common
...
Bumps [github.com/prometheus/common](https://github.com/prometheus/common ) from 0.44.0 to 0.45.0.
- [Release notes](https://github.com/prometheus/common/releases )
- [Commits](https://github.com/prometheus/common/compare/v0.44.0...v0.45.0 )
---
updated-dependencies:
- dependency-name: github.com/prometheus/common
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-11-01 23:30:13 +00:00
Matthieu MOREL
7eaefcf379
ci(lint): enable errorlint on scrape ( #12923 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Jesus Vazquez <jesusvazquez@users.noreply.github.com>
Co-authored-by: Jesus Vazquez <jesusvazquez@users.noreply.github.com>
2023-11-01 20:06:46 +01:00
George Krajcsovits
e399395b01
Native histograms vs labels ( #13005 )
...
* Document le and quantile label transition due to native histograms
Fixes : #12984
For full explanation see the related issue. The le and quantile labels
are formatted as float with trailing .0 for whole number values when
native histograms is enabled, e.g. 10.0. This changes the resulting series
in Prometheus if previously we scraped the whole number itself, e.g. 10
over the text format.
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
---------
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com>
2023-11-01 18:30:34 +01:00
Björn Rabenstein
a43669e611
Merge pull request #12928 from alexandear/ci-enable-godot
...
ci(lint): enable godot; append dot at the end of comments
2023-11-01 17:15:41 +01:00
Julien Pivotto
fed6f81377
scrape: Added trackTimestampsStaleness configuration option
...
Add the ability to track staleness when an explicit timestamp is set.
Useful for cAdvisor.
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
2023-11-01 15:34:19 +01:00
Matthias Loibl
6518d6fdec
Merge pull request #13036 from prometheus/codeowners-mixins
...
Assign new code owners for prometheus-mixin
2023-11-01 11:47:58 +01:00
Julien Pivotto
79bbfe601f
Merge pull request #13060 from roidelapluie/trackTimestampsStaleness
...
scrape: Added trackTimestampsStaleness configuration option
2023-10-31 19:34:31 -04:00
Charles Korn
5184368db6
Fix issue where `chainSampleIterator` can obscure errors ( #13006 )
...
* Fix issue where `chainSampleIterator` can obscure errors
Signed-off-by: Charles Korn <charles.korn@grafana.com>
* Address PR feedback.
Signed-off-by: Charles Korn <charles.korn@grafana.com>
---------
Signed-off-by: Charles Korn <charles.korn@grafana.com>
2023-10-31 22:35:17 +00:00
Julien Pivotto
84aadfc45b
scrape: Added trackTimestampsStaleness configuration option
...
Add the ability to track staleness when an explicit timestamp is set.
Useful for cAdvisor.
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
2023-10-31 16:58:42 -04:00
Julien Pivotto
12dd0cb53b
Merge pull request #13034 from charleskorn/rule-evaluation-logs
...
Include trace ID in log lines emitted during rule evaluation
2023-10-31 15:53:17 -04:00
Julien Pivotto
f568221610
Merge pull request #13057 from prometheus/release-2.48
...
Merge release-2.48 back into main
2023-10-31 15:24:39 -04:00
Oleksandr Redko
fa90ca46e5
ci(lint): enable godot; append dot at the end of comments
...
Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>
2023-10-31 19:53:38 +02:00
Björn Rabenstein
96179fe06a
Merge pull request #13055 from prometheus/beorn7/storage
...
storage: Fix mixed samples handling in sampleRing
2023-10-31 17:10:24 +01:00
beorn7
4696b46dd5
storage: Fix mixed samples handling in sampleRing
...
Two issues are fixed here, that lead to the same problem:
1. If `newSampleRing` is called with an unknown ValueType including
ValueNone, we have initialized the interface buffer (`iBuf`).
However, we would still use a specialized buffer for the first
sample, opportunistically assuming that we might still not
encounter mixed samples and we should go down the more efficient
road.
2. If the `sampleRing` is `reset`, we leave all buffers alone,
including `iBuf`, which is generally fine, but not for `iBuf`, see
below.
In both cases, `iBuf` already contains values, but we will fill one of
the specialized buffers first. Once we then actually encounter mixed
samples, the content of the specialized buffer is copied into `iBuf`
using `append`. That's by itself the right idea because `iBuf` might
be `nil`, and even if not, it might or might not have the right
capacity. However, this approach assumes that `iBuf` is empty, or more
precisely has a length of zero.
This commit makes sure that `iBuf` does not get needlessly initialized
in `newSampleRing` and that it is emptied upon `reset`.
A test case is added to demonstrate both issues above.
Signed-off-by: beorn7 <beorn@grafana.com>
2023-10-31 16:18:09 +01:00
dependabot[bot]
16c8d445fd
build(deps): bump github/codeql-action from 1.0.26 to 2.21.9 ( #12915 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 1.0.26 to 2.21.9.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](https://github.com/github/codeql-action/compare/v1.0.26...ddccb873888234080b77e9bc2d4764d5ccaaccf9 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-31 12:49:04 +01:00
dependabot[bot]
99a9602a87
build(deps): bump actions/checkout from 3.0.0 to 4.1.0 ( #12917 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3.0.0 to 4.1.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v3...8ade135a41bc03ea155e62e844d188df1ea18608 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-31 12:48:17 +01:00
Matthieu MOREL
68e6b4dd34
ci(lint): enable errorlint on discovery ( #12918 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2023-10-31 12:46:55 +01:00
Oleksandr Redko
8e5f0387a2
ci(lint): enable nolintlint and remove redundant comments ( #12926 )
...
Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>
2023-10-31 12:35:13 +01:00
Matthieu MOREL
1ec6e407d0
ci(lint): enable errorlint on storage ( #12935 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2023-10-31 12:15:30 +01:00
Matthias Loibl
de836737ad
Assign new code owners for prometheus-mixin
...
Signed-off-by: Matthias Loibl <mail@matthiasloibl.com>
2023-10-31 12:05:31 +01:00
Charles Korn
9a8dbf06bc
Address PR feedback
...
Co-authored-by: Julien Pivotto <roidelapluie@o11y.eu>
Signed-off-by: Charles Korn <charleskorn@users.noreply.github.com>
2023-10-31 09:56:05 +11:00
Bryan Boreham
6722a5bb86
Merge pull request #13043 from bboreham/remove-h
...
PromQL: reduce garbage in range-query evaluation
2023-10-30 16:40:20 +00:00
Julien Pivotto
0c1e447d68
Exclude alerts: improve documentation ( #13046 )
...
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
2023-10-30 15:08:11 +00:00
Julien Pivotto
156a23d06d
Merge pull request #12999 from rajagopalanand/filter-alerts
...
Adding a query parameter to filter out active alerts
2023-10-30 13:10:24 +01:00
Bryan Boreham
49c5e7afe1
PromQL: reduce garbage in range-query evaluation
...
The temporary variable was allocated on the heap, and it is unnecessary.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-10-29 19:45:06 +00:00
Björn Rabenstein
e9b94515ca
Merge pull request #13039 from zenador/make-anno-err-visible
...
Make it possible to unwrap annotation error
2023-10-27 23:31:04 +02:00
Levi Harrison
8db8ad1bae
bump version ( #13032 )
...
Signed-off-by: Levi Harrison <git@leviharrison.dev>
2023-10-27 23:25:56 +02:00
Jeanette Tan
754e7df97e
Make it possible to unwrap annotation errors
...
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2023-10-28 01:11:49 +08:00
Charles Korn
667a1efb04
Add trace ID to log lines emitted during rule evaluation
...
Signed-off-by: Charles Korn <charles.korn@grafana.com>
2023-10-26 16:14:54 +11:00
Charles Korn
fc132a4557
Use common logger instance to reduce duplication in `Group.Eval()`
...
Signed-off-by: Charles Korn <charles.korn@grafana.com>
2023-10-26 16:14:12 +11:00
Bryan Boreham
05356e76de
Build: remove -a from build to speed up rebuilds ( #13026 )
...
I think this is a hold-over from when Go was less careful about separating architectures.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-10-25 16:06:17 +01:00
Levi Harrison
7bdabb01d2
Release 2.48.0-rc.1 ( #13028 )
...
Signed-off-by: Levi Harrison <git@leviharrison.dev>
2023-10-25 12:33:03 +01:00
Björn Rabenstein
c8332a852e
Merge pull request #13031 from zenador/hide-pos-info-for-warnings
...
Hide position info for warnings when position is unknown
2023-10-25 13:08:35 +02:00
Jeanette Tan
72cc93d225
Hide position info for warnings when position is unknown (empty query string passed in)
...
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
2023-10-25 18:10:42 +08:00