prometheus

Commit Graph

Author	SHA1	Message	Date
Giedrius Statkevičius	e452308e37	discovery/kubernetes: optimize resolvePodRef resolvePodRef is in a hot path: ``` ROUTINE ======================== github.com/prometheus/prometheus/discovery/kubernetes.(Endpoints).resolvePodRef in discovery/kubernetes/endpoints.go 2.50TB 2.66TB (flat, cum) 22.28% of Total . . 447:func (e Endpoints) resolvePodRef(ref apiv1.ObjectReference) apiv1.Pod { . . 448: if ref == nil \|\| ref.Kind != "Pod" { . . 449: return nil . . 450: } 2.50TB 2.50TB 451: p := &apiv1.Pod{} . . 452: p.Namespace = ref.Namespace . . 453: p.Name = ref.Name . . 454: . 156.31GB 455: obj, exists, err := e.podStore.Get(p) . . 456: if err != nil { . . 457: level.Error(e.logger).Log("msg", "resolving pod ref failed", "err", err) . . 458: return nil . . 459: } . . 460: if !exists { ``` This is some low hanging fruit that we can easily optimize. The key of an object has format "namespace/name" so generate that inside of Prometheus itself and use pooling. ``` goos: linux goarch: amd64 pkg: github.com/prometheus/prometheus/discovery/kubernetes cpu: Intel(R) Core(TM) i9-10885H CPU @ 2.40GHz │ olddisc │ newdisc │ │ sec/op │ sec/op vs base │ ResolvePodRef-16 516.3n ± 17% 289.5n ± 7% -43.92% (p=0.000 n=10) │ olddisc │ newdisc │ │ B/op │ B/op vs base │ ResolvePodRef-16 1168.00 ± 0% 24.00 ± 0% -97.95% (p=0.000 n=10) │ olddisc │ newdisc │ │ allocs/op │ allocs/op vs base │ ResolvePodRef-16 2.000 ± 0% 2.000 ± 0% ~ (p=1.000 n=10) ¹ ¹ all samples are equal ``` Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>	1 month ago
bas smit	73997289c3	tests: update discovery tests with new labael Previous commit added the pod_container_init label to discovery, so all the tests need to reflect that. Signed-off-by: bas smit <bsmit@bol.com>	2 months ago
bas smit	7a90d73fa6	sd k8s: test for sidecar container support in endpoints This test is expected to fail, the followup will add the feature Signed-off-by: bas smit <bsmit@bol.com>	2 months ago
cuiweiyuan	1800af54f0	chore: fix some function names Signed-off-by: cuiweiyuan <cuiweiyuan@aliyun.com>	4 months ago
Ayoub Mrini	581d8d86b4	Pod status changes not discovered by Kube Endpoints SD (#13337 ) * fix(discovery/kubernetes/endpoints): react to changes on Pods because some modifications can occur on them without triggering an update on the related Endpoints (The Pod phase changing from Pending to Running e.g.). --------- Signed-off-by: machine424 <ayoubmrini424@gmail.com> Co-authored-by: Guillermo Sanchez Gavier <gsanchez@newrelic.com>	10 months ago
Julien Pivotto	2bdb2e627f	Merge pull request #10914 from wangrzneu/add-endpointslice-label Add more labels for endpointslice and endpoints role in k8s discovery	1 year ago
Julien Pivotto	076056ccdf	Merge pull request #11642 from zoonage/main Do not add pods to target group if the PodIP status is not set	1 year ago
renzheng.wang	98ffad01b8	update tests and docs Signed-off-by: renzheng.wang <wangrzneu@gmail.com>	2 years ago
Mickael Carl	2f35619710	discovery/kubernetes: attach node labels when the endpoints TargetRef's kind are Node Signed-off-by: Mickael Carl <mcarl@apple.com>	2 years ago
Aaron George	d542483e8c	k8s discovery: Ensure that the pod IP is in the status before adding to target group Signed-off-by: Aaron George <aaron@ometria.com> Signed-off-by: Aaron George <aaron@ometria.com>	2 years ago
Robert Fratto	97be65387d	discovery/kubernetes: fix broken tests Signed-off-by: Robert Fratto <robertfratto@gmail.com>	2 years ago
Filip Petkovski	05da373dcb	kubernetes_sd: Allow attaching node labels for endpoint role The Kubernetes service discovery can only add node labels to targets from the pod role. This commit extends this functionality to the endpoints and endpointslices roles. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>	2 years ago
fpetkovski	de87515b24	Implement target discovery in own k8s namespace This commit adds support for discovering targets from the same Kubernetes namespace as the Prometheus pod itself. Own-namespace discovery can be indicated by using "." as the namespace. Fixes #9782 Signed-off-by: fpetkovski <filip.petkovsky@gmail.com>	3 years ago
Mateusz Gozdek	1a6c2283a3	Format Go source files using 'gofumpt -w -s -extra' Part of #9557 Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>	3 years ago
Tariq Ibrahim	06a6621b6c	update kubernetes to v1.18.x and update ingress apiVersion Signed-off-by: Tariq Ibrahim <tariq181290@gmail.com>	5 years ago
Tariq Ibrahim	0730d6eb74	remove deprecated methods from the MetricProvider interface Signed-off-by: Tariq Ibrahim <tariq181290@gmail.com>	5 years ago
Simon Pasquier	3441ecdea1	discovery/kubernetes: add node name and hostname to endpoints Signed-off-by: Simon Pasquier <spasquie@redhat.com>	6 years ago
Simon Pasquier	559237cc4f	discovery/kubernetes: fix missing label sanitization (#5462 ) Signed-off-by: Simon Pasquier <spasquie@redhat.com>	6 years ago
Simon Pasquier	dafd1632a2	discovery/kubernetes: add present labels for labels/annotations (#5443 ) Signed-off-by: Simon Pasquier <spasquie@redhat.com>	6 years ago
Tariq Ibrahim	bfcdba211f	remove the prepended watch reactor from the fake k8s client (#5140 ) Signed-off-by: tariqibrahim <tariq.ibrahim@microsoft.com>	6 years ago
Bryan Boreham	cf37e1feb4	Add __meta_kubernetes_pod_phase label in discovery (#4824 ) This lets you add a relabel rule to drop scrapes for pods which are not running. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	6 years ago
jojohappy	21e50a3f9d	Upgrade k8s client to kubernetes-1.11.0 Signed-off-by: jojohappy <sarahdj0917@gmail.com>	6 years ago
Simon Pasquier	6eab4bbca1	kubernetes_sd: fix namespace filtering (#4273 ) Signed-off-by: Simon Pasquier <spasquie@redhat.com>	7 years ago
beorn7	a4e4bec3fe	Merge branch 'release-2.2'	7 years ago
Yecheng Fu	8ceb8f2ae8	Refactor Kubernetes Discovery Part 2: Refactoring - Do initial listing and syncing to scrape manager, then register event handlers may lost events happening in listing and syncing (if it lasted a long time). We should register event handlers at the very begining, before processing just wait until informers synced (sync in informer will list all objects and call OnUpdate event handler). - Use a queue then we don't block event callbacks and an object will be processed only once if added multiple times before it being processed. - Fix bug in `serviceUpdate` in endpoints.go, we should build endpoints when `exists && err == nil`. Add `^TestEndpointsDiscoveryWithService` tests to test this feature. Testing: - Use `k8s.io/client-go` testing framework and fake implementations which are more robust and reliable for testing. - `Test\w+DiscoveryBeforeRun` are used to test objects created before discoverer runs - `Test\w+DiscoveryAdd\w+` are used to test adding objects - `Test\w+DiscoveryDelete\w+` are used to test deleting objects - `Test\w+DiscoveryUpdate\w+` are used to test updating objects - `TestEndpointsDiscoveryWithService\w+` are used to test endpoints events triggered by services - `cache.DeletedFinalStateUnknown` related stuffs are removed, because we don't care deleted objects in store, we only need its name to send a specical `targetgroup.Group` to scrape manager Signed-off-by: Yecheng Fu <cofyc.jackson@gmail.com>	7 years ago
Yecheng Fu	56ed29fbf7	Map target infos of endpoints to prometheus meta labels. (#3770 )	7 years ago
pasquier-s	bde64cf5a6	Fix Kubernetes endpoints SD for empty subsets (#3660 ) * Fix Kubernetes endpoints SD for empty subsets When an endpoints object has no associated pods (replica scaled to zero for instance), the endpoints SD should return a target group with no targets so that the SD manager propagates this information to the scrape manager. Fixes #3659 * Don't send nil target groups from the Kubernetes SD This is to be consistent with the endpoints SD part.	7 years ago
Shubheksha Jalan	ec94df49d4	Refactor SD configuration to remove `config` dependency (#3629 ) * refactor: move targetGroup struct and CheckOverflow() to their own package * refactor: move auth and security related structs to a utility package, fix import error in utility package * refactor: Azure SD, remove SD struct from config * refactor: DNS SD, remove SD struct from config into dns package * refactor: ec2 SD, move SD struct from config into the ec2 package * refactor: file SD, move SD struct from config to file discovery package * refactor: gce, move SD struct from config to gce discovery package * refactor: move HTTPClientConfig and URL into util/config, fix import error in httputil * refactor: consul, move SD struct from config into consul discovery package * refactor: marathon, move SD struct from config into marathon discovery package * refactor: triton, move SD struct from config to triton discovery package, fix test * refactor: zookeeper, move SD structs from config to zookeeper discovery package * refactor: openstack, remove SD struct from config, move into openstack discovery package * refactor: kubernetes, move SD struct from config into kubernetes discovery package * refactor: notifier, use targetgroup package instead of config * refactor: tests for file, marathon, triton SD - use targetgroup package instead of config.TargetGroup * refactor: retrieval, use targetgroup package instead of config.TargetGroup * refactor: storage, use config util package * refactor: discovery manager, use targetgroup package instead of config.TargetGroup * refactor: use HTTPClient and TLS config from configUtil instead of config * refactor: tests, use targetgroup package instead of config.TargetGroup * refactor: fix tagetgroup.Group pointers that were removed by mistake * refactor: openstack, kubernetes: drop prefixes * refactor: remove import aliases forced due to vscode bug * refactor: move main SD struct out of config into discovery/config * refactor: rename configUtil to config_util * refactor: rename yamlUtil to yaml_config * refactor: kubernetes, remove prefixes * refactor: move the TargetGroup package to discovery/ * refactor: fix order of imports	7 years ago
Tom Wilkie	9811e90d65	Fix tests.	7 years ago
Fabian Reinartz	d21f149745	*: migrate to go-kit/log	7 years ago
Fabian Reinartz	ddbbd2b712	Merge branch 'release-1.5' into cut162	8 years ago
Fabian Reinartz	2ff8855ae6	discovery/k8s: update client library	8 years ago
Tobias Schmidt	58cd39aacd	Follow golang naming conventions in discovery packages	8 years ago
Fabian Reinartz	d19d1bcad3	discovery: move into top-level package	8 years ago

34 Commits (ab97c9e09fe74cb57312b4922b9069f28e9ef1b8)