prometheus

Commit Graph

Author	SHA1	Message	Date
beorn7	c3c7d44d84	lint: Adjust to the lint warnings raised by current versions of golint-ci We haven't updated golint-ci in our CI yet, but this commit prepares for that. There are a lot of new warnings, and it is mostly because the "revive" linter got updated. I agree with most of the new warnings, mostly around not naming unused function parameters (although it is justified in some cases for documentation purposes – while things like mocks are a good example where not naming the parameter is clearer). I'm pretty upset about the "empty block" warning to include `for` loops. It's such a common pattern to do something in the head of the `for` loop and then have an empty block. There is still an open issue about this: https://github.com/mgechev/revive/issues/810 I have disabled "revive" altogether in files where empty blocks are used excessively, and I have made the effort to add individual `// nolint:revive` where empty blocks are used just once or twice. It's borderline noisy, though, but let's go with it for now. I should mention that none of the "empty block" warnings for `for` loop bodies were legitimate. Signed-off-by: beorn7 <beorn@grafana.com>	2 years ago
Shihao Xia	d26fd5c97b	fix potential goroutine leaks (#10057 ) Signed-off-by: Shihao Xia <charlesxsh@hotmail.com>	3 years ago
Julien Pivotto	b9c814fce6	Merge pull request #9681 from prometheus/release-2.31 merge back release 2.31	3 years ago
Julien Pivotto	9621c2c0cc	Fix race with targets update during ApplyConfig (#9656 ) I ended up extending the lock so refTargets remains valid for the duration of the update. Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	3 years ago
Mateusz Gozdek	1a6c2283a3	Format Go source files using 'gofumpt -w -s -extra' Part of #9557 Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>	3 years ago
lzhfromustc	d42be7be76	test:Fix two potential goroutine leaks (#8964 ) Signed-off-by: lzhfromustc <lzhfromustc@gmail.com>	3 years ago
Vladimir Kononov	1043d2b594	Discovery: abstain from restarting providers if possible (#9321 ) (#9349 ) * Abstain from restarting discovery providers if possible (#9321) Signed-off-by: Vladimir Kononov <krya-kryak@users.noreply.github.com>	3 years ago
Levi Harrison	b5f6f8fb36	Switched to go-kit/log Signed-off-by: Levi Harrison <git@leviharrison.dev>	4 years ago
Julien Pivotto	6c56a1faaa	Testify: move to require (#8122 ) * Testify: move to require Moving testify to require to fail tests early in case of errors. Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu> * More moves Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	4 years ago
Julien Pivotto	4e5b1722b3	Move away from testutil, refactor imports (#8087 ) Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	4 years ago
Andy Bursavich	4e6a94a27d	Invert service discovery dependencies (#7701 ) This also fixes a bug in query_log_file, which now is relative to the config file like all other paths. Signed-off-by: Andy Bursavich <abursavich@gmail.com>	4 years ago
johncming	01d096567b	discovery: simplify code. (#7725 ) Signed-off-by: johncming <johncming@yahoo.com>	4 years ago
Julien Pivotto	93e9c010f3	Add more Go leak tests (#7652 ) * Implement go leak test for promql Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu> * Implement go leak test for Consul SD Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu> * Implement go leak test in discovery manager Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	4 years ago
ZouYu	f494426f73	fix warning redundant type from array, slice, or map composite literal (#7106 ) Signed-off-by: ZouYu <zouy.fnst@cn.fujitsu.com>	5 years ago
Nevill	7465f27ea5	Refactor on discovery/manager_test.go - Use testutil.ToFloat64 to collect testing metrics - Declare ServiceDiscoveryConfig directly instead of calling Unmarshal on a piece of YAML Signed-off-by: Nevill <nevill.dutt@gmail.com>	5 years ago
Nevill	048f81218d	Change prometheus_sd_configs_failed_total to Gauge Signed-off-by: Nevill <nevill.dutt@gmail.com>	5 years ago
JoeWrightss	e4b88704a6	Fix misspell in manager_test.go (#5279 ) Signed-off-by: zhoulin xie <zhoulin.xie@daocloud.io>	6 years ago
Matt Layher	302148fd69	*: apply gofmt -s Signed-off-by: Matt Layher <mdlayher@gmail.com>	6 years ago
Simon Pasquier	8b91d39c43	discovery: send empty group on empty SD config (#4819 ) * discovery: send empty group on blank SD config Signed-off-by: Simon Pasquier <spasquie@redhat.com> * Update comments Signed-off-by: Simon Pasquier <spasquie@redhat.com> * Add another comment Signed-off-by: Simon Pasquier <spasquie@redhat.com>	6 years ago
Simon Pasquier	e7cee1b5ba	Remove tests redundant with TestTargetUpdatesOrder Signed-off-by: Simon Pasquier <spasquie@redhat.com>	6 years ago
Simon Pasquier	7dc3f11306	WIP discovery: refactor TestTargetUpdatesOrder Signed-off-by: Simon Pasquier <spasquie@redhat.com>	6 years ago
Simon Pasquier	8fd891bf3f	Speed up tests that were still using the 5s timeout Signed-off-by: Simon Pasquier <spasquie@redhat.com>	6 years ago
Simon Pasquier	8289501420	Address krasi's comments Signed-off-by: Simon Pasquier <spasquie@redhat.com>	6 years ago
Simon Pasquier	1cee5b5b06	Don't multiple the interval value by 1ms in the mock Signed-off-by: Simon Pasquier <spasquie@redhat.com>	6 years ago
Simon Pasquier	4900405d2f	Refactor TestCoordinationWithReceiver() to work with any Discoverer Signed-off-by: Simon Pasquier <spasquie@redhat.com>	6 years ago
Simon Pasquier	0798f14e02	Add TestCoordinationWithEmptyProvider Signed-off-by: Simon Pasquier <spasquie@redhat.com>	6 years ago
Simon Pasquier	48989d8996	discovery: add more tests Co-authored-by: Camille Janicki <camille.janicki@gmail.com> Signed-off-by: Simon Pasquier <spasquie@redhat.com>	6 years ago
Krasi Georgiev	ba7eb733e8	tidy up the discovery logs,updating loops and selects (#4556 ) * tidy up the discovery logs,updating loops and selects few objects renamings removed a very noise debug log on the k8s discovery. It would be usefull to show some summary rather than every update as this is impossible to follow. added most comments as debug logs so each block becomes self explanatory. when the discovery receiving channel is full will retry again on the next cycle. Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com> * add noop logger for the SD manager tests. Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com> * spelling nits Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>	6 years ago
Simon Pasquier	674c76adb8	discovery: coalesce identical SD configurations (#3912 ) * discovery: coalesce identical SD configurations Instead of creating as many SD providers as declared in the configuration, the discovery manager merges identical configurations into the same provider and keeps track of the subscribers. When the manager receives target updates from a SD provider, it will broadcast the updates to all interested subscribers. Signed-off-by: Simon Pasquier <spasquie@redhat.com>	6 years ago
Paul Gier	d24d2acd11	config: set target group source index during unmarshalling (#4245 ) * config: set target group source index during unmarshalling Fixes issue #4214 where the scrape pool is unnecessarily reloaded for a config reload where the config hasn't changed. Previously, the discovery manager changed the static config after loading which caused the in-memory config to differ from a freshly reloaded config. Signed-off-by: Paul Gier <pgier@redhat.com> * [issue #4214] Test that static targets are not modified by discovery manager Signed-off-by: Paul Gier <pgier@redhat.com>	7 years ago
Manos Fokas	25f929b772	Yaml UnmarshalStrict implementation. (#4033 ) * Updated yaml vendor package. * remove checkOverflow duplicate in rulefmt * remove duplicated HTTPClientConfig.Validate() * Added yaml static check.	7 years ago
ferhat elmas	ffa673f7d8	General simplifications (#3887 ) Another try as in #1516	7 years ago
Krasi Georgiev	818dda72db	updated the sd tests	7 years ago
Krasi Georgiev	fe926e7829	update the discover tests the discovery test is now only testing update and get groups. It doesn't do an e2e test but just a unit test of setting and receiving target groups	7 years ago
Krasi Georgiev	767faa44b6	fixed the tests Signed-off-by: Krasi Georgiev <krasi.root@gmail.com>	7 years ago
Krasi Georgiev	febebcd49a	more comments for the future ME, and reverted the Discovery manager execution changes as these were correct in the first place	7 years ago
Krasi Georgiev	cabce21b70	delete empty targets sets to avoid memory leaks	7 years ago
Krasi Georgiev	135ea0f793	discovery manager - doesn't need sorting of the target groups so move it in the discovery manager tests as we only need it there. discovery manager - refactor the discovery tests. Signed-off-by: Krasi Georgiev <krasi.root@gmail.com>	7 years ago
Shubheksha Jalan	ec94df49d4	Refactor SD configuration to remove `config` dependency (#3629 ) * refactor: move targetGroup struct and CheckOverflow() to their own package * refactor: move auth and security related structs to a utility package, fix import error in utility package * refactor: Azure SD, remove SD struct from config * refactor: DNS SD, remove SD struct from config into dns package * refactor: ec2 SD, move SD struct from config into the ec2 package * refactor: file SD, move SD struct from config to file discovery package * refactor: gce, move SD struct from config to gce discovery package * refactor: move HTTPClientConfig and URL into util/config, fix import error in httputil * refactor: consul, move SD struct from config into consul discovery package * refactor: marathon, move SD struct from config into marathon discovery package * refactor: triton, move SD struct from config to triton discovery package, fix test * refactor: zookeeper, move SD structs from config to zookeeper discovery package * refactor: openstack, remove SD struct from config, move into openstack discovery package * refactor: kubernetes, move SD struct from config into kubernetes discovery package * refactor: notifier, use targetgroup package instead of config * refactor: tests for file, marathon, triton SD - use targetgroup package instead of config.TargetGroup * refactor: retrieval, use targetgroup package instead of config.TargetGroup * refactor: storage, use config util package * refactor: discovery manager, use targetgroup package instead of config.TargetGroup * refactor: use HTTPClient and TLS config from configUtil instead of config * refactor: tests, use targetgroup package instead of config.TargetGroup * refactor: fix tagetgroup.Group pointers that were removed by mistake * refactor: openstack, kubernetes: drop prefixes * refactor: remove import aliases forced due to vscode bug * refactor: move main SD struct out of config into discovery/config * refactor: rename configUtil to config_util * refactor: rename yamlUtil to yaml_config * refactor: kubernetes, remove prefixes * refactor: move the TargetGroup package to discovery/ * refactor: fix order of imports	7 years ago
Krasi Georgiev	587dec9eb9	rebased and resolved conflicts with the new Discovery GUI page Signed-off-by: Krasi Georgiev <krasi.root@gmail.com>	7 years ago
Krasi Georgiev	80182a5d82	use poolKey as the pool map key to avoid multi dimensional maps	7 years ago
Krasi Georgiev	1ec76d1950	rearange the contexts variables and logic split the groupsMerge function to set and get other small nits	7 years ago
Krasi Georgiev	aca8f85699	fixed the tests	7 years ago
Krasi Georgiev	e405e2f1ea	refactored discovery	7 years ago

44 Commits (a8772a41782758e8153c494dcd207e770d8421a4)