Commit Graph

494 Commits (a7264eb0d455f39981f8eee8c736c958d30a5fef)

Author SHA1 Message Date
Björn Rabenstein b9dd95f499
Merge pull request #15428 from prometheus/beorn7/metrics
notifier: fix increment of metric prometheus_notifications_errors_total
2024-11-26 17:38:59 +01:00
beorn7 e01c5cefac notifier: fix increment of metric prometheus_notifications_errors_total
Previously, prometheus_notifications_errors_total was incremented by
one whenever a batch of alerts was affected by an error during sending
to a specific alertmanager. However, the corresponding metric
prometheus_notifications_sent_total, counting all alerts that were
sent (including those where the sent ended in error), is incremented
by the batch size, i.e. the number of alerts.

Therefore, the ratio used in the mixin for the
PrometheusErrorSendingAlertsToSomeAlertmanagers alert is inconsistent.

This commit changes the increment of
prometheus_notifications_errors_total to the number of alerts that
were sent in the attempt that ended in an error. It also adjusts the
metrics help string accordingly and makes the wording in the alert in
the mixin more precise.

Signed-off-by: beorn7 <beorn@grafana.com>
2024-11-26 15:50:02 +01:00
Konrad c3cc25f552
document scraping change introduced in 2.52.0 (#15148)
* CHANGELOG - scraping change introduced in 2.52.0

Change introduced in #12933; old behavior partially recoved in #14685

Signed-off-by: Konrad <zuo.zp8@gmail.com>
2024-11-26 11:15:01 +00:00
Arve Knudsen 9c02c26418
OTLP receiver: Convert also metric metadata (#15416)
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2024-11-20 11:13:03 +01:00
Bryan Boreham 379304f60a Merge branch 'release-2.53' into merge-release-into-main 2024-11-18 14:48:45 +00:00
Bryan Boreham 210ef03479 Merge branch 'release-2.55' into merge-release-into-main 2024-11-18 14:44:56 +00:00
Bryan Boreham 26886d6d95 Merge branch 'release-3.0' into merge-release-into-main 2024-11-18 14:43:56 +00:00
Jan Fajerski d541b3bbeb prepare release 3.0.0
Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
2024-11-13 15:41:05 +01:00
Julien ebc45750ef Fix release date
Closes #15385

Signed-off-by: Julien <roidelapluie@o11y.eu>
2024-11-12 10:34:58 +01:00
Joshua Hesketh ed2668bbda
Merge branch 'main' into jhesketh/clamp
Signed-off-by: Joshua Hesketh <josh@nitrotech.org>
2024-11-12 10:20:58 +11:00
bwplotka 22eec4a390 Updated CHANGELOG.md
Signed-off-by: bwplotka <bwplotka@gmail.com>
2024-11-11 22:34:49 +00:00
Bartlomiej Plotka 7311ce3c00 Update CHANGELOG.md
Co-authored-by: Ben Kochie <superq@gmail.com>
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
2024-11-11 22:32:26 +00:00
Jan Fajerski 3067d0bc2f update CHANGELOG and migration guide
Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
2024-11-11 22:32:26 +00:00
alexgreenbank e7c0d21a8b add CHANGELOG entry
Signed-off-by: alexgreenbank <alex.greenbank@grafana.com>
2024-11-07 15:43:45 +00:00
Bryan Boreham 16217a6fcc Make release 2.53.3 LTS
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-11-04 20:01:03 +00:00
Bryan Boreham f83f3dc7c6 Merge remote-tracking branch 'origin/release-2.55' into merge-2.55-into-main2 2024-11-04 14:29:10 +00:00
Jan Fajerski 1ac3ca9528 Release 3.0.0-rc.0
Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
2024-11-04 14:19:32 +01:00
Bryan Boreham cfeaa2c1f1 Create release 2.55.1
With one bugfix.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-11-04 12:47:16 +00:00
Arve Knudsen 7c4f877881
otlptranslator: Harmonize non-UTF8 sanitization w/ naming rules. (#15314)
* otlptranslator: Harmonize non-UTF8 sanitization w/ naming rules.

Harmonize non-UTF8 sanitization w/ Prometheus naming rules.

---------

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2024-11-03 12:56:54 +00:00
Jan Fajerski 5fdd382ec3 CHANGELOG: remove duplicate entry
Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
2024-10-31 16:22:59 +01:00
Jan Fajerski e2f55c34c9 fix CHANGELOG formatting and add entry for #14694
Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
2024-10-29 14:41:50 +01:00
Jan Fajerski 3acb3144fe update CHANGELOG
Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
2024-10-26 09:03:10 +02:00
Jan Fajerski 38fd48e6b5 v2.55.0
-----BEGIN SSH SIGNATURE-----
 U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgX42TrpDUXJbbi9yZ3hs6cDg+kz
 G6d3nAlAb2XQInrEgAAAADZ2l0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5
 AAAAQGoSEKIFT/BfavtG2qW9n7NYonNQk/9r6gCLvxln9elt1hiY0ZGcwRhm1QNx6FotxJ
 Y3LB9dt4s5akB3fOPkYwc=
 -----END SSH SIGNATURE-----

Merge tag 'v2.55.0' into release-3.0.0-rc.0

v2.55.0
2024-10-25 14:16:22 +02:00
Bryan Boreham 20fdc8f541 [CHANGE] Remote-write: default enable_http2 to false
Remote-write creates several shards to parallelise sending, each with
its own http connection. We do not want them all combined onto one
socket by http2.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-10-24 22:27:06 +02:00
Vanshika cccbe72514
TSDB: Fix some edge cases when OOO is enabled (#14710)
Fix some edge cases when OOO is enabled

Signed-off-by: Vanshikav123 <vanshikav928@gmail.com>
Signed-off-by: Vanshika <102902652+Vanshikav123@users.noreply.github.com>
Signed-off-by: Jesus Vazquez <jesusvzpg@gmail.com>
Co-authored-by: Jesus Vazquez <jesusvzpg@gmail.com>
2024-10-23 17:34:28 +02:00
Bryan Boreham bb27c6b896 Create release 2.55.0
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-10-22 09:31:02 +01:00
Alex Greenbank 421a3c22ea
scrape: provide a fallback format (#15136)
scrape: Remove implicit fallback to the Prometheus text format

Remove implicit fallback to the Prometheus text format in case of invalid/missing Content-Type and fail the scrape instead. Add ability to specify a `fallback_scrape_protocol` in the scrape config.

---------

Signed-off-by: alexgreenbank <alex.greenbank@grafana.com>
Signed-off-by: Alex Greenbank <alex.greenbank@grafana.com>
Co-authored-by: Björn Rabenstein <beorn@grafana.com>
2024-10-18 17:12:31 +02:00
Bryan Boreham 754c104a3e
Merge pull request #15173 from prometheus/merge-2.55-into-main-3
Merge release-2.55 into main (interim)
2024-10-18 10:28:20 +01:00
Bryan Boreham 2788d2038e Add CHANGELOG entry for #12532
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-10-16 15:08:58 +01:00
Bryan Boreham a846bf9a5e Merge branch 'release-2.55' into merge-2.55-into-main-3 2024-10-16 14:08:54 +01:00
Joshua Hesketh 5a4e4f6936
Fix stddev/stdvar when aggregating histograms, NaNs, and infinities (#14941)
promql: Fix stddev/stdvar when aggregating histograms, NaNs, and Infs

Native histograms are ignored when calculating stddev or stdvar.

However, for the first series of each group, a `groupedAggregation` is
always created. If the first series that was encountered is a histogram
then it acts as the equivalent of a 0 point.

This change creates the first `groupedAggregation` with the `seen` field set to `false` if the point is a
histogram, thus ignoring it like the rest of the aggregation function does. A new `groupedAggregation`
will then be created once an actual float value is encountered.

This commit also sets the `floatValue` field of the `groupedAggregation` to `NaN`, if the first
float value of a group is `NaN` or `±Inf`, so that the outcome is consistently `NaN` once those
values are in the mix.

(The added tests fail without this change).

Signed-off-by: Joshua Hesketh <josh@nitrotech.org>
Signed-off-by: beorn7 <beorn@grafana.com>

---------

Signed-off-by: Joshua Hesketh <josh@nitrotech.org>
Signed-off-by: beorn7 <beorn@grafana.com>
Co-authored-by: beorn7 <beorn@grafana.com>
2024-10-16 15:00:46 +02:00
Bryan Boreham 8ea2c6adce Prepare release 2.55.0-rc.1
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-10-16 13:56:24 +01:00
Arve Knudsen de16f5e387
[FEATURE] PromQL: Add experimental info function MVP (#14495)
The `info` function is an experiment to improve UX
around including labels from info metrics.
`info` has to be enabled via the feature flag `--enable-feature=promql-experimental-functions`.

This MVP of info simplifies the implementation by assuming:
* Only support for the target_info metric
* That target_info's identifying labels are job and instance

Also:
* Encode info samples' original timestamp as sample value
* Deduce info series select hints from top-most VectorSelector

---------

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Co-authored-by: Ying WANG <ying.wang@grafana.com>
Co-authored-by: Augustin Husson <augustin.husson@amadeus.com>
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
Co-authored-by: Björn Rabenstein <github@rabenste.in>
Co-authored-by: Bryan Boreham <bjboreham@gmail.com>
2024-10-16 13:52:11 +01:00
Joshua Hesketh 2294712fe8 Update CHANGELOG
Signed-off-by: Joshua Hesketh <josh@nitrotech.org>
2024-10-16 15:11:01 +11:00
Bryan Boreham eaf98049e5 Few more 3.0-beta.1 CHANGELOGs
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-10-08 18:15:55 +01:00
Bryan Boreham eb90f238b7 Update CHANGELOG to commit 90f7832447
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-10-08 17:31:05 +01:00
Bryan Boreham 9623681543 Prepare 3.0.0-beta.1
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-10-08 17:27:10 +01:00
Jesus Vazquez e99e7ca9cf
README: Update readme with API flag change for the otlp receiver (#15073)
Signed-off-by: Jesus Vazquez <jesusvzpg@gmail.com>
2024-10-02 10:40:31 +00:00
Bryan Boreham 6b247c50d2 Revert "Merge pull request #14769 from roidelapluie/autoreload"
This reverts commit 50f5327f83, reversing
changes made to eb4004c344.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-09-30 17:10:32 -04:00
Bryan Boreham 7f99d2930d [BUGFIX] PromQL: make sort_by_label stable
Go's sorting functions can re-order equal elements, so the strategy of
sorting by the fallback ordering first does not always work.
Pulling the fallback into the main comparison function is more reliable
and more efficient.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-09-26 11:12:33 +01:00
Bryan Boreham 4c90118361 Remove CHANGELOG duplicate line
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>

#14402 is the issue and #14403 is the fix.
2024-09-22 17:53:41 +01:00
Bryan Boreham ca673eb749 Merge remote-tracking branch 'origin/release-2.55' into merge-2.55-into-main
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-09-22 17:49:34 +01:00
Bryan Boreham e3f5c7c2a0 [Release 2.55] Update CHANGELOG
Make text more consistent with 3.0 branch

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-09-22 17:42:04 +01:00
Bryan Boreham e3617cbd2c Add #14948 to CHANGELOG
Also update the date of the RC which hasn't gone out yet.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-09-20 17:48:04 +01:00
Jan Fajerski aa6dd70812 changelog: record holt_winters rename
Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
2024-09-19 15:29:09 +02:00
Bryan Boreham 06022a6509 CHANGELOG: Add #14821
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-09-19 14:07:55 +01:00
Bryan Boreham 81b9407f15 Prepare release 2.55.0-rc.0
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-09-19 12:38:12 +01:00
Joshua Hesketh b6107cc888
Make rate possible non-counter annotation consistent (#14910)
* Make rate possible non-counter annotation consistent

Previously a PossibleNonCounterInfo annotation would be left in cases
where a range-vector selects 1 float data point, even if no more points
are selected in order to calculate a rate.

This change ensures an output float exists before emitting such an
annotation.

This fixes an inconsistency where a series with mixed data (ie, a float
and a native histogram) would emit an annotation without any points.

For example,

```

load 1m
series{label="a"} 1 {{schema:1 sum:10 count:5 buckets:[1 2 3]}}

eval instant at 1m rate(series[1m1s])

```

Would have a PossibleNonCounterInfo annotation.

Wheras

```

load 1m
series{label="a"} {{schema:1 sum:10 count:5 buckets:[1 2 3]}} {{schema:1 sum:15 count:10 buckets:[1 2 3]}}

eval instant at 1m rate(series[1m1s])

```

Would not. 

---------

Signed-off-by: Joshua Hesketh <josh@nitrotech.org>
2024-09-18 10:21:25 +00:00
Nathan Baulch 50cd453c8f
chore: Fix typos (#14868)
* Fix typos

---------

Signed-off-by: Nathan Baulch <nathan.baulch@gmail.com>
2024-09-10 22:32:03 +02:00
Fiona Liao 1ac1e00999 Fix ENHANCEMENT typo
Signed-off-by: Fiona Liao <fiona.liao@grafana.com>
2024-09-10 17:01:09 +01:00